From patchwork Wed Feb 18 21:47:33 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4778 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:525e:b0:838:aef6:1aff with SMTP id e30csp394100mag; Wed, 18 Feb 2026 13:47:54 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCW6JNorPLIwJAI7pteARvuL4tFThrHxe9a3VD0eturjpzn68DSdLujBTuwx1mLpunvygX2ud4Ms134=@openvpn.net X-Received: by 2002:a05:6830:4487:b0:7cf:ddee:687c with SMTP id 46e09a7af769-7d4d0a8c8e3mr8364270a34.3.1771451274244; Wed, 18 Feb 2026 13:47:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1771451274; cv=none; d=google.com; s=arc-20240605; b=Y2wcNIyY3GXvGMuAIzKB9BfRuCuXsjiQD7gngQZbwl0XU7wIERxRGu/YqocPnaWNWW riJgOChEW3q+dVwwGmWOrb2aBi3CoqFN6QrYJFL7lnNExIbX37+dRi1aijG/zMqKwU+q wbGmQhRTUyocn1bqFqVpX0cJZjHmWq240IbE2xrxTSrjhJGf5ovlkI2scWh/SFu/4g5C qOKjcNiyBtZB7+j20roH2LKJxK23q7CWXfMYicSmfE82na1ST5DBxRTpVwRzxK93JA/b HHGQIemmeQYTlnqEisekGD74aPDeymgeePBNhiEoZH2X7euXGhoPAjkcjB+bL8W5nHsh n01w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=pIza6eCx+d1rwEPIBPuLD2XTvkjlIzyTZFmG/xxIwTg=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=Wh1MILkpukvRLUfNWVhvgWljEXCAVg15yw2sav6gv1uM6tLQfM7xtrBbkcmRVWW8kN C0hh9nqxLDcTNXDSQM4URyJqqYbm1/KmiLxf5veg7grRrNUKCZovir3hNfB0tqRH1wDp om6wR0F5myxypV1Z1P0IrYTaG+sxE1IMWzeg/Uww3EzSF+3M9m0kvtQFdsjIGtyRrGdJ FiVSw+adL1HVmhgzPixwdb3ZG+S+zeJkNbziPkAqhxYMEaOQFBDhd+6wnK08FE37jQpU Z0vi8FsH9ppYh0w1DpGH8u0jdtid0dn6AeC5quXIhFK775k4TcKwW0yvGgYtcEhihtJt CYlA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b="nD6/so2o"; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=BATcb5qM; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=B8Z1tNgk; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 46e09a7af769-7d4c6ecbba1si10081440a34.27.2026.02.18.13.47.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Feb 2026 13:47:54 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b="nD6/so2o"; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=BATcb5qM; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=B8Z1tNgk; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pIza6eCx+d1rwEPIBPuLD2XTvkjlIzyTZFmG/xxIwTg=; b=nD6/so2o/pz2aoY7a2o6BwE+YH pQvVQ9SxOskqPdv418aMMlK+KcVkFN3kesK5acv56R3UM5gOEmkA/jE1XGHSlvp6w8cZ2pHxdtLyz YTD5rSDQg5d+EulwajFpwDEuXAy6S2fiO4be5vZt7sGdQnGBLDJQrb1Hu/Gqsa5UPam0=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vspOi-0003FE-4M; Wed, 18 Feb 2026 21:47:52 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vspOh-0003F8-AL for openvpn-devel@lists.sourceforge.net; Wed, 18 Feb 2026 21:47:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=56xNNN1HYTjcxWSJjDzU1GS3GJf98YcBs79J0itV2vY=; b=BATcb5qMtB2O9kXfJsTmeKEawq WdPat3xBFhZY3C79HIodIcOdhWvqYKdJGmk1X3bOnKObnZ5jWWnOlhr3Q2YRwNiPqhTzIHUbF77+z FuZAnU7OmjV/xBf3E2hp7GS1sp0YalksgJLrOEpmFgVZ+PBJSrPcYqQQspGn30DyvnyY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=56xNNN1HYTjcxWSJjDzU1GS3GJf98YcBs79J0itV2vY=; b=B8Z1tNgkJIssXm0MzWigFNzM3i hs16Ga/SadbgP4zqxpzlZKkPrS1PcM68ZVHVN9ICdF5umPXpY+fqPQEuylzo+qt0MQ1SbOwKZZfY7 QgQEo7O+CeOqHQgOx4yUugSdzyi5ZkXyG6jW72mX+38HkZL4ej6jncsapfPByuF/bLY8=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vspOg-0008MY-Dl for openvpn-devel@lists.sourceforge.net; Wed, 18 Feb 2026 21:47:51 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 61ILlc0Q027172 for ; Wed, 18 Feb 2026 22:47:38 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 61ILlcOo027171 for openvpn-devel@lists.sourceforge.net; Wed, 18 Feb 2026 22:47:38 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Wed, 18 Feb 2026 22:47:33 +0100 Message-ID: <20260218214738.27158-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Rudi Heitbaum Since glibc-2.43: For ISO C23, the functions bsearch, memchr, strchr, strpbrk, strrchr, strstr, wcschr, wcspbrk, wcsrchr, wcsstr and wmemchr that return pointers into their input arrays now have definitions as macros t [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1vspOg-0008MY-Dl Subject: [Openvpn-devel] [PATCH v1] dns: fix discards 'const' qualifier from pointer target type X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1857501291127733420?= X-GMAIL-MSGID: =?utf-8?q?1857501291127733420?= From: Rudi Heitbaum Since glibc-2.43: For ISO C23, the functions bsearch, memchr, strchr, strpbrk, strrchr, strstr, wcschr, wcspbrk, wcsrchr, wcsstr and wmemchr that return pointers into their input arrays now have definitions as macros that return a pointer to a const-qualified type when the input argument is a pointer to a const-qualified type. fixes: src/openvpn/dns.c: In function 'dns_server_addr_parse': src/openvpn/dns.c:67:25: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 67 | char *first_colon = strchr(addr, ':'); | ^~~~~~ src/openvpn/dns.c:68:24: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 68 | char *last_colon = strrchr(addr, ':'); | ^~~~~~~ Change-Id: I262705189edfbd9aa9a32bcd712840fffa592435 Signed-off-by: Rudi Heitbaum Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1542 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1542 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpn/dns.c b/src/openvpn/dns.c index 3d24050..747c0db 100644 --- a/src/openvpn/dns.c +++ b/src/openvpn/dns.c @@ -45,7 +45,7 @@ * @return True if parsing was successful */ static bool -dns_server_port_parse(in_port_t *port, char *port_str) +dns_server_port_parse(in_port_t *port, const char *port_str) { char *endptr; errno = 0; @@ -71,8 +71,8 @@ in_port_t port = 0; sa_family_t af; - char *first_colon = strchr(addr, ':'); - char *last_colon = strrchr(addr, ':'); + const char *first_colon = strchr(addr, ':'); + const char *last_colon = strrchr(addr, ':'); if (!first_colon || first_colon == last_colon) { @@ -93,7 +93,7 @@ if (addr[0] == '[') { addr += 1; - char *bracket = last_colon - 1; + const char *bracket = last_colon - 1; if (*bracket != ']' || bracket == addr || !dns_server_port_parse(&port, last_colon + 1)) { return false;