diff mbox series

[Openvpn-devel,v3] Fixup version command on management interface

Message ID 20260224172610.292608-1-frank@lichtenheld.com
State New
Headers show
Series [Openvpn-devel,v3] Fixup version command on management interface | expand

Commit Message

Frank Lichtenheld Feb. 24, 2026, 5:26 p.m. UTC 
From: Selva Nair <selva.nair@gmail.com>

All commands to the management interface are supposed to be
responded with either a one-line "SUCCESS:/ERROR:" message
or a multi-line reply terminated by "END". But, curently we
silently accept the "version n" command wih no response. This
causes clients like OpenVPN-GUI lock-up if version command is
used, waiting for ever for a reply.

Fix this by adding a SUCCESS/ERROR response.

Change-Id: I76dc80a9d9b29e401b7bbd59e0c46baf751d2e4a
Signed-off-by: Selva Nair <selva.nair@gmail.com>
Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1528
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1528
This mail reflects revision 3 of this Change.

Acked-by according to Gerrit (reflected above):
Frank Lichtenheld <frank@lichtenheld.com>
diff mbox series

Patch

diff --git a/src/openvpn/manage.c b/src/openvpn/manage.c
index 37ae6b3..f0408d8 100644
--- a/src/openvpn/manage.c
+++ b/src/openvpn/manage.c
@@ -1333,6 +1333,11 @@ 
     if (version)
     {
         man->connection.client_version = atoi(version);
+        msg(M_CLIENT, "SUCCESS: Management client version set to %d", man->connection.client_version);
+    }
+    else
+    {
+        msg(M_CLIENT, "ERROR: Invalid value specified for management client version");
     }
 }