From patchwork Tue Feb 24 17:26:10 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Lichtenheld X-Patchwork-Id: 4781 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:6e08:b0:83c:d90d:321 with SMTP id bn8csp284597mab; Tue, 24 Feb 2026 09:26:41 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWZLvZiAgJX2KhXQjQbX5maAWydSOOClCNsbDiQ+Ik+51EhaTGiwCrPaI3cFz1iHTkmSwo3NdNw56k=@openvpn.net X-Received: by 2002:a05:6871:3609:b0:3e9:7744:1d4b with SMTP id 586e51a60fabf-4157abdb011mr7629823fac.4.1771954001033; Tue, 24 Feb 2026 09:26:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1771954001; cv=none; d=google.com; s=arc-20240605; b=c7L1So/lb1ymmw0dLx1Shb5hqmi65/tZFRf74Yk8WOewlpSQ4jwdCzqvMwa+/tu48u iH/iWnKgDzO0DkRTyvvTOsvf91BRZNExUI1UhOQ9w5PS5+v+jOi3j4nkTYnDm1YfT56s j+H891dlN2JWjDPzhseTFBczu36d6UG5m1MCfz9GP9MgpKEnrdHqWwvt3PyiNhBHq5tr 8NmgS+gz0uZ2mTZ3JbprnNRovOhirhg5UiI2cYjpUsCIHDwQzkyPBu8Ex6Yhqu+9n9yW 1tIWHWevWJWZ6hiW5s4KyEzRmpBzm94Roe63TpaQaXOkeZx9qYI8i+dxJW+rfQ84snpQ cfVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature:dkim-signature; bh=fMT7Py0uL7Fd38WwmGX/P4t8de09+R3JLTKfj+STMsI=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=e+hzokliYljz4ioED2rYkgHHvUQYqPiUygCihpafYg/awuxDLfWaCPgpoLS3A7a/A5 UKCyrwlkf+K1AaxpcIJDEcRbyWrHhVrrJRjSy0sSqIVikNqNb91oy88dZlcQib/nCgQc ycYW1XRGGaWlsy2DcJb4s6pgbfNfI6dVp6iitBm5iB8tjPl6wbcwCEna6XDxHasiGiAy d8ayX/lKkq1gTArngB6P9z7hX+KXaMQn6GlfJ1Kr6Nxss9zZv0NxMo3ZcPzuySjX7uWb QhJ+fDECA51/RF6a65iNikVVYHElR33VBk/4BfxcBfbV78ITtjl737yCjQrKRgJsq0v2 rXmQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=Qudpa+49; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=I0HVlXwR; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=hpjm9mgx; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=kOdtS4BV; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-4157d3c6f36si8309405fac.239.2026.02.24.09.26.40 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Feb 2026 09:26:41 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=Qudpa+49; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=I0HVlXwR; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=hpjm9mgx; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=kOdtS4BV; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fMT7Py0uL7Fd38WwmGX/P4t8de09+R3JLTKfj+STMsI=; b=Qudpa+49YdZlRQe9gRzwHlTKgr Jjfb3lbd+s8B6NNV3bba1Y0UPkr22fcyh9fRmf1QQV7QLrKNismxPTk5vIbs7+ip4TSm22SZUoyfB b/GD4qy6xdPDlAepOZ7Yx2jbo2JBlGm2NmGkB6HKGCnKpWO4xTuiTo7RgHjVhz7Mi9fo=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vuwB4-0003Ty-9y; Tue, 24 Feb 2026 17:26:30 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vuwB0-0003Tn-TS for openvpn-devel@lists.sourceforge.net; Tue, 24 Feb 2026 17:26:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gn0rWvbf58x+6VxqasANy1qOrwHoN9dVZmhTyhrK4wk=; b=I0HVlXwREhdG0o4ax7Qd6P6IUy ZY5JC64Q+sX5Y7YkKRzBMiDNw5ebBgXGiGmEaVdWJqf7X0lEJj1jxuteNn/YnB3WLCt2+MCT7xxBg zI59d1XbAA2wZsuHzYicQhkO82+njM4o7lEwZ+ZJcZovqHRxFabRUVm02qA8llmglcyg=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=gn0rWvbf58x+6VxqasANy1qOrwHoN9dVZmhTyhrK4wk=; b=hpjm9mgxbS9Fch/dw/MMBLa9aW sCvTEbd+N0Wik4o/EYhyOKdr2F40sltFq4SloxNmctezrQ0l7ZQnbPZgD/Yhmu/ovJQZmUnu+ooqs XF62q9fRryuK71js1duuNHTpisUl+6qvkRtfuCunJ5+eWIa/YICXJHppBFMi0Af0LkCI=; Received: from mout-p-201.mailbox.org ([80.241.56.171]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vuwAz-0002O4-12 for openvpn-devel@lists.sourceforge.net; Tue, 24 Feb 2026 17:26:26 +0000 Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4fL4Pv34P3z9tV9; Tue, 24 Feb 2026 18:26:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lichtenheld.com; s=MBO0001; t=1771953971; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gn0rWvbf58x+6VxqasANy1qOrwHoN9dVZmhTyhrK4wk=; b=kOdtS4BVGZZ6tN9YwbS3GjhYP6Qd1mrveQlVBmQttktJquoNAOaZa2F5faO5whN+QGPCrN /KOeOx576eE95N7n8oJceRTXXLTU0T/qOfG9z1dof7JrzsH10ar6HrFfuhCVMGuQxYNEzS yqEilZK0nxTo1m37n+BdEb4pVLpEq0Eq2Ib0q2GAtI6H3CoYVqocTGWvj5YKk4rvOkoJTl LbC1aHb9kZBao3n3xBHEII/nhQYd1YyBWYu05x5waxyZi0/UBi53NCf7MiH/EvLIE3RxBA bz1rcUdoxpEG4zXKO3Add/FZkx58G+KQQiiur6oCeHBjwrKMy/fQjkOEHsscKA== From: Frank Lichtenheld To: openvpn-devel@lists.sourceforge.net Date: Tue, 24 Feb 2026 18:26:10 +0100 Message-ID: <20260224172610.292608-1-frank@lichtenheld.com> In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Selva Nair All commands to the management interface are supposed to be responded with either a one-line "SUCCESS:/ERROR:" message or a multi-line reply terminated by "END". But, curently we silently accept the " [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-Headers-End: 1vuwAz-0002O4-12 Subject: [Openvpn-devel] [PATCH v3] Fixup version command on management interface X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1858028438873434563?= X-GMAIL-MSGID: =?utf-8?q?1858028438873434563?= From: Selva Nair All commands to the management interface are supposed to be responded with either a one-line "SUCCESS:/ERROR:" message or a multi-line reply terminated by "END". But, curently we silently accept the "version n" command wih no response. This causes clients like OpenVPN-GUI lock-up if version command is used, waiting for ever for a reply. Fix this by adding a SUCCESS/ERROR response. Change-Id: I76dc80a9d9b29e401b7bbd59e0c46baf751d2e4a Signed-off-by: Selva Nair Acked-by: Frank Lichtenheld Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1528 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1528 This mail reflects revision 3 of this Change. Acked-by according to Gerrit (reflected above): Frank Lichtenheld diff --git a/src/openvpn/manage.c b/src/openvpn/manage.c index 37ae6b3..f0408d8 100644 --- a/src/openvpn/manage.c +++ b/src/openvpn/manage.c @@ -1333,6 +1333,11 @@ if (version) { man->connection.client_version = atoi(version); + msg(M_CLIENT, "SUCCESS: Management client version set to %d", man->connection.client_version); + } + else + { + msg(M_CLIENT, "ERROR: Invalid value specified for management client version"); } }