From patchwork Mon Mar 2 16:35:51 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4788 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:292f:b0:83c:d90d:321 with SMTP id f15csp1899535maw; Mon, 2 Mar 2026 08:36:18 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXdc2XFe0djMy4QTj1XUYdZ17MVkPrlcS8RisVddUZ7vBj7Umht6RUG6MRJHuEBldZeoCm6iNyY+1g=@openvpn.net X-Received: by 2002:a05:6820:3102:b0:67a:5df:7025 with SMTP id 006d021491bc7-67a05df7f33mr4746686eaf.36.1772469378115; Mon, 02 Mar 2026 08:36:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1772469378; cv=none; d=google.com; s=arc-20240605; b=N8WYlhMuIrWDCDSg/G4FgGIylxmf7ICc/y3EClo3JsDnC4hInB3/7JiQAi3RGbLgFr uH8JJgxorK5RaXcDxOBSmBQAcvnBDQJrhuTKQTp9uHYtWubNxZ0HH03qUOdWv+F66+r9 4MIf+Pzg9xHk8h8NlUdm9Nx6KMtr5zxMwPm4oshHBj1cbYd6VcB8jXD0EM0MfAA77mbk JVQ7yJ6Yp8l0YavzbSLBBgwXzGfIzMjfEBwJTxQNNVHS/cv4sD1VKFDqfCxnBKXuQx+M KyyK6v7DozhfE6jW/DDQ+e5p9/bBhL1xkuc+VyCBtVeLccGR6cisprGrsz/9qtS2VT9I x2XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=DWxWJIlQnjkR0mwe6dujdLk0zWszepaQMnFOP540obQ=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=WWNCdAuK3PxZwS1qb9+1D0/JbeOeBAnZNiMeuyIV0njP5UJoKtXf0JmnUOJHi7Jpd4 9Lj9jIyGTZf1KAZnfMd8mL2nrtpldxIxdvzVMSag22QMDyG5c/zkZ/haKUiRyno6gsVj XYoI6uaqOiEWGD/RESXEn9tti4P0VQjc9KUChMI8T3lJltd3uemKA3sK45bc7AJ1MzUd SEbZ+did8lJ2h9DE/gKMVAIwPSvbs/Pt6FnasNGBzK275RfQdeTpO7VrOQ4V/lZbqM3K rIRwTxx4NjCtoWLV+WytXxBiIeohOWAVG2r9QOfG0uA9SW14M21GQalYD0g2hP01HUYg HNmQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=kZ2qLRBd; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=mSrAitGr; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Rek6Wak6; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 006d021491bc7-679f2d128b3si7199138eaf.41.2026.03.02.08.36.17 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Mar 2026 08:36:18 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=kZ2qLRBd; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=mSrAitGr; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Rek6Wak6; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DWxWJIlQnjkR0mwe6dujdLk0zWszepaQMnFOP540obQ=; b=kZ2qLRBdrFKvBYr1VeiesQplpv 9ACgCTS/XXYUbEwYLsvIKeGzoHZzlc64wRVCMSEJ+2JZQ8ZU6WUte2GCVNiPFLWOKdD+zFHrF1xkO sl+XLIbElmogxCgkmc3zBJjU67SSsSXaGv5rpKZUvQUVIajbZUN7yvOJaCvX59+Hw9UI=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vx6Fg-00071M-G9; Mon, 02 Mar 2026 16:36:12 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vx6Fe-00071D-JK for openvpn-devel@lists.sourceforge.net; Mon, 02 Mar 2026 16:36:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Bugsb9YA2j2CNxl4PPerZ4VhTaZViGdpp8JSYV43xic=; b=mSrAitGrKEsmcFAUmAUDTGsItG QAOojFvBlm4S2DtAtwqlbfklvaOR4jajEozZaLSkDRcSO1mtD1AFSvlhAC6NYJl51cxnQVcwUkqvb m3k0iQsWe/GNJrqlR+CRn7uU8TLlFmXJ9PtwjolTwsR7OsAt9CYQoAMyvXrx57GzRjfo=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Bugsb9YA2j2CNxl4PPerZ4VhTaZViGdpp8JSYV43xic=; b=Rek6Wak60aR6D8Yqaz4jZqQgO6 sy7xSsJCihFhv0ghAjnHZvc0CJP0SvO/TI2rqZKPIzwJyp473cg5lmaS4JSC5VXmyyjmUuxpbtHxs 7amMweDZq3iXKQW9KK8PbJsnQqzKTcde/iYrz7k7+Pu2YLfKxMf+gc6407V1jXuCGmJo=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vx6Fd-0000HQ-FG for openvpn-devel@lists.sourceforge.net; Mon, 02 Mar 2026 16:36:10 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 622GZvV5018374 for ; Mon, 2 Mar 2026 17:35:57 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 622GZvZ5018373 for openvpn-devel@lists.sourceforge.net; Mon, 2 Mar 2026 17:35:57 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Mon, 2 Mar 2026 17:35:51 +0100 Message-ID: <20260302163557.18358-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Ralf Lici When a management interface client requests periodic bytecount notifications, openvpn continues to emit them even after the client has disconnected. Additionally, upon reconnecting, the client starts [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1vx6Fd-0000HQ-FG Subject: [Openvpn-devel] [PATCH v1] management: stop bytecount on client disconnection X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1858568851045568342?= X-GMAIL-MSGID: =?utf-8?q?1858568851045568342?= From: Ralf Lici When a management interface client requests periodic bytecount notifications, openvpn continues to emit them even after the client has disconnected. Additionally, upon reconnecting, the client starts receiving these notifications without having issued a new bytecount command. Stop the periodic bytecount operation when the management interface client disconnects, preventing unnecessary stats polling when using DCO and ensuring that clients only receive notifications they have explicitly requested. Change-Id: I6bdded6c70596b69428e6a00a405ac3cedc405fa Signed-off-by: Ralf Lici Acked-by: Arne Schwabe Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1533 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to release/2.6. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1533 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Arne Schwabe diff --git a/src/openvpn/manage.c b/src/openvpn/manage.c index 4ed0393..48b87e9 100644 --- a/src/openvpn/manage.c +++ b/src/openvpn/manage.c @@ -472,6 +472,13 @@ } static void +man_bytecount_stop(struct management *man) +{ + man->connection.bytecount_update_seconds = 0; + event_timeout_clear(&man->connection.bytecount_update_interval); +} + +static void man_bytecount(struct management *man, const int update_seconds) { if (update_seconds > 0) @@ -483,8 +490,7 @@ } else { - man->connection.bytecount_update_seconds = 0; - event_timeout_clear(&man->connection.bytecount_update_interval); + man_bytecount_stop(man); } /* The newly received bytecount interval may be sooner than the existing @@ -2011,6 +2017,7 @@ { if (socket_defined(man->connection.sd_cli)) { + man_bytecount_stop(man); #ifdef _WIN32 man_stop_ne32(man); #endif