From patchwork Wed Mar 4 14:40:21 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4796 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7001:a68f:b0:83c:d90d:321 with SMTP id wf15csp258490mab; Wed, 4 Mar 2026 06:40:47 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUkAwAum2nBSuW6J/PP670DRtJsPmpGcH4OOH4p3Q1B1dZ1gD+9UxVxDSsxyfxV2WdP1vIBG8pNCXQ=@openvpn.net X-Received: by 2002:a05:690c:86:b0:794:ee65:6ab8 with SMTP id 00721157ae682-798c6cf015fmr17652527b3.62.1772635247122; Wed, 04 Mar 2026 06:40:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1772635247; cv=none; d=google.com; s=arc-20240605; b=U1X7t7LPly8GP7Y/3QYTIrjj4gx69mKwy5mlPpT666Y5iKTYOCdbfr4ZFtC5ZCnGf9 2qr+7HJWK0hr5uuXYNj2G0dsRG3OFDMYBmpJRgUciAWn/PFrO/uNZoOS14fKuiIBLfQA ShjIXS03+4MFVCivhv6HH3ukgrg1sYb5yn8d1jVKnpvlHl2VPzb+yQ4W7Q9y7pFSkGke cLUFZO11surxomHuhLwcuNetKZq1adlP3HiBXMSG1crwvX5mP83j18sDMdX3WAFViR/t eJZqUmN+K1ImPPIIvHRGeoawJjJdIfkFAer92zn2HAVlXqGuVelI8co1mc/8P3nsqHPn +z3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=IX53jPBrAY/r6HVsXXvkl/A3zfMp0cmScgTeyfKMttk=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=DXsbJfifuCR9YJtFzwDY0+qWEtXlIEdJSjp4RS6sICCd1Vih4ZX19UA1+1u4azVEMy Pp/qUVborMs2nu1tFTRK8Ws/zVjdv30/Y9ehYl9GlNjkxCB34A4+Tn0srbolZ4OrOTDK qT0D+8/XRIXvM3JaBBw6CxJwp8MbUTkBsaZKkZnGcXDkqGLv4wHK+I09s5AACudTnQI4 kf0163XDVQET8y7WB2oZ9tQ3gO2vGdX9CbNjkzgrH5P/emuAZJVop+m0rHpgVNKEsfWy 5O4Ao370tVotXVlF6+eji6gSzpoSAOidrpIGmKmYllZFleO3w8dUV6zrsUuJjITJo1q/ ML9Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=e6EZbqGW; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=WjnvDTBt; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=exGFUImD; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 00721157ae682-798bf2d60ffsi39430237b3.236.2026.03.04.06.40.46 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Mar 2026 06:40:46 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=e6EZbqGW; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=WjnvDTBt; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=exGFUImD; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IX53jPBrAY/r6HVsXXvkl/A3zfMp0cmScgTeyfKMttk=; b=e6EZbqGWVxvUdqw01fcItjudU4 LhSt/20XvQbIhyjgJ0EE8wOnm77nC7ciAZNTa5Zh+9NqrIjK+iDOjpBxh4iestfAywPpqb9vG19Zx qTFqD5PzSnee3COOC9Iyjm8+ZWIKv5jAXq3nGNy5GK6N6yR4cC/xYjirST9XLf6hyw90=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vxnP1-0006hu-TC; Wed, 04 Mar 2026 14:40:44 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vxnOy-0006hV-B0 for openvpn-devel@lists.sourceforge.net; Wed, 04 Mar 2026 14:40:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MoSoIdV/8AVj/F7Q7BvQ9sQNPjX5uvBY3u9zA5scGXQ=; b=WjnvDTBt7eRAR0OyiIqQn0Q7Zv +Qkp3h/ANuH1cIA8US40jkVvTxYYv3bZJqnBITK5bOVVJ6RkQoKxP3TTD4/NjNLE0KrPjHFNdc8sQ 7BQvmwfSFcflN+ynn1WOvRF5XKbjyPbgbrI9xUq6ly9MtEBqRnlYS6v2gnkCeUcabTnA=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=MoSoIdV/8AVj/F7Q7BvQ9sQNPjX5uvBY3u9zA5scGXQ=; b=exGFUImDbI2rZ3LrOFSi5SMQPJ m9mz7Uig0eM750tfqkckSgMGYK8a8m9h5DuvLtBA7Ioec6awsIUL21B2yMcHkxy3928mp76oTeTjK HnIboNmIXIkAN9icSts3s4am2F6YBeJz2+bCbLxroJCY/KWBnP4otsWud5Z6eoMiIAjw=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vxnOy-0005Z3-18 for openvpn-devel@lists.sourceforge.net; Wed, 04 Mar 2026 14:40:40 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 624EeSn2002477 for ; Wed, 4 Mar 2026 15:40:28 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 624EeSRc002476 for openvpn-devel@lists.sourceforge.net; Wed, 4 Mar 2026 15:40:28 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Wed, 4 Mar 2026 15:40:21 +0100 Message-ID: <20260304144028.2459-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld It returns int, so use that. Avoids a sign-compare warning. Change-Id: Ie8135a31b1f8f70ce0ddf63d7653f3d84a9e983f Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe Acked-by: Gert Doering List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1858742776870721786?= X-GMAIL-MSGID: =?utf-8?q?1858742776870721786?= From: Frank Lichtenheld It returns int, so use that. Avoids a sign-compare warning. Change-Id: Ie8135a31b1f8f70ce0ddf63d7653f3d84a9e983f Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1493 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1493 This mail reflects revision 5 of this Change. Acked-by according to Gerrit (reflected above): Arne Schwabe Gert Doering diff --git a/src/openvpn/ssl_openssl.c b/src/openvpn/ssl_openssl.c index c61e4b2..d8c4587 100644 --- a/src/openvpn/ssl_openssl.c +++ b/src/openvpn/ssl_openssl.c @@ -1491,17 +1491,11 @@ return len; } -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wsign-compare" -#endif - /* sign arbitrary data */ static int rsa_priv_enc(int flen, const unsigned char *from, unsigned char *to, RSA *rsa, int padding) { - unsigned int len = RSA_size(rsa); - int ret = -1; + int len = RSA_size(rsa); if (padding != RSA_PKCS1_PADDING && padding != RSA_NO_PADDING) { @@ -1509,15 +1503,11 @@ return -1; } - ret = get_sig_from_man(from, flen, to, len, get_rsa_padding_name(padding)); + int ret = get_sig_from_man(from, flen, to, len, get_rsa_padding_name(padding)); return (ret == len) ? ret : -1; } -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic pop -#endif - static int tls_ctx_use_external_rsa_key(struct tls_root_ctx *ctx, EVP_PKEY *pkey) {