From patchwork Wed Mar 4 14:40:54 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4797 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7001:a68f:b0:83c:d90d:321 with SMTP id wf15csp258756mab; Wed, 4 Mar 2026 06:41:15 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWzbk4CmsxriCD3PNPEul2IXsY2FQyMKOXNx6Uwl8099JVo6nSwXAPXMoliOa4/uu+XaBOLCZoRdVc=@openvpn.net X-Received: by 2002:a05:690e:c4d:b0:64c:a1f8:ee27 with SMTP id 956f58d0204a3-64cfa008557mr1941383d50.72.1772635275261; Wed, 04 Mar 2026 06:41:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1772635275; cv=none; d=google.com; s=arc-20240605; b=c7zOWIjFSd92b/p5TwD5IvH7YoxDz+8kMu9NAoeAwDb0b3oxUJEmbbX6NMW5afkzT1 9bRiy/NNDMmfyt3KJKYhQXCA2thEdZt7mRVyQqJ4wcoj/U9u7Q26mzCbZsAirvx8VVoy nZ6UFyHExCk/ToQfHxx6llsngA/qXmDIErKYusE3pfUVuZ/a3bXXPY8lW+R3qm6/zXIc 0TSVRYqxPft7/6vdsUFx7drPmRUb2FruarYQO9HQGLc2gIeUhrOUUX0TfanbOBYOfy5K lRXSPGkQ/VpkVFQ5iF4i+d/DPnopvqUmWuI4U6NqKK32H8v7BrTV4DVYVzPjqgD6mwfQ jVfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=6AIbBY8Xfi5FFf5/buXe536EF1HdlT2m++AGALp5BKQ=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=HS6uXs9iVkTHtPw3tlD2EV3u0d9EV7gNkgfi+k0koMkteQur0RUInRlu8PK5FjCH5U 5mL1VAhKbB95yeAcgj6DIOZ2toXPWBQIfv/T3Y7/uq8jvmBKw3OttnQ5r8UnwA7dLKoj 3BEk54OcuMOmh+CDuPqa+nuM1dWTbKAMVOwPWnh3PANNYSowpnys04FMBg1PxIDQr6qU 0cS1e2Y4pB/3WoIpv2BTgDT61Q4wf/v50j0+cU/lx6tKH/INH3xfl4tv4VRvGy+GbHEq BALMvrifIlyRcQMyKrLI0E7E0hwOqHnLJTxukLjwdOTr2oUqmG76IzZPDQBp37czOGKN uIAA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=VPAzU0ub; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=amKD2ZD1; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=ZNLWoDLz; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 956f58d0204a3-64cb758048asi14563587d50.57.2026.03.04.06.41.15 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Mar 2026 06:41:15 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=VPAzU0ub; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=amKD2ZD1; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=ZNLWoDLz; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6AIbBY8Xfi5FFf5/buXe536EF1HdlT2m++AGALp5BKQ=; b=VPAzU0ubcy//aw9b35F0CkooB1 o8FZjbOcDvdGW4ogC6dcRhF6kqxW+PTriVR2JvTKN7VQECVuHQIrk82AddGfTyqvvQuPcc89me4Qw eoYuecNtnQGe9/TlxHzGcVIWIKSrH2nM010cGpmLJThT8773eFwjy3VNIKZfbYfDFfDc=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vxnPV-0007Z5-4y; Wed, 04 Mar 2026 14:41:13 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vxnPU-0007Yy-9C for openvpn-devel@lists.sourceforge.net; Wed, 04 Mar 2026 14:41:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kTkc8eH226GcEs32ciz2tzpcVR39M7u8Qo2KbphCNpU=; b=amKD2ZD14ysKWs1tlY7Jh9nGAu 9ub0JTvfp99wt9M8f06gUffQnbNXRywnQ/2vLrwHtLjZouMcl4BSTvD8EQ2D1uAlLAOidgIS1OxO4 N0L5fsxjUUjCTLROhPg466S6xsrjxy36aK30n/R8S6NIpFKz5ktRz5pHyW2nrS+3KIg0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=kTkc8eH226GcEs32ciz2tzpcVR39M7u8Qo2KbphCNpU=; b=ZNLWoDLzqkwHF1CkXrBztj4+OD 6CARJULvQ6wEfdk9PUX2g/cALnv7kOISpK0unJLnvdx/SYXNnsOkdeDC7sXKk2pdcNkKAtf5kiZsu JmF7HKA7pqZhtv2zGleUbXb6dYb5yaMOsDLaQr4zfEA1nZSCY403+zPVSormGMiBdKAE=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vxnPT-0005b0-HW for openvpn-devel@lists.sourceforge.net; Wed, 04 Mar 2026 14:41:12 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 624Ef000002533 for ; Wed, 4 Mar 2026 15:41:00 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 624Ef0qC002532 for openvpn-devel@lists.sourceforge.net; Wed, 4 Mar 2026 15:41:00 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Wed, 4 Mar 2026 15:40:54 +0100 Message-ID: <20260304144059.2518-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld len is already int, no need to throw another type into the mix. Change-Id: Ida8e587a095bdfb821ee0a4783633f026d310476 Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe Gerrit URL: https://gerrit.openvpn.net/c [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1vxnPT-0005b0-HW Subject: [Openvpn-devel] [PATCH v5] argv: Fix one type to avoid sign-compare warning X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1858742805932623925?= X-GMAIL-MSGID: =?utf-8?q?1858742805932623925?= From: Frank Lichtenheld len is already int, no need to throw another type into the mix. Change-Id: Ida8e587a095bdfb821ee0a4783633f026d310476 Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1494 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1494 This mail reflects revision 5 of this Change. Acked-by according to Gerrit (reflected above): Arne Schwabe diff --git a/src/openvpn/argv.c b/src/openvpn/argv.c index b5d9603..6a5d92e 100644 --- a/src/openvpn/argv.c +++ b/src/openvpn/argv.c @@ -263,11 +263,6 @@ gc_free(&gc); } -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wsign-compare" -#endif - /** * Prepares argv format string for further processing * @@ -389,7 +384,7 @@ * Do the actual vsnprintf() operation, which expands the format * string with the provided arguments. */ - size_t size = len + 1; + int size = len + 1; char *buf = gc_malloc(size, false, &argres->gc); len = vsnprintf(buf, size, f, arglist); if (len < 0 || len >= size) @@ -423,10 +418,6 @@ return res; } -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic pop -#endif - /** * printf() variant which populates a struct argv. It processes the * format string with the provided arguments. For each space separator found