From patchwork Fri Mar 13 10:52:15 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Lichtenheld X-Patchwork-Id: 4824 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:2755:b0:83c:d90d:321 with SMTP id j21csp1136505maq; Fri, 13 Mar 2026 03:52:37 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUmwN/wX1onmYSejPKJpln4jcRVxT+xtZfAOWroPW85OlMekMqRSdsJIoDKJh4NUrxkMywBen2IyH8=@openvpn.net X-Received: by 2002:a05:600d:8489:20b0:485:3812:36dc with SMTP id 5b1f17b1804b1-485566d9068mr31866845e9.9.1773399157206; Fri, 13 Mar 2026 03:52:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1773399157; cv=none; d=google.com; s=arc-20240605; b=ljvrNgF01VzZ0z1r/Kg9aVCFx4oHy8nq4Ukt/fjRXOr+vVr1rlcb9w5jiADdRvhadM eA2C4WS1iUqm3CFM3xabu0tAv9kJQWfw06orv2UQYb8da2AaMbk6pSM9Ll0xVthw0VpC 7xOXF6BLaUtvmckQKkU5x9LZGyfU3PhCBU/RRYkKEcOYRN4LnfPEhz2aAewrmfWguoPW mu/CKbTMQHPR3Ao1cznzEPgKpYmT6QKnJuR5kURwrDQVUYIwO/oo6GQUzBxsfK0/1QvZ 22JqptQ5WIeM31p+JCAS99XCQHsXi0oVN4F/qlInzYOsUvVx0V/YlHh6IkUneWA4YnPl J7Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:cc:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature:dkim-signature; bh=y3pX9p6GnLg1TPu+FXo0V1f+9tnUZgiWvpbT9o3MA3Y=; fh=CfxSpwd5kfiMJoL3kcov7PTxVKT7pGe/79idnx9XlBs=; b=WgoKwhT0uqt/rycRlBW85QZfKOrgzkutDwkSKs0JYcEaRtOn7VJ8kJ/II0qVho8ceb Tckb4E37TJW0LhqytYpVHKBeKmGkqJC2KteXP10siTJGiyI+vTHrx0kVTH720bQcEWsv PG0ZES2BP3eRAV2Ao0cPO7xgsMgkSiXKkiir2u+SvLWvygzJ+fdJXycKd2ahgcZuALRT DgYLg91j7hk14n4quUxrDtMFuZ3rpUskCx9I/rw308WXroyw8ipBVT8VWTfdB4/m4z+H BND59RLl+WIAqpjDZ0fibwKfEimY/QdzG48sFSlJTyM9ubgc0wRo2Imh02Cc9FZ7GgcS zq/g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=ldZsOj87; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="K4Vn7/JD"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=bC6gmnQA; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=ZRX5rgyC; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id ffacd0b85a97d-439fe27132fsi11687118f8f.547.2026.03.13.03.52.37 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Mar 2026 03:52:37 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=ldZsOj87; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="K4Vn7/JD"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=bC6gmnQA; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=ZRX5rgyC; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=y3pX9p6GnLg1TPu+FXo0V1f+9tnUZgiWvpbT9o3MA3Y=; b=ldZsOj87k2C3JF6Rz/KWE+QYl8 902rMr2laHlOeEqUp3CkRtlcu1bQNLWKUgOWMBuEi9N9tO0QQGAI39JCJztedmQFlZ3mmobByxvgA OuuzXbo69eY2WsTpmsyNMriERZcRrIZJbs9ARAziET26FHEA7CN1T8V6EG4lbxbrZy3c=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1w1089-00020V-U1; Fri, 13 Mar 2026 10:52:33 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1w1088-00020N-82 for openvpn-devel@lists.sourceforge.net; Fri, 13 Mar 2026 10:52:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=pRIet/b8e2grO6J54HEkuAddVuTK7F5wP0pBeZEYdC0=; b=K4Vn7/JDPhT7Sc7K9qvvOMu1vF ju9F0QOmk9FaAUdvQ7dgICFVp1OdtvTH/vVOdJd2JoXmymqCrg74eVdh5mZOURu4vHommk3AuiY0M cHAQ+t/RiZ24roBkSdiw4NWNrvpO9SeEzma0R0kvrmrQlP4nBlVDq/NGorun4wd9YzhI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=pRIet/b8e2grO6J54HEkuAddVuTK7F5wP0pBeZEYdC0=; b=bC6gmnQA4eNyXlsEhqKDAfy50a M4fAanxk2ljrnw+OrIs/HEBxZBCkQ76PhS8Rdo95ofuxOL3TEj1Yh0qIpayWn9VQNEdZP7qR0OxcA 7trar4TVTD4K/DEPC0wf9HRubM1UBgHo0RjNTXELJ/HgWLcEmKbFDK2nb523nfO/fHUY=; Received: from mout-p-201.mailbox.org ([80.241.56.171]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1w1086-0004L3-VQ for openvpn-devel@lists.sourceforge.net; Fri, 13 Mar 2026 10:52:32 +0000 Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4fXLsY3PlPz9tf6; Fri, 13 Mar 2026 11:52:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lichtenheld.com; s=MBO0001; t=1773399137; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pRIet/b8e2grO6J54HEkuAddVuTK7F5wP0pBeZEYdC0=; b=ZRX5rgyC4OOrOOmH0Sx1tHZTt7bXFYTxyEvkeW8dyXRv8PgOtKmzUy0w/l586MMHdsst1x c3U2HslFAEg0Ra5M/dMOJCsGcCTdPui366qcUJS/9eanSb1ycBW5HrYo6Atx+uO0xo78BR eg8rgWwZtYU5c8ZFwCCPYxnVUOFXarM04s7t1RPJKxOl4xFcG07BJy5a8v/kMJnj//BtUk hyRSw4UYlzPWAxkp2T5qHzJzZOHsD6H8KO87jxNUVyClJ3lJf4SnXgPr/ecJ7ARofgLsK0 cmvLZExEg30WF7BO7WFEc2vie3uCI4Qp8fw3btRu30DmeN7jEeaW6RBG4+K/Hg== From: Frank Lichtenheld To: openvpn-devel@lists.sourceforge.net Date: Fri, 13 Mar 2026 11:52:15 +0100 Message-ID: <20260313105215.17284-1-frank@lichtenheld.com> In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Arne Schwabe Change-Id: I7843ff1422cc3b46870749b2daab1698646d43eb Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld Gerrit URL: https://gerrit.openvpn.net/c [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-Headers-End: 1w1086-0004L3-VQ Subject: [Openvpn-devel] [PATCH v1] [AWS-LC] Add missing return and cast in ssl_tls1_PRF X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arne Schwabe Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1859543794335648508?= X-GMAIL-MSGID: =?utf-8?q?1859543794335648508?= From: Arne Schwabe Change-Id: I7843ff1422cc3b46870749b2daab1698646d43eb Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1567 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1567 This mail reflects revision 1 of this Change. Signed-off-by line for the author was added as per our policy. Acked-by according to Gerrit (reflected above): Frank Lichtenheld diff --git a/src/openvpn/crypto_openssl.c b/src/openvpn/crypto_openssl.c index de3878d..b6e2106 100644 --- a/src/openvpn/crypto_openssl.c +++ b/src/openvpn/crypto_openssl.c @@ -1412,7 +1412,8 @@ ssl_tls1_PRF(const uint8_t *label, size_t label_len, const uint8_t *sec, size_t slen, uint8_t *out1, size_t olen) { - CRYPTO_tls1_prf(EVP_md5_sha1(), out1, olen, sec, slen, label, label_len, NULL, 0, NULL, 0); + return CRYPTO_tls1_prf(EVP_md5_sha1(), out1, olen, sec, slen, + (const char *)label, label_len, NULL, 0, NULL, 0); } #elif !defined(LIBRESSL_VERSION_NUMBER) && !defined(ENABLE_CRYPTO_WOLFSSL) #if defined(__GNUC__) || defined(__clang__)