diff mbox series

[Openvpn-devel,v4] GHA: Install aws-lc under /opt/aws-lc

Message ID 20260313153007.31810-1-gert@greenie.muc.de
State New
Headers
Series [Openvpn-devel,v4] GHA: Install aws-lc under /opt/aws-lc |

Commit Message

Gert Doering March 13, 2026, 3:30 p.m. UTC 
  From: Arne Schwabe <arne@rfc2549.org>

The previous installation inside the OpenVPN workspace directory
caused the AWS-LC installation to be deleted. And that caused to OpenSSL
to be used instead of AWS-LC during the build

This also removes the --enable-werror flag from AWS-LC because it
currently not even close to build without warnings.

Change-Id: I090f5b201d67f51d2e42df1914a8466bcfcb6bf8
Signed-off-by: Arne Schwabe <arne-openvpn@rfc2549.org>
Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1565
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1565
This mail reflects revision 4 of this Change.

Signed-off-by line for the author was added as per our policy.

Acked-by according to Gerrit (reflected above):
Frank Lichtenheld <frank@lichtenheld.com>

Comments

Gert Doering March 13, 2026, 5:56 p.m. UTC | #1 
This is a build fix, so no actual code change - just ensure that our
GH actions actually *do* build with AWS-LC (... and subsequently
discover the error fixed by the just-applied commit)

Mildly tested by pushing to my GH repo.

Your patch has been applied to the master and release/2.7 branch.

commit 30c1c8cd61db9eb35f6c263a0ca3ec0714c88eb4 (master)
commit 7158e76feb980443d97ebe321b2a7a54659b7ab4 (release/2.7)
Author: Arne Schwabe
Date:   Fri Mar 13 16:30:01 2026 +0100

     GHA: Install aws-lc under /opt/aws-lc

     Signed-off-by: Arne Schwabe <arne-openvpn@rfc2549.org>
     Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1565
     Message-Id: <20260313153007.31810-1-gert@greenie.muc.de>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36106.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering
diff mbox series

Patch

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index b213192..2a2616b 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -454,7 +454,7 @@ 
       CC: ${{matrix.cc}}
       CXX: ${{matrix.cxx}}
       UBSAN_OPTIONS: print_stacktrace=1
-      AWS_LC_INSTALL: ${{ github.workspace }}/aws-lc/aws-lc-install
+      AWS_LC_INSTALL: /opt/aws-lc
 
     steps:
       - name: Install dependencies
@@ -465,7 +465,7 @@ 
           path: aws-lc
           # versioning=semver-coerced
           repository: aws/aws-lc
-          ref: v1.67.0
+          ref: v1.70.0
       - uses: lukka/get-cmake@f176ccd3f28bda569c43aae4894f06b2435a3375 # v4.2.3
       - name: "AWS-LC: build"
         run: |
@@ -480,10 +480,10 @@ 
         run: autoreconf -fvi
       - name: configure with AWS-LC
         run: |
-          OPENSSL_CFLAGS="-I/${{ env.AWS_LC_INSTALL }}/include" \
-          OPENSSL_LIBS="-L/${{ env.AWS_LC_INSTALL }}/lib -lssl -lcrypto" \
-          LDFLAGS="-Wl,-rpath=/${{ env.AWS_LC_INSTALL }}/lib" \
-          ./configure --with-crypto-library=openssl --enable-werror
+          OPENSSL_CFLAGS="-I${{ env.AWS_LC_INSTALL }}/include" \
+          OPENSSL_LIBS="-L${{ env.AWS_LC_INSTALL }}/lib -lssl -lcrypto" \
+          LDFLAGS="-Wl,-rpath=${{ env.AWS_LC_INSTALL }}/lib" \
+          ./configure --with-crypto-library=openssl
       - name: make all
         run: make -j3
       - name: configure checks