From patchwork Fri Mar 13 15:30:27 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4826 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:5626:b0:83e:8477:d3bc with SMTP id x6csp1322706mat; Fri, 13 Mar 2026 08:30:59 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWUzifhEMOUo9G2jGaLCv2BoE4FofLKQLpmd4vxHIsr8H4KxwmTLJazIxjlHsaRCWpZTWtmamecf0Q=@openvpn.net X-Received: by 2002:a05:6808:1590:b0:466:fd60:239a with SMTP id 5614622812f47-467574293damr1863292b6e.46.1773415859255; Fri, 13 Mar 2026 08:30:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1773415859; cv=none; d=google.com; s=arc-20240605; b=PPEYF3jsvC9LL53OzCHfPvQbJdJ8T7m28ydjTBhLsi3zhAWwgt1nF3wnLh2D639WbI IfgQMkieZOFUcBtaOF572Jj82Afnlhi3Rj6mQxv22JW4t8VbdjYq1m/4qxkzjHn1oUz3 bcLsr9Fr8d/CoTHgRoNhd2Y3havlQmbKaea70GYnpfR4iIZM6yQdqMFwBsMGOCYdFWXS OBgeu/yfMp0DJjS6ywJR2SPruX3BanB8dZ1yYeLVSLUL4A+Zf7MKtJN4yENV2uD9v2sj bkqLxBkvzoCwQ1ulOTS9b7eHl0B8z0tR+xkQHIwBctYlbt+A3GHURwVJPCZcGAVtwuIg sJDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=8tuFnYS0+Em6VnbaTlpmhcKSBFgFvUx9sGxCp6jTFtU=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=TJU/VdC+qPggw//uglc5iv2EpS5g9Jgg9R6ms0nSXV5kP8aGpH9TdTlpQ7McUswoGW OryVhylakvRkOr22qGRAaKqN78BbsyPsgFBf4IVbKvcJxia8UyZaP0bZBlF5IT+m8SJJ ItRtdRMBMJQKIciOLLg+I+MPIP0V6tMzC4lXQmQAPAEVgWiqRDZPDtifcA7mIRvYiHM0 Gntw5fJy8WXecR4WxrEGQmUZFNJZf/Tds2JRlICBFmn9xbg9fneLG7ANzAaFMALKcR1k j6dwOaEPzzfMJKcpBB3j9PKIX9+6mvffuzYgPxr8u9DfpTxtfyqIWei0moR778BVaBPl wbWg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=khOgq4t5; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=IhEu9GWn; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=D7jzdkNH; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 5614622812f47-467343735b0si4411751b6e.85.2026.03.13.08.30.58 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Mar 2026 08:30:59 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=khOgq4t5; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=IhEu9GWn; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=D7jzdkNH; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8tuFnYS0+Em6VnbaTlpmhcKSBFgFvUx9sGxCp6jTFtU=; b=khOgq4t5Ome5eEpnxG5XsgXg+r RnK+RDBjY+5VYcTueBaDrsTCk7ES2jj1h4qOuW2KU2L4pXHRBmEaUE/7l9hT/aqaWM5kSv3s+ms0w tFTYzBzcmJ62IDdPsWvCuzw8e+wZLdYbh+KeZDR+77aWQT740ErGc+8MUR8VKvkvly9c=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1w14TQ-0006Je-Qg; Fri, 13 Mar 2026 15:30:48 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1w14TP-0006JV-33 for openvpn-devel@lists.sourceforge.net; Fri, 13 Mar 2026 15:30:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XnIF2IDXP7lrRUgrVVj80fTTRW8ltmFj17KJqYCGcyg=; b=IhEu9GWnJvTArRxxdSnHLEJNo0 iIawj3+KoSz5vItnEzF2OcHugmvPTL+gylzNtJ+iVRroWYWFiyviMCYqNeskYZZ0qBE4mjYMATYBQ dHtxcNmt1gNBV/vRYeEzboeP5ZtaiRMsqkQoy7XUt3V4J09zkzkXcLf1biW6LUif6qWQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=XnIF2IDXP7lrRUgrVVj80fTTRW8ltmFj17KJqYCGcyg=; b=D7jzdkNHgx2cvXK7jwEHihWsmE yI27WarsrFqhkgmv0k5KMqjGm5zgblPCcO3K9uxG6w5kfVWHBWMY8MPvWofyp5cYLrdHnNVkSU+32 4cPI/ipLgOUlWThF/WNiS9YF8KyyW8QRERA1JdMe1b9A1PbKEAOSMZQKJ6Ou7rFBy3P4=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1w14TO-0004Lo-2P for openvpn-devel@lists.sourceforge.net; Fri, 13 Mar 2026 15:30:46 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 62DFUYlH031899 for ; Fri, 13 Mar 2026 16:30:34 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 62DFUY87031898 for openvpn-devel@lists.sourceforge.net; Fri, 13 Mar 2026 16:30:34 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Fri, 13 Mar 2026 16:30:27 +0100 Message-ID: <20260313153034.31872-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Arne Schwabe Change-Id: I7843ff1422cc3b46870749b2daab1698646d43eb Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld Gerrit URL: https://gerrit.openvpn.net/c [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1w14TO-0004Lo-2P Subject: [Openvpn-devel] [PATCH v3] AWS-LC: Add missing return and cast in ssl_tls1_PRF X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1859561308004799451?= X-GMAIL-MSGID: =?utf-8?q?1859561308004799451?= From: Arne Schwabe Change-Id: I7843ff1422cc3b46870749b2daab1698646d43eb Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1567 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1567 This mail reflects revision 3 of this Change. Signed-off-by line for the author was added as per our policy. Acked-by according to Gerrit (reflected above): Frank Lichtenheld diff --git a/src/openvpn/crypto_openssl.c b/src/openvpn/crypto_openssl.c index de3878d..b6e2106 100644 --- a/src/openvpn/crypto_openssl.c +++ b/src/openvpn/crypto_openssl.c @@ -1412,7 +1412,8 @@ ssl_tls1_PRF(const uint8_t *label, size_t label_len, const uint8_t *sec, size_t slen, uint8_t *out1, size_t olen) { - CRYPTO_tls1_prf(EVP_md5_sha1(), out1, olen, sec, slen, label, label_len, NULL, 0, NULL, 0); + return CRYPTO_tls1_prf(EVP_md5_sha1(), out1, olen, sec, slen, + (const char *)label, label_len, NULL, 0, NULL, 0); } #elif !defined(LIBRESSL_VERSION_NUMBER) && !defined(ENABLE_CRYPTO_WOLFSSL) #if defined(__GNUC__) || defined(__clang__)