From patchwork Sun Mar 15 23:05:30 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: luca.boccassi@gmail.com X-Patchwork-Id: 4835 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:2755:b0:83c:d90d:321 with SMTP id j21csp2536740maq; Sun, 15 Mar 2026 16:06:50 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVx5OYKftrjqcWqNMK9uXK3R77m3fpkaI+TTpu2G/VTR0biT41QaWQBjFcRtshJzotFVIrCpc7Q1Rg=@openvpn.net X-Received: by 2002:a05:6808:1a18:b0:467:13b5:8af2 with SMTP id 5614622812f47-4675701cd34mr6668128b6e.5.1773616009859; Sun, 15 Mar 2026 16:06:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1773616009; cv=none; d=google.com; s=arc-20240605; b=XnfV+dyp9n3sInsqReJNmkw9Er19Lk7mF7+LlFjpaQzZvpiSDPdFQPmwKhRrY87d9y 1gukKDRfC8Xv1lAaQtuZ9H9QKwSY1pCRshCSJ7sXxhDzRy5bt9oka96BUkAIX3tzYUze RRoJ7NXyykWr+IFAaXtZ8ZrH74f+73qnR1nZUfFd/iBBB857QmmqwXuENEuWsSPFA5+a MnjhbX3zzRsqSYWYc6RGYjsv8qU9gwwvX9VMRr5iwMYOU0rlmSts7CYRq/a6V3gkrahI Jc3lk+e0dbuNTYHig4re6MNGjBVa87O8oWvcm2pOLj8zzNsBbuaOiIINAWuOcFkvFiXP NXVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:cc:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature:dkim-signature; bh=uELeknqXscD/37CEOqUxXXycZpV2HbFVT7ec2mu72T0=; fh=FRWMOQmE4vArX8xPll5WCJJjcBedLRfud2/cHUpioeU=; b=LQwBQ9F+cgRT0qNE/ZV8NiYh8SUTCnVKWEZIHW3639LVUY3H9HS18ZcyzOxiQ01oJh xpEoEIsHuK6tm02RqUBoH6ilnIq+EICL/Y/hUTHQuhqhiP9VcmgXm6IYPzI0b45dHl1C 59ZYz4eScYwOhZWp+z7wPMBC6TBZOGFugCSV76B7ChQfECewKyRdSv/nCgWIsyee9RrP B2o2LXXu9coKS2ZCb90PderqB+WDmtW2DXqriCtfKyB6eUhxxTcb0ocBrzTR/qMeiLjK wkqmDJIIAVD/jcCrg3Jz4H8YRzqnPb8ZHBnlL19Afbbpmw12WZxhTF0Gzt35mRrNV2Xi t93A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=STlTgbpU; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=ToVS8+eM; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=mnu1yGjg; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=VpFKm07U; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=neutral header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 5614622812f47-467340b8a2csi7443083b6e.17.2026.03.15.16.06.49 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 15 Mar 2026 16:06:49 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=STlTgbpU; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=ToVS8+eM; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=mnu1yGjg; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=VpFKm07U; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=neutral header.i=@openvpn.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uELeknqXscD/37CEOqUxXXycZpV2HbFVT7ec2mu72T0=; b=STlTgbpU6HBwfK9BeEGvnifpui ierAwR8CAHpnRcFdZ0CMdzUdXinr0aYhDSiYr+pT1XQWgbOLLT8BLnbxPuhQixi6QFlf193y34TaG MUD7fAvuIek/8zohRYKCw+Uwy8NbtfwOEGntg1xVpk/5QGQEKuSBO86tGtIFhRY0n6Yk=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1w1uXn-0006Cn-Mm; Sun, 15 Mar 2026 23:06:47 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1w1uXf-0006CX-PA for openvpn-devel@lists.sourceforge.net; Sun, 15 Mar 2026 23:06:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=HN0e3fcwO+cv4md7vbRNmzE8yDUZpn47aTlmn3j09c4=; b=ToVS8+eM/d1rCQt8N74H+Q5C3U 8/4bWSBDSVlddeAV127OGnZfcaZXunG9d5b5ZaEiLxbceDN4fKGQcswaaBywkCMbIpdNDF5pmTlhS J0wHBbvit6ADM54GLXLmQC6wEdI17o+K/jufpopZJXUg995TH8BMvuH5ZSLRxCAU7cQY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=HN0e3fcwO+cv4md7vbRNmzE8yDUZpn47aTlmn3j09c4=; b=mnu1yGjgxsZ+dkyywaPSu5L8Gi gT4h79FQaJKCdwGZwnsTgxv7GOvDJ6aDpZyQspLI+ct1us6A9X3DdTqVc+zneDScBynLDdTBeZfeZ rowql6Z9ZsL9lMwZYkB2VDeZReuWmPFWhRcQh3MELXwP9hPG43i/xO+Yqs65Jlr4uPqA=; Received: from mail-wr1-f44.google.com ([209.85.221.44]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1w1uXf-00033L-Ft for openvpn-devel@lists.sourceforge.net; Sun, 15 Mar 2026 23:06:39 +0000 Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-439cd6b09f8so3143572f8f.3 for ; Sun, 15 Mar 2026 16:06:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773615988; x=1774220788; darn=lists.sourceforge.net; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HN0e3fcwO+cv4md7vbRNmzE8yDUZpn47aTlmn3j09c4=; b=VpFKm07U4WpeBCG+yRF8fMi02fUaL9abe3+Hn9C8jOqse+6t72DnEBXFNyALWihqjx e/A2HifQtFw7hcmI3fZRXkqJ/l+EP29xwIL5LnVsUgPtlTH2GqyCsTkMq+y0UvzGVRjg 7uzOzR3w6qKxZ4TUiK3PI7bG5mHeNSvE1Z5O6/xig4Ue4FCRErr5Qsq5fSmjWDT+7LqU Ok28rgqQaewuueJ2mEAvzas9VU1AwwQVY6awkQ9GU4HHWx5v4Zs8cC17Zdyj7pmaYgXF 94UZjfhgKOhE5sHM07atlVWdOqME8aECun/KgytWbj5I9BWHJRoVd13YVAC8d/J2FNV9 OLwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773615988; x=1774220788; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HN0e3fcwO+cv4md7vbRNmzE8yDUZpn47aTlmn3j09c4=; b=cEPUqfKRp9NoOW3rswX5fbsRvP74Hi3HAQF3RWSaqptih1Ab4spuo6Cjm2OON6ZCCT oJjdOXPOZa44+zjnTRNQ6pU1cc9a24ekLHRH8LM6fJoCiju5bOlSD0eUv1Iejaxeve2s Yq0+Q0sMq9odjuehulxBkaTtcKMViJEU+HzFVgC6vXAKYPXR1kR+97mXmmxZqxJ1/5sm XMSN3qTofwK/fnbH/1ZMyHNcOBEqwQmoSrnpfrSSaVz6qwkeNQmSLaRTD0kOcGmrIP6Y DwPksZTYmsRXKEazf60gVnJpjKC2Utx2yMz0At/095SYRM4/xIsUylNY8xyR+3axlcrt ++ew== X-Gm-Message-State: AOJu0YzGP1Fios6Ah0C1rdXBNKWhawVoKeB7tcSmnmnRYwxjxpLYpGHI pu580jc9oynu7/2YjXOII+uSq/0XEQPhlQ0EI63TRW8a1KFs5F+SVbBfXpjTWA== X-Gm-Gg: ATEYQzw/lYWmOsIv8Njf6Rud5eydJAPEsYx17bzIC8dkh3Pz3Xigco0LG4PWiw4U3Oh vGa5PtcrngYTu4paJELr1uAubc3h2lOqMyTv40pmO11BOG0t1B55XE/M6msBjUh26ji5c4mtq/m 1I2zQ+jvpYmbHl9Vzj3sfiGVPQ+rmGzN0RviNm+jVGJ6qGWep6aY2sroudBUKvwX1JAXAvanB9h wAvAJtwykOxPF87LN9oK7SeYAnr82A49TCWEWp0YnfUliFgUNjcJmXKNclR49ct289ZNpaFTnwa EiOobbTPbn5G93hBM+OKn3JdZJsjsTsG7ou8AAgYI+UVbpL4dyVu0xm3/K4ei0/xg4y0SDqnTpA kUtN+Y3Tu8VZjCKLRB2EPr/IJY6lH11YRjig1Itlv7Xsr+NYX1towGSfj3a3jd8ERs33oRP6yy2 qjdSp6YoloIDCEw7tjG51RhnUQ5FMk X-Received: by 2002:adf:e54e:0:b0:43b:4136:1e76 with SMTP id ffacd0b85a97d-43b413628b4mr3939344f8f.29.1773615987617; Sun, 15 Mar 2026 16:06:27 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:21cd:def0:a01d:d2aa]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-439fe19b936sm40222746f8f.5.2026.03.15.16.06.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Mar 2026 16:06:27 -0700 (PDT) From: luca.boccassi@gmail.com To: openvpn-devel@lists.sourceforge.net Date: Sun, 15 Mar 2026 23:05:30 +0000 Message-ID: <20260315230620.1594780-3-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260315230620.1594780-1-luca.boccassi@gmail.com> References: <20260315184337.1541272-1-luca.boccassi@gmail.com> <20260315230620.1594780-1-luca.boccassi@gmail.com> MIME-Version: 1.0 X-Spam-Score: 0.8 (/) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Luca Boccassi When authenticating via a JWT token 128 bytes are not enough, which breaks the auth process. Currently the hardcoded password limit is increased to 4k when PKCS11 is enabled, for similar reasons. Remo [...] Content analysis details: (0.8 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 1.0 FORGED_GMAIL_RCVD 'From' gmail.com does not match 'Received' headers 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [luca.boccassi(at)gmail.com] 0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.44 listed in wl.mailspike.net] X-Headers-End: 1w1uXf-00033L-Ft Subject: [Openvpn-devel] [PATCH v2 2/3] Unconditionally set USER_PASS_LEN to 4096 X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Luca Boccassi Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1859754648723151930?= X-GMAIL-MSGID: =?utf-8?q?1859771181456440379?= From: Luca Boccassi When authenticating via a JWT token 128 bytes are not enough, which breaks the auth process. Currently the hardcoded password limit is increased to 4k when PKCS11 is enabled, for similar reasons. Remove the compile time conditional and always set the limit to 4k. Signed-off-by: Luca Boccassi --- src/openvpn/misc.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/openvpn/misc.h b/src/openvpn/misc.h index e9cfadba..2c495d41 100644 --- a/src/openvpn/misc.h +++ b/src/openvpn/misc.h @@ -58,11 +58,7 @@ struct user_pass bool protected; /* max length of username/password */ -#ifdef ENABLE_PKCS11 #define USER_PASS_LEN 4096 -#else -#define USER_PASS_LEN 128 -#endif /* Note that username and password are expected to be null-terminated */ char username[USER_PASS_LEN]; char password[USER_PASS_LEN];