| Message ID | 20260326062016.3856597-1-haixiao.yan.cn@windriver.com |
|---|---|
| State | New |
| Headers | show |
| Series | [Openvpn-devel] tests: skip test execution when cross-compiling | expand |
On Thu, Mar 26, 2026 at 02:20:16PM +0800, haixiao.yan.cn--- via Openvpn-devel wrote: > From: Haixiao Yan <haixiao.yan.cn@windriver.com> > > The auth-pam unit test Makefile.am unconditionally assigns the TESTS variable, > causing test execution to fail during cross-compilation because the target > binaries are not executable on the build host. > > Signed-off-by: Haixiao Yan <haixiao.yan.cn@windriver.com> > --- > tests/unit_tests/plugins/auth-pam/Makefile.am | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/unit_tests/plugins/auth-pam/Makefile.am b/tests/unit_tests/plugins/auth-pam/Makefile.am > index ba32013ac920..7da299ccde92 100644 > --- a/tests/unit_tests/plugins/auth-pam/Makefile.am > +++ b/tests/unit_tests/plugins/auth-pam/Makefile.am > @@ -4,8 +4,10 @@ AM_TESTSUITE_SUMMARY_HEADER = ' for $(PACKAGE_STRING) auth_pam Plugin Unit-Tests > > if ENABLE_PLUGIN_AUTH_PAM > check_PROGRAMS = auth_pam_testdriver > +if !CROSS_COMPILING > TESTS = $(check_PROGRAMS) > endif > +endif Makes sense and is consistent with existing Makefile.am files in example_test and openvpn. Acked-By: Frank Lichtenheld <frank@lichtenheld.com> Regards,
Thanks for finding that bug, and letting us know.
Your patch has been applied to the master and release/2.7 branch (bugfix).
commit 690aace41a68292412da3f313389e79d4a12bfbc (master)
commit 66989b384dc0056e89942bfa0a1546a2644f7831 (release/2.7)
Author: Haixiao Yan
Date: Thu Mar 26 14:20:16 2026 +0800
tests: skip test execution when cross-compiling
Signed-off-by: Haixiao Yan <haixiao.yan.cn@windriver.com>
Acked-By: Frank Lichtenheld <frank@lichtenheld.com>
Message-Id: <20260326062016.3856597-1-haixiao.yan.cn@windriver.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36288.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
--
kind regards,
Gert Doering
diff --git a/tests/unit_tests/plugins/auth-pam/Makefile.am b/tests/unit_tests/plugins/auth-pam/Makefile.am index ba32013ac920..7da299ccde92 100644 --- a/tests/unit_tests/plugins/auth-pam/Makefile.am +++ b/tests/unit_tests/plugins/auth-pam/Makefile.am @@ -4,8 +4,10 @@ AM_TESTSUITE_SUMMARY_HEADER = ' for $(PACKAGE_STRING) auth_pam Plugin Unit-Tests if ENABLE_PLUGIN_AUTH_PAM check_PROGRAMS = auth_pam_testdriver +if !CROSS_COMPILING TESTS = $(check_PROGRAMS) endif +endif auth_pam_testdriver_SOURCES = test_search_and_replace.c $(top_srcdir)/src/plugins/auth-pam/utils.h $(top_srcdir)/src/plugins/auth-pam/utils.c auth_pam_testdriver_CFLAGS = @TEST_CFLAGS@ -I$(top_srcdir)/src/plugins/auth-pam