From patchwork Tue Apr 7 09:50:38 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4879 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:d1c6:b0:83c:d90d:321 with SMTP id ly6csp1904607mab; Tue, 7 Apr 2026 02:51:15 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVcWzZqPK9hxegtVmiy53LUbXUEgFHC+5ELdWfH0/GWx3AiRnWItbx6HHf54boBfsn9lMiQAicwq0k=@openvpn.net X-Received: by 2002:a05:6830:608b:b0:7d7:d097:96e2 with SMTP id 46e09a7af769-7dbb732ffd4mr12395611a34.7.1775555475762; Tue, 07 Apr 2026 02:51:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1775555475; cv=none; d=google.com; s=arc-20240605; b=ABivpuiTmusyHmzD1Vp2C8Wo7OIq7cynkK8U9MzpwalYXeBXeRxzQEIzTDXMpK4mWF 9UOYeA+9Oo17YMqkjUzRl7n8bwwcWY3RXbulrU87giymhHGIi+C/dEyQKk4pzqCU4guw H9uG5XP3c0BWdOfm1BbF1ehkOoO6fFJVwXnBsE24aAuZrlt2HOziHOnUQjYlWJj40VEC /hbcB7XvfwQkKxgnJHBKM3MbsBCzSu6HSYQxtFg+wMxSePb0quEe/bGMIIhM2sRfEAQy bOlK/8Ol6EBaUv8QQf/td7XgMsPijL2avSA5Dlv+8YmfJSzfJFoWvapTorFFwKrjDGB8 t9aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=ypnz6sRA7vjwp3eJwZY9O9fyTItgEJLOtYDrjztNljU=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=EbhSUBWIxHOgR52ykNl2T+0UVdLPOrS4WBmVZiePGLCSTTvZZYBgAwzwWBuNE7ABY1 DIhSu0cQAUpMtj1Xwg3JqLGsPHGxrbtcZZhNl3gY2we97OYTeNnXtowaGq2JsLQU4LLk P6HktKOpG1NoiGrGcTD0ucYkXR0bvukJsmOsoOrEarMD+8bPRI4JBye3Ey7rLgB4NLVe 377jU1h6+woQzxTapnlAQ2ABbCkVJa3EzXoKZ8mkIhze9LT8s8jSQ4S/SLDKZJnKuSm7 rQ/ZlzSQKCzYGFUOc0JZNCLhRQXNl5x29MMh1+Com1F0qUaXS6wOIECT++AyL5H3iz8a 3hlQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=URcoJ2E3; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Ixu655cB; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=I6ouneTD; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 46e09a7af769-7dba71a77ccsi13060103a34.37.2026.04.07.02.51.15 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Apr 2026 02:51:15 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=URcoJ2E3; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Ixu655cB; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=I6ouneTD; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ypnz6sRA7vjwp3eJwZY9O9fyTItgEJLOtYDrjztNljU=; b=URcoJ2E3O2Nr/B4vBIt3IfXZNB jbR9Ti8by7qS8l68/NN7FMVd+my4cCAyxYLgYiFjD/xTGLP1Ori11yeweka8KCUv7ZP9A6eeSYqgD SyqS6ALAelAKgEnToxYPu/k1RjEYRPNqjG++LK1eVi9OiJW0CuxUFbpUnpYvbQ+XDoTc=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wA35V-0007eT-5k; Tue, 07 Apr 2026 09:51:13 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wA35T-0007du-PH for openvpn-devel@lists.sourceforge.net; Tue, 07 Apr 2026 09:51:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=mha/k4KJg+LgA89sqhPHLN+xlqwC3eulFwvAabiTulU=; b=Ixu655cBMcJf+G9s8yi0ye7lLt Yi6TYE/iUtX03kd/IrW9A5b7ud8j4Ei/FVKM9LqNxZXd+g9T9BVneQg0+t3XxBBkRgnLh1soPED/r TsZ9XGmv4j/ij7iO19CG9oEl0O3U48hZJrdEiSUMNh+O0qr65jj46VW/zMbXhQ2vKIh4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=mha/k4KJg+LgA89sqhPHLN+xlqwC3eulFwvAabiTulU=; b=I6ouneTD7AR4jv+bw0uMdvmVM5 WhGLh9fe7GOQ5rIQinaL7F1NO2U2EmvkgxmjG+iqTpxqyhEWaWLI0/muObEX575WEwHRFOD6ajBFP wyRluho5E9ZTObP6VXR9kxh4gGC/5574/V4ApqwmvOxqYg2bPXqFgdgE11PvUcBO8xDc=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wA359-0003CV-5C for openvpn-devel@lists.sourceforge.net; Tue, 07 Apr 2026 09:50:51 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 6379oiS2028540 for ; Tue, 7 Apr 2026 11:50:44 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 6379oifQ028539 for openvpn-devel@lists.sourceforge.net; Tue, 7 Apr 2026 11:50:44 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Tue, 7 Apr 2026 11:50:38 +0200 Message-ID: <20260407095044.28528-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld Change-Id: I01683153a68e1809a4d7ab455eb346f53780e219 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/open [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1wA359-0003CV-5C Subject: [Openvpn-devel] [PATCH v1] test_buffer: Add test for buf_null_terminate X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1861804858626535773?= X-GMAIL-MSGID: =?utf-8?q?1861804858626535773?= From: Frank Lichtenheld Change-Id: I01683153a68e1809a4d7ab455eb346f53780e219 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1580 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1580 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/tests/unit_tests/openvpn/test_buffer.c b/tests/unit_tests/openvpn/test_buffer.c index 5f43e0d..326de40 100644 --- a/tests/unit_tests/openvpn/test_buffer.c +++ b/tests/unit_tests/openvpn/test_buffer.c @@ -460,6 +460,32 @@ gc_free(&gc); } +void +test_buffer_null_terminate(void **state) +{ + struct gc_arena gc = gc_new(); + + struct buffer buf = alloc_buf_gc(5, &gc); + const char test1[] = "1234"; + const char test2[] = "12345"; + assert_true(buf_write(&buf, test1, sizeof(test1))); + assert_string_equal(BSTR(&buf), "1234"); + buf_null_terminate(&buf); + assert_string_equal(BSTR(&buf), "1234"); + + assert_true(buf_inc_len(&buf, -1)); + assert_true(buf_write_u8(&buf, '5')); + assert_memory_equal(BPTR(&buf), test2, strlen(test2)); + buf_null_terminate(&buf); + assert_string_equal(BSTR(&buf), "1234"); + + struct buffer buf2; + CLEAR(buf2); + buf_null_terminate(&buf2); + + gc_free(&gc); +} + /* for building long texts */ #define A_TIMES_256 "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAO" @@ -540,6 +566,7 @@ cmocka_unit_test(test_snprintf), cmocka_unit_test(test_checked_snprintf), cmocka_unit_test(test_buffer_chomp), + cmocka_unit_test(test_buffer_null_terminate), cmocka_unit_test(test_buffer_parse) };