diff mbox series

[Openvpn-devel,v1] openvpnserv: Remove redundant bit-wise operation

Message ID 20260407205344.31263-1-gert@greenie.muc.de
State New
Headers show
Series [Openvpn-devel,v1] openvpnserv: Remove redundant bit-wise operation | expand

Commit Message

Gert Doering April 7, 2026, 8:53 p.m. UTC 
From: Frank Lichtenheld <frank@lichtenheld.com>

Found by cppcheck.

Change-Id: I7f983168c263e49da7665fc20bd1ecdd426c21d0
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1623
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1623
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Gert Doering <gert@greenie.muc.de>

Comments

Gert Doering April 8, 2026, 12:34 p.m. UTC | #1 
Maybe it's just me, but I needed to look twice until I saw it... 
("SYNCHRONIZE" was or-ed in twice, which won't make it any stronger)
- but then it's quite obviously correct.  BB compile-tested for me.

Since this isn't changing/fixing functionality, it does not need to
go to 2.7

Your patch has been applied to the master branch.

commit df430b03d5959e87fbf502b7430be07f49a0d0ba
Author: Frank Lichtenheld
Date:   Tue Apr 7 22:53:36 2026 +0200

     openvpnserv: Remove redundant bit-wise operation

     Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1623
     Message-Id: <20260407205344.31263-1-gert@greenie.muc.de>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36547.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering
diff mbox series

Patch

diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c
index a2f9f09..ace25b9 100644
--- a/src/openvpnserv/interactive.c
+++ b/src/openvpnserv/interactive.c
@@ -3410,7 +3410,7 @@ 
     ea[0].Trustee.TrusteeForm = TRUSTEE_IS_SID;
     ea[0].Trustee.TrusteeType = TRUSTEE_IS_UNKNOWN;
     ea[0].Trustee.ptstrName = (LPWSTR)svc_user->User.Sid;
-    ea[1].grfAccessPermissions = READ_CONTROL | SYNCHRONIZE | PROCESS_VM_READ | SYNCHRONIZE
+    ea[1].grfAccessPermissions = READ_CONTROL | PROCESS_VM_READ | SYNCHRONIZE
                                  | PROCESS_TERMINATE | PROCESS_QUERY_INFORMATION;
     ea[1].grfAccessMode = SET_ACCESS;
     ea[1].grfInheritance = NO_INHERITANCE;