From patchwork Wed Apr 8 20:42:07 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4883 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:d1c6:b0:83c:d90d:321 with SMTP id ly6csp2970177mab; Wed, 8 Apr 2026 13:42:38 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUqQs6h0oiOPx3Ox+J0/MoMTWs7VuDvk4jZxsSRtADTE1Ae2qka5jYTPKFYC7/YY2bc7F9KPaGYX3c=@openvpn.net X-Received: by 2002:a05:6870:2487:b0:41c:573:aa5f with SMTP id 586e51a60fabf-4230ffbda85mr12881897fac.31.1775680958051; Wed, 08 Apr 2026 13:42:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1775680958; cv=none; d=google.com; s=arc-20240605; b=Rs+/CCXElLpxpQOb0UST5/mkSNUPBYXk0/soLIi9D1QUE3vPDmFklKjvYVQrUCHXea PM8VGcuIjcOe3vBjav0Z6HqvENEIj2aem4VsoMQzigX5cLowt/Scxy5iQLS/ExT7rsiP 42YllppmCb2/uwUpnRQDBgbeW95AmAuR0JBnCMSlwlHjrAOto8cw6dbWsgMOotp3SZa/ wz2e5xURvp+x5zkAajc4yY0VLeevhNM/x3Om7yJJ4U3ljZi8iuOaDbtiyD1NfJVoO9mz x/7szTlP1n0Ubi2qZdyUtbDsQ5jUDGaQM92Nq5whYkRipaOsR8LQQ0G1IKmwj2V1yyVo YkBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=L2B6ymnZC2PWHcY4U/+WWELmU9oh/jeAFN0+6tRShj8=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=aZtQdcXRDUv4dflDl/NyKTbyCYZj498JPeU8dpgO2M5GiCFkJnpgApkhfd2Cpx/4pg 5zfjiHMx5idUkJveaePHXT/bmoOxDPmB6eijszeC8g//0W/YofO32nWJKr7mCWSg4Zla m7hqpNErF2ZkuRMFZSdXtMZ1ORLqchZYuHCAghNAgMXDfFeG87zr19ZKRj7sFuSI7XEU kplnOW9j59/V2AqlKqJAPUs31Hfmz/ukubgEzs/jAdKhD/nCuLYD3g4A25+10Bfza8M1 FowGnagL6lFxVbdbjr3XzKKqeECULKW2dcLF5AOlZUWpib+fjXMjHkKeAuFHHgVoJzqY RjGQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=PrrzhnBd; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=dxnKfRg3; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=azmxzins; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-4230dae6483si15401816fac.251.2026.04.08.13.42.37 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Apr 2026 13:42:37 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=PrrzhnBd; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=dxnKfRg3; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=azmxzins; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=L2B6ymnZC2PWHcY4U/+WWELmU9oh/jeAFN0+6tRShj8=; b=PrrzhnBdf83X9aSU8gVZQHs0Zr 6+W61Quou+reeefVUctNIkSgAZqqMk+kHgIgtgE9tU/HewR4+1AUDHP3rLMTlNT0Dgdhd28MxKgRu GkNnx/PltQZ5Vr4b3/S5N9B6M85A6bXMExMstARqrTLX6lPUJAlerVbwNJEFbN1vcPm8=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wAZjL-0001mA-Cz; Wed, 08 Apr 2026 20:42:31 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wAZjH-0001m0-MT for openvpn-devel@lists.sourceforge.net; Wed, 08 Apr 2026 20:42:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uyat9PqagybaelytiCNStIR+Nsk19/9dSmWS0foNfNE=; b=dxnKfRg3An++Rx/xVa7kmdR2WO tx5QCAoapCK7dqbPSrLAyj/gBj1GQGKpyjt9iPZib5MP4W7bIXPB/ItEWx510ypqn5MN9iJ2qGCSi m+YOI6NQvWCStocQKhq7qkaitn1EvEbIGb3lDI5ZCagG0QEhOWB+aKp5BY9hsf5zTFvs=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=uyat9PqagybaelytiCNStIR+Nsk19/9dSmWS0foNfNE=; b=azmxzinsjup1O61a3vaZdnVudw uDyC5iXAwab0Wq2eohryDp8k4WGop0NXdOGEsVFu7k3Kd7WCOENX2I6yM9cUj2fAGTSq1iHrb16qW cXxOtZYPmHohBAnbGw+2f+t99c/tZWvTktwxOPvmxzi/jPnzUtOuef3Md5lHIRc/R7NU=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wAZjG-0006bE-2g for openvpn-devel@lists.sourceforge.net; Wed, 08 Apr 2026 20:42:27 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 638KgEx1009906 for ; Wed, 8 Apr 2026 22:42:14 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 638KgECv009905 for openvpn-devel@lists.sourceforge.net; Wed, 8 Apr 2026 22:42:14 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Wed, 8 Apr 2026 22:42:07 +0200 Message-ID: <20260408204213.9892-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld It returned a constant value so it didn't actually do anything. Identified by cppcheck. Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1wAZjG-0006bE-2g Subject: [Openvpn-devel] [PATCH v2] networking_sitnl: Make sitnl_parse_rtattr* return void X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1861936436466918544?= X-GMAIL-MSGID: =?utf-8?q?1861936436466918544?= From: Frank Lichtenheld It returned a constant value so it didn't actually do anything. Identified by cppcheck. Change-Id: Idfe2afd9616e17f0f80a914ff054ae18f0b6972b Signed-off-by: Frank Lichtenheld Acked-by: Antonio Quartulli Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1614 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1614 This mail reflects revision 2 of this Change. Acked-by according to Gerrit (reflected above): Antonio Quartulli diff --git a/src/openvpn/networking_sitnl.c b/src/openvpn/networking_sitnl.c index baf6f89..b3f8e2b 100644 --- a/src/openvpn/networking_sitnl.c +++ b/src/openvpn/networking_sitnl.c @@ -1351,7 +1351,7 @@ return ret; } -static int +static void sitnl_parse_rtattr_flags(struct rtattr *tb[], size_t max, struct rtattr *rta, size_t len, unsigned short flags) { @@ -1375,14 +1375,12 @@ { msg(D_ROUTE, "%s: %zu bytes not parsed! (rta_len=%u)", __func__, len, rta->rta_len); } - - return 0; } -static int +static void sitnl_parse_rtattr(struct rtattr *tb[], size_t max, struct rtattr *rta, size_t len) { - return sitnl_parse_rtattr_flags(tb, max, rta, len, 0); + sitnl_parse_rtattr_flags(tb, max, rta, len, 0); } #define sitnl_parse_rtattr_nested(tb, max, rta) \ @@ -1394,23 +1392,14 @@ char *type = arg; struct ifinfomsg *ifi = NLMSG_DATA(n); struct rtattr *tb[IFLA_MAX + 1]; - int ret; - ret = sitnl_parse_rtattr(tb, IFLA_MAX, IFLA_RTA(ifi), IFLA_PAYLOAD(n)); - if (ret < 0) - { - return ret; - } + sitnl_parse_rtattr(tb, IFLA_MAX, IFLA_RTA(ifi), IFLA_PAYLOAD(n)); if (tb[IFLA_LINKINFO]) { struct rtattr *tb_link[IFLA_INFO_MAX + 1]; - ret = sitnl_parse_rtattr_nested(tb_link, IFLA_INFO_MAX, tb[IFLA_LINKINFO]); - if (ret < 0) - { - return ret; - } + sitnl_parse_rtattr_nested(tb_link, IFLA_INFO_MAX, tb[IFLA_LINKINFO]); if (!tb_link[IFLA_INFO_KIND]) {