From patchwork Tue Apr 14 05:57:14 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4887 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:3ad5:b0:84a:48f:a1fd with SMTP id q21csp526433mas; Mon, 13 Apr 2026 22:57:45 -0700 (PDT) X-Forwarded-Encrypted: i=2; AFNElJ9c1fxWdOCRLEvVXF27VV09Dn1Ii9OLHjhxeDxHLcENfsnKt9YLWSj8nQF5fTw0mRfoOfduOqS0VzE=@openvpn.net X-Received: by 2002:a05:6820:210c:b0:683:99ad:33fd with SMTP id 006d021491bc7-68be84dba45mr8224232eaf.42.1776146265211; Mon, 13 Apr 2026 22:57:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1776146265; cv=none; d=google.com; s=arc-20240605; b=fa7wWf2WdpPJboyo/huz4YWHWic+aXga1GqQ0/0Smjhn5p0+/5k9297CrGo4FOJck3 8ArgqYHefdXWxJwBp8LWHstkYcUeuSdQ69Y+8XI0zTa/i9qzJ77Sh9hnF/ERM+RJCAVa 128qiX+tdlijy8Jmump3jdHI+1o0kvUD4vNKGiBJu2b/bwYGjV5568Sv1pKQLQ0EoUjN yX5sdwPrs83i8/CqYWdL50V79nWG+Ja/qjk19mbxlCiy+s/W+b0TESE5sKLjIqk4ki9M nzCGlTQV5e4OXwCmtwdMwYV5rSy1XKP/DuoN/55tFb6qR5mipoR1Vm/S+h7q2fSWm0wR kcKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=l5A/atLQAZsXikGZ7W6WBaIivLWXzuaoi4BA3S8pncc=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=QnIbdzWy2H2+IpyMIxsyqqBhohvvN3lpvFj9HAnMTOzPZEomuriZyAGrRSu7Oi21Q4 r4hHI00s43lCh/c/0oFlqVCZX4Y9iLE3NERuaY4LxMxA6aE9UQ/SKbVx7QAiwLBJe/6N pKqnBFde+Gi6vpAuzdzEOSFeqyujdONrt28kALSYx97wiYIOw7H4NNvtl8SkXpb7kR1S z1SSDhL7itwJ+pgw8NHKvSVqGoZ0hPiePKQFR4spuScMBnFCcvnZbS91ik6zKYMsbkL9 KQrx8J9tXLm5yS+yW9v8OovFxQxfa7+GR3Kn5XXKSVOhCQREq9ihqTne5I9sOHobVNah cMcw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=XNSkqUmd; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=X7wdh3Eu; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=FRODsnMP; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-423ddb9c84dsi11375852fac.170.2026.04.13.22.57.44 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Apr 2026 22:57:44 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=XNSkqUmd; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=X7wdh3Eu; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=FRODsnMP; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=l5A/atLQAZsXikGZ7W6WBaIivLWXzuaoi4BA3S8pncc=; b=XNSkqUmdnDbbG887StYPysA4cu xwLdeNgvmymJyoBtWdzPuAcyh+MHwMKzDbW+42Re3qabXZ2NAQg637AwROZe1CNXx2lyxyhBrQ/SY EL8EqrvMC569yAyYWV3mrfRVfSw+lC4c2xd/4dC2Sn+IIbLZpDkR8ex+XIcIyA/aYLTQ=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wCWmH-0004nh-KV; Tue, 14 Apr 2026 05:57:37 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wCWmF-0004na-8m for openvpn-devel@lists.sourceforge.net; Tue, 14 Apr 2026 05:57:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=HSEkI3AQBmhygZ7e3oeyxnqyNBZGBUZ43NR13No/Iek=; b=X7wdh3EuFrP2F9Nkbhn/0q8FeN 9QvIBsrFZkbBxS9aVoNHWYyuG04U5TafuRbxrMoQIndl5hIyZZ36dgy8FTnrZmnhSLLZHziBbk3ND B3bkZpcqdDEOtqzsrLGipvv/Y11D3FzqpRSwBIny5kdBJ0/MX8IeVsUXuEwivwWH9GlI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=HSEkI3AQBmhygZ7e3oeyxnqyNBZGBUZ43NR13No/Iek=; b=FRODsnMPo9slZ5ZdB0HAUEPZtc jFDbZ28OAHYRXMQJ6O2HGA3nTiHtjUyDI/r7EaGLmJ4/HP61bRajiQjv+bW5aogCsXFwKIKjLkO2p 9LvQr+wX6xEZdYoTpUI007NKgtWSoRMThQboMiBpU65n872br21PFTehMJ81fkQQGmmA=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wCWmE-0003a8-3Y for openvpn-devel@lists.sourceforge.net; Tue, 14 Apr 2026 05:57:35 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 63E5vMuG016885 for ; Tue, 14 Apr 2026 07:57:22 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 63E5vLcD016879 for openvpn-devel@lists.sourceforge.net; Tue, 14 Apr 2026 07:57:21 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Tue, 14 Apr 2026 07:57:14 +0200 Message-ID: <20260414055721.16857-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Selva Nair Currently we get an unhelpful "Key Method #2 failed" error. Add a more specific warning message. Change-Id: I9468811fd434e17645957fc12770aa2b9ed98fb8 Signed-off-by: Selva Nair Acked-by: Arne Schwabe Gerrit URL: https://gerrit.openvpn.net/c/openvpn [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URI: openvpn.net] 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1wCWmE-0003a8-3Y Subject: [Openvpn-devel] [PATCH v1] Log when writing username/password to TLS buffer fails X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1862424346265212889?= X-GMAIL-MSGID: =?utf-8?q?1862424346265212889?= From: Selva Nair Currently we get an unhelpful "Key Method #2 failed" error. Add a more specific warning message. Change-Id: I9468811fd434e17645957fc12770aa2b9ed98fb8 Signed-off-by: Selva Nair Acked-by: Arne Schwabe Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1600 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1600 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Arne Schwabe diff --git a/src/openvpn/ssl.c b/src/openvpn/ssl.c index 576157d..5868d53 100644 --- a/src/openvpn/ssl.c +++ b/src/openvpn/ssl.c @@ -2125,10 +2125,12 @@ if (!write_string(buf, up->username, -1)) { + msg(M_WARN, "WARNING: Failed to write auth username to TLS buffer"); goto error; } else if (!write_string(buf, up->password, -1)) { + msg(M_WARN, "WARNING: Failed to write auth password to TLS buffer"); goto error; } /* save username for auth-token which may get pushed later */