From patchwork Sun Apr 19 13:39:41 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4897 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:66c6:b0:84a:48f:a1fd with SMTP id x6csp1101646mal; Sun, 19 Apr 2026 06:40:06 -0700 (PDT) X-Forwarded-Encrypted: i=2; AFNElJ/gYLtQdBTDlwZCQJLkR5FeV3ZDdm4oyDyUIYJx9GlSx8bJKS3QU4hahvAx6IUAup6akHRk0DObs/A=@openvpn.net X-Received: by 2002:a05:6808:e8c4:20b0:479:ca1e:ad80 with SMTP id 5614622812f47-479ca1ef459mr369409b6e.5.1776606006063; Sun, 19 Apr 2026 06:40:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1776606006; cv=none; d=google.com; s=arc-20240605; b=Ydq7avYIxL9zrNpsZL/sv3qf6hDSryWJMFSjEILm3us3Vby8VnndMhejTEU1Z8yjMS GlR4X+bTlUj/OMfQw/x7MvI+X5d3TcdcJsX9rktAgJQmcdlsYfQKy0UoMSA40ZXbcWxa Tadeeth+wqSr1oMxJm5GXOJLVi0cZjKDUnEglaPBMbZln+FxYMxoa+rjrT9h530GJliD uhAQinRXx/MrB0kY0eDIskWtzw5l04ss23tC31ZKFPIP2RshULcwfc3G0/d0IZaHme+u b8dQhawlKoDqAis/sUKxSS+LIZZzKfSX5i9+fhCo98fzuz3+EKQuzKoSqKc+p0PS7wci KTBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=sajGlvb/RYvesA8jQ5lj0A9lm4fdju827wWMZft5rDw=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=Phtztv5+Pz8fJK9qDDE3of0EMZpWa/+F7ba/FckSKpl6TGe/pHf3sz6xR6nl9+ftj4 ARE8Mlj8gT5z2ZL8zmDjG/bZMWzaqwHXjhxU43n/8mU+E6FDCxV251zkjnm3PdClmRka doL+B6WA47VF+1yNQbituf4aw8ciTuMkrre71AbOOovBvwHv699DF/XhFK2x1BJJGfEG 1ADPQ7NRX8QiJISNT/66NVS+o5NX/gL6hP3e5L3RPmDwh31e4dOnI3R2oXn870q8puXo Vr8fJRsBwdWG++DKu0GQVAwWfGMyq70kqo/npDcnm2CxEGuKxbH4VvAYHlgnC5ceglbL Zr9g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=ECkECq+Y; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=EEXs9bkw; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=P9zdS1Xr; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-42b930704fasi6056016fac.37.2026.04.19.06.40.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 19 Apr 2026 06:40:06 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=ECkECq+Y; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=EEXs9bkw; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=P9zdS1Xr; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sajGlvb/RYvesA8jQ5lj0A9lm4fdju827wWMZft5rDw=; b=ECkECq+Y9bXflxYvzQF2L1WmR6 fPcQAVH9H6HM0oNTfYwOUKMI1J2drUxY3Gq6brHv3M11xCsvGJt5z3xAIJaOdtiNyLxf0OWM37wc3 0l9Kv4iEGP1cxzzHKTXWcENWhLY4J8Wy29V2lv19qpL3hxm9SCM1mVGfABr7iS/DK02s=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wESNV-0004YT-4l; Sun, 19 Apr 2026 13:40:01 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wESNT-0004Xh-Ih for openvpn-devel@lists.sourceforge.net; Sun, 19 Apr 2026 13:40:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=G8LFoFh+21Jo8b1NVFqWpbvo4H44MYdZAHEiJpjctAg=; b=EEXs9bkw8QOGYQXp0+T9/i9kBY qxaAraAHIX8R17xQA0cB+0/9qQGUK2UdiPmSUbppLHs8GnxIUSGP1iCcLPJ9ERuElahhSBFSXv/uP L1yl/V/CbZythEw1H7K8ipaPfQxzzdlYJHQN6MbryHTvSe1dH62h2jD33Krss+hiFO14=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=G8LFoFh+21Jo8b1NVFqWpbvo4H44MYdZAHEiJpjctAg=; b=P9zdS1XrdcjoRV2e0edHNJWb4g lKO6fJQr8970h3siCo2lLuYzMgZbm2geyd2wrBRUfSWdXjTG3JCYDEF/HA0ZwZmEfh49Ci97ljVJ2 h3zVJKjvxAuecQMRzL1H1NNF46fSWpgUohxltxuTmo+OJUqDRhGWYDqooMq7Cj6fgV70=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wESNT-0000Jb-I3 for openvpn-devel@lists.sourceforge.net; Sun, 19 Apr 2026 13:40:00 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 63JDdlTP021228 for ; Sun, 19 Apr 2026 15:39:47 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 63JDdlW9021227 for openvpn-devel@lists.sourceforge.net; Sun, 19 Apr 2026 15:39:47 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Sun, 19 Apr 2026 15:39:41 +0200 Message-ID: <20260419133947.21215-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld Identified by cppcheck. Change-Id: I87c40dc94035345add1162e5029e51288811cb09 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/open [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URI: openvpn.net] 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1wESNT-0000Jb-I3 Subject: [Openvpn-devel] [PATCH v3] tapctl: Remove unused function dont_mute X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1862906419233499068?= X-GMAIL-MSGID: =?utf-8?q?1862906419233499068?= From: Frank Lichtenheld Identified by cppcheck. Change-Id: I87c40dc94035345add1162e5029e51288811cb09 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1615 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1615 This mail reflects revision 3 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/tapctl/error.h b/src/tapctl/error.h index 9632b2f..f9586dc 100644 --- a/src/tapctl/error.h +++ b/src/tapctl/error.h @@ -109,11 +109,11 @@ return (level & M_DEBUG_LEVEL) <= x_debug_level; } -/** Return true if flags represent and enabled, not muted log level */ +/** Return true if flags represent */ static inline bool msg_test(unsigned int flags) { - return check_debug_level(flags) && dont_mute(flags); + return check_debug_level(flags); } #endif /* ifndef ERROR_H */ diff --git a/src/tapctl/main.c b/src/tapctl/main.c index 1d047dd..6a4a240 100644 --- a/src/tapctl/main.c +++ b/src/tapctl/main.c @@ -686,15 +686,6 @@ } -bool -dont_mute(unsigned int flags) -{ - UNREFERENCED_PARAMETER(flags); - - return true; -} - - void x_msg_va(const unsigned int flags, const char *format, va_list arglist) {