From patchwork Fri Apr 24 16:18:33 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4908 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:66c6:b0:84a:48f:a1fd with SMTP id x6csp4578167mal; Fri, 24 Apr 2026 09:19:03 -0700 (PDT) X-Forwarded-Encrypted: i=2; AFNElJ/xfAsHi5fPTAVJXslamHHPJFr0McAQVttkAd9LAm21dYy+psLqTD2PMLEuNMcAIRFICFYXjEkbFxE=@openvpn.net X-Received: by 2002:a05:6808:50ac:b0:46c:e542:cc25 with SMTP id 5614622812f47-4799c8786d8mr19596361b6e.9.1777047543298; Fri, 24 Apr 2026 09:19:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1777047543; cv=none; d=google.com; s=arc-20240605; b=YBdAlWhQF0Mc3i0oTjH1skvKr+r0RtHm8H0TXIL1MxyK4+AqIEWtaOVvlwKjeMlAez 4OnPmd+DlLmB4czInPVhXJlFC67wGC36s5T+0pMPOeFS+7DZsRL4EH9l6aPiBfWCrXGG nOqHaG9RoYzIFRwZVKBJgVpJnxOEBIEfZTtL1UpzkhoVZ0VPhEqXiBh3x16F+SgGU7HE tw313RYSktqNTqdgl0Huwgno8E6//vz0l05XUHo6X4PXB1mbOfE5gdnDY4JEHY3yVTiY sJm/dwNUS3ZMz7Sm3NgEBkXWOaer8JyPsfjJYUn1j/QPeVxvGOWIkJCbhdO7ceiG9yf4 3GvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=Cxx4SqIcKlAJ4zS0rlRyeSuJTOVqbxPDSsfAkIBX4z0=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=j/5OYuiXXgNpz34nF1nusHTiQdqI2K3gdre8Bgrfj/hW3OJ0+/jG8l5q8sFhmytEHU DXeWp4+6XPa5XARemm+bHmwDmGPKnv/ZGmZPhtxVigMw2hhr8UW44D8Zs1gXXOzWyKqW a3tRnpwDcO+4VB3w804Jc/moatoXwAAAqocwnClmebA0VhQWVz0xKfqDLBnJOWiLeEX5 Jub7JG97QJ19LANbHzwR+D6iMn1YudPDSIdeSNtb1AY3n92uP+fryvOObptFUZDrawpH bD+2n1K0a7+KfWovotgNGLMJM6yWcSog70K3kg14GBdSUDsHvEjB7AunPutGhvn4F33p Re5A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=jc00HQ5M; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=jOY8Q0lI; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=JWab5Bnm; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-42f24db7775si10283124fac.88.2026.04.24.09.19.03 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Apr 2026 09:19:03 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=jc00HQ5M; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=jOY8Q0lI; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=JWab5Bnm; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Cxx4SqIcKlAJ4zS0rlRyeSuJTOVqbxPDSsfAkIBX4z0=; b=jc00HQ5MJBbwtT1TcC6bghM7l5 a+Ja4UzQAm/Av3aquz8c+PIyMaJjFHv1zGVl8jHOx+ZViWpQfo9OsAg8gqMLqMQDUksuPgGxemhx1 X7I1H9YRC3AYXoDJprzNmR+toQ93BXlMQyo0QabMKiVbYOIshmGVLGJeAlYx4TdWd5+w=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wGJF1-0002xS-Mz; Fri, 24 Apr 2026 16:18:56 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wGJEz-0002x4-ED for openvpn-devel@lists.sourceforge.net; Fri, 24 Apr 2026 16:18:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=exFRMIxQf4IU5KUXTAtBlP67C+VlsZRd6iw/2/+lj2M=; b=jOY8Q0lIJrGRsHKouFs7QoDAWu /xhBEij33blUxSPAL1yLLqAwz376HJopldkjlG/aJzvSkkhhLe1T6ZMUxiIk0QkJpGEz84x99H4UU J2jhQr6Y5QZkXfClJz2YgB7jmb+kMNT7/NBLc05+nul6QpfWf8x6EO1I7RWzQchPOlT4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=exFRMIxQf4IU5KUXTAtBlP67C+VlsZRd6iw/2/+lj2M=; b=JWab5BnmYEs43QldIOWSCG9BMc 7ZzS9wZVlD0wE6uQcTY4KxjnPT0RwCkMADfVAx/GJLGaFiTQJMwbF5N8nspPnPe68nAd3qWOarsj2 z5x8wgxXxZoCqn78IxzxLd9mvW6KbrmB6fVAnysjFQ2mtbPotYJNXPVTs44CBu+kRw2o=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wGJEy-0001H5-Q9 for openvpn-devel@lists.sourceforge.net; Fri, 24 Apr 2026 16:18:54 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 63OGIesE005795 for ; Fri, 24 Apr 2026 18:18:40 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 63OGIeBm005794 for openvpn-devel@lists.sourceforge.net; Fri, 24 Apr 2026 18:18:40 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Fri, 24 Apr 2026 18:18:33 +0200 Message-ID: <20260424161840.5767-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Selva Nair Commit b450414 added logic for reading password from management when not in file or inline, but it was made conditional on `response_from_stdin` which is always true! Fix by explicitly checking for `p [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1wGJEy-0001H5-Q9 Subject: [Openvpn-devel] [PATCH v1] Fixup: prompting password from management X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1863369404486533088?= X-GMAIL-MSGID: =?utf-8?q?1863369404486533088?= From: Selva Nair Commit b450414 added logic for reading password from management when not in file or inline, but it was made conditional on `response_from_stdin` which is always true! Fix by explicitly checking for `password_from_stdin`. Change-Id: I4d46c3672691b159cbd98a17020c4f30782bc202 Signed-off-by: Selva Nair Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1638 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1638 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpn/misc.c b/src/openvpn/misc.c index 979293f..10bfc35 100644 --- a/src/openvpn/misc.c +++ b/src/openvpn/misc.c @@ -336,6 +336,7 @@ */ if (management && (flags & GET_USER_PASS_MANAGEMENT) && management_query_user_pass_enabled(management) + && password_from_stdin && !(flags & GET_USER_PASS_USERNAME_ONLY)) { msg(D_LOW,