From patchwork Thu May 7 07:54:56 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4922 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:9b50:b0:84a:48f:a1fd with SMTP id b16csp3533981max; Thu, 7 May 2026 00:55:23 -0700 (PDT) X-Forwarded-Encrypted: i=2; AFNElJ9ie7ZdM3NY6kqG+MrNUIiW5J/zjU3JZpxfvU8URIAIczL+fWgjZfAhPEOt1GmHdt91vaASxPDfs08=@openvpn.net X-Received: by 2002:a05:6830:927:b0:7dc:c926:4f87 with SMTP id 46e09a7af769-7e1df05f73cmr4238314a34.16.1778140522830; Thu, 07 May 2026 00:55:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1778140522; cv=none; d=google.com; s=arc-20240605; b=CEfpn4+APdojN4nJRSU0XEpcKsu75STKXVY6VqjaVDgLGBpp0DIu84urwcohA7dJUm Jm78Rz7u545IBGlJYfHP8XIezm6lD9k92lUmx8I26ksCJHfTsWIzt5RTg28/EqLdpVSq Nd+OoI1M2pxH2/pL8LzjCSB7pIuUigHOPDd3MciIk/ifJNFcaSnS1MGOl085FDDL/VKm 0hngwNiKTH7rtltl2oU2Ycu0tdUhpNeXMiMVm9kUGydJOlOR3hwgOfCt2DFTBmN2x76e 2ix9K158s/ptH5bspfm889p5hu6P7XjRZ3NI9RsV2GOseMb3XnZOgShLo6zm80aJl6jC VAaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=qMrk7NnuTqn1aK6/Q7P102zSOwIsAoSYDTkB3Z5D480=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=S029YKVFW+0PAN354bIcX4G/rOF3ZgMlNdmtkbcH+gkROdYieZFmMHyOlqxYBxT1oL qR4VEcNGhanoPVdTS1BIbMpkdGLMMvD6tYS4jciE8wMoZhAv+k3R1O/kxFZ5qlvv3YtT d10uruPn0yfwWhfPlFmPXt26AyzhuERm/dZfChJyka2T+6Mb6Csef/sljiAmG2V8P5mJ pN54FFNxpSrjQnTF7KIm/KzbJ5CNQL508Q98q71qr+0aJNWEpEFec9d6QYXhUJap2bwr cwI8KOKevRvHoDUGi7F1dCksKWFYnv8j8M/bJuBWHzwZLlfomntZ9z6qaQ1r6CbaaB19 ZvGg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=WFc7NaNl; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=ORZSaUSx; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=RILkzv6Z; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 46e09a7af769-7decae907cbsi12057027a34.99.2026.05.07.00.55.22 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 May 2026 00:55:22 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=WFc7NaNl; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=ORZSaUSx; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=RILkzv6Z; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qMrk7NnuTqn1aK6/Q7P102zSOwIsAoSYDTkB3Z5D480=; b=WFc7NaNlp5Dhm/eBt2wkUVhlcO l/kMlwHmsQHeF8inxUOUwlxzOW1VWu/utJkjW8zJQAy+uf7OaBSmIU3qsVJbnbNRfph4luLy2Nv8x MoaZR1oMl+dbf2j4haaTMV1Jw2oa7YxRerPWBTGtwYoodOKkQHXSmJxYjAu6YO2LX76Q=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wKtZl-0006wW-A3; Thu, 07 May 2026 07:55:18 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wKtZi-0006wA-8I for openvpn-devel@lists.sourceforge.net; Thu, 07 May 2026 07:55:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uk3pODBcmQjQtz+UPHBxeDStfT+Oq8NKMP+pU8uGPck=; b=ORZSaUSxVwwkGJZNukJXf7RaU6 A5ORsAwDQlD/BDx83On7vo+WflRnn11u+V9Q3153dQ89GQWLhAav94fmV3mqwFew2sNWxPzPHV9Pp /kyXykgXBGL8EF1XZTF5yfq0Irc3YhQj99t3rxuEOreZUjV0skcP6YcQtfzaeLYW4f3w=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=uk3pODBcmQjQtz+UPHBxeDStfT+Oq8NKMP+pU8uGPck=; b=RILkzv6Z5v0qHRTPdxSZRKjld7 AV3BQWmNPKSRXwRsiCwXAM6NKo7P4FwYe44YNl3Ut0TywOofOAyml6EJV1yqLxGYtpBsxNYd8I38d MgfQe5j4LbpmwjQyM9FyddzTCY8eZz/CjffkhrNU8I9VY/Vwm+m6WLJAOAUuJHIwarCw=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wKtZi-0005al-3g for openvpn-devel@lists.sourceforge.net; Thu, 07 May 2026 07:55:14 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 6477t2lg025497 for ; Thu, 7 May 2026 09:55:02 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 6477t2Xs025496 for openvpn-devel@lists.sourceforge.net; Thu, 7 May 2026 09:55:02 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Thu, 7 May 2026 09:54:56 +0200 Message-ID: <20260507075502.25473-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld Change-Id: Ia7ad24181bd97dccbb77865c10e829778f72a506 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/open [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1wKtZi-0005al-3g Subject: [Openvpn-devel] [PATCH v2] sample: Fix cppcheck error invalidPrintfArgType_sint X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1864515476983103184?= X-GMAIL-MSGID: =?utf-8?q?1864515476983103184?= From: Frank Lichtenheld Change-Id: Ia7ad24181bd97dccbb77865c10e829778f72a506 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1662 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1662 This mail reflects revision 2 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/sample/sample-plugins/log/log_v3.c b/sample/sample-plugins/log/log_v3.c index deae590..d2d44c7 100644 --- a/sample/sample-plugins/log/log_v3.c +++ b/sample/sample-plugins/log/log_v3.c @@ -91,7 +91,7 @@ } /* Print some version information about the OpenVPN process using this plug-in */ - printf("log_v3: OpenVPN %s (Major: %i, Minor: %i, Patch: %s)\n", args->ovpn_version, + printf("log_v3: OpenVPN %s (Major: %u, Minor: %u, Patch: %s)\n", args->ovpn_version, args->ovpn_version_major, args->ovpn_version_minor, args->ovpn_version_patch); /* Which callbacks to intercept. */ diff --git a/sample/sample-plugins/simple/base64.c b/sample/sample-plugins/simple/base64.c index ab6aed8..3b11543 100644 --- a/sample/sample-plugins/simple/base64.c +++ b/sample/sample-plugins/simple/base64.c @@ -122,7 +122,7 @@ ovpn_base64_decode = args->callbacks->plugin_base64_decode; /* Print some version information about the OpenVPN process using this plug-in */ - ovpn_log(PLOG_NOTE, PLUGIN_NAME, "OpenVPN %s (Major: %i, Minor: %i, Patch: %s)\n", + ovpn_log(PLOG_NOTE, PLUGIN_NAME, "OpenVPN %s (Major: %u, Minor: %u, Patch: %s)\n", args->ovpn_version, args->ovpn_version_major, args->ovpn_version_minor, args->ovpn_version_patch);