From patchwork Fri May 8 15:31:02 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4923 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:a719:b0:84a:48f:a1fd with SMTP id hl25csp179674mab; Fri, 8 May 2026 08:32:03 -0700 (PDT) X-Forwarded-Encrypted: i=2; AFNElJ8R/8CqjX5STSNpefvmdKRJcNrfgT/2lGXpVTFnA+vfxfBdxhRJCyCC4WXa2kz6RBSuS30h8Ho8Oj0=@openvpn.net X-Received: by 2002:a05:7022:68a5:b0:128:d396:f2ea with SMTP id a92af1059eb24-1323ac9c84cmr3484155c88.11.1778254323143; Fri, 08 May 2026 08:32:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1778254323; cv=none; d=google.com; s=arc-20240605; b=Bi0CUP0OpQHHk0m+Vj5Wha2qAuZNkhABVkC9Z8ZWpP3S2sZXri8UmAxzU2wImNSso5 awCqvVtAouw2SyfspJNJDiRQcxtqUPwTYWaGGxDcyEQJyyzfyKkBPU9af1pG3Q2FR9en 7d9dO2cuP47XZNYF7iDVlttdgeerIE+7yKVwAVSnYPQDjzOUeX6FHteb+TFKhiK8h+Cj dTsv1mqQzwsAkZ6efyF81ognfkkw42H/CJXy/jhqZcwiaASzo/6tg022CfkXMhswqOul x6Jv8x1y/uMlr5gTR2yuVPWxbk7y7c5cGoXYbJy8c26EAoGSqcKkBhop1WXEFw7OkUiT lLVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=d+hct4GpBTsLu2wsaY3MUem8W5Zw66L1z+E7EQT3HvQ=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=Wiq6u9hXkcF1zPvZ7UIYRrrn5vrGgPJSAU1+9fHngNFy8DZM3dAklLOVn6QFn+RoZZ ne36JxS6UB5UnLgEsYYUfEeTKKtcVF9VhlpOmnT9SzGpKZhqgQNxpFUB4Wm/pEEFCiKl s6xXIr5on7PmbACNEQaMSG0m9WZ4i1n45WMu9QTxw+NpVPu3VjLpZrKg63JR++bTL2dR evJYGKplutawIcYVJTE/BArOuXRC9nP7zpfIOYlqSOywRJtYXiYzpizGeI3Ov/Lv2ji0 6u2irN/hK0+cO4eCAtIBDbzvCP9jCfRFhh1EokTi2Yw1uDNjmODhm5H8e8/+edyCtyXq kXMA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=nBRSSh4n; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="ISDt/U4F"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=XT3gawoV; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id a92af1059eb24-132783175cbsi5381039c88.29.2026.05.08.08.32.02 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 May 2026 08:32:02 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=nBRSSh4n; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="ISDt/U4F"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=XT3gawoV; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=d+hct4GpBTsLu2wsaY3MUem8W5Zw66L1z+E7EQT3HvQ=; b=nBRSSh4n1Ggvj02uQdvyEU6WjT 9OkB3iVar6ZLI0nNwialjtqHuBqXvnMfYENql0Y4AAcz/Tj3TTXe3/0yYb+YRQKT0chxbevSe6f5F YcjBEfN/zPdNFC/EStIjkAT4mjkE4GGyaDjjXvZWf1mzwaoBJUs2g9Y+HD9SbL6PQqaE=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wLNAi-000100-LK; Fri, 08 May 2026 15:31:25 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wLNAh-0000zu-K6 for openvpn-devel@lists.sourceforge.net; Fri, 08 May 2026 15:31:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=70m7eulM8Z8hwsIHNGOl78zREiuzcsHfyKvov0EsRyg=; b=ISDt/U4F8/htVFNDB4G1kScUxy 3qmRiNa9TlYxt9j+5W5+bY5Iaok+ozPntZFyXjCYGP/7UhUkKhNKFTUOPl9a6AdXX9a/078LBNyWr HdnO1JwgN4QhGZpud7DK6yeDOrq8Rp9HiJKXBUvf1jY2KiKvUpsh3KzG5Xlnq04CXMZE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=70m7eulM8Z8hwsIHNGOl78zREiuzcsHfyKvov0EsRyg=; b=XT3gawoVKxZeksbhLuzv6E5hGO BLPx8kLVBrjFDpSHaYFefV2ORKu3PFhljS1lzTj1+WtJRFBzjheUGhsQkUyxds5NE6Q/laU9SL8im nKr1dXL0+U2LCCChrWsWew0DJLA1DIB0ATY8S9gmX0BkF0ZiQhEsQ72SfIHYuE5JFhCM=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wLNAf-0007RH-3j for openvpn-devel@lists.sourceforge.net; Fri, 08 May 2026 15:31:23 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 648FV9EK013516 for ; Fri, 8 May 2026 17:31:09 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 648FV8ga013512 for openvpn-devel@lists.sourceforge.net; Fri, 8 May 2026 17:31:08 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Fri, 8 May 2026 17:31:02 +0200 Message-ID: <20260508153108.13488-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld For some reason neither MSVC nor MinGW complained? cppcheck did (once told that msg is a printf-style function). Change-Id: Ia688ec12e642de699811ced8668b40be9fbb6155 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/open [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1wLNAf-0007RH-3j Subject: [Openvpn-devel] [PATCH v1] Fix some msg() calls with wrong number of arguments in Windows-only code X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1864634805060542696?= X-GMAIL-MSGID: =?utf-8?q?1864634805060542696?= From: Frank Lichtenheld For some reason neither MSVC nor MinGW complained? cppcheck did (once told that msg is a printf-style function). Change-Id: Ia688ec12e642de699811ced8668b40be9fbb6155 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1672 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1672 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpnmsica/msiex.c b/src/openvpnmsica/msiex.c index f8bf6ae..4d48f06 100644 --- a/src/openvpnmsica/msiex.c +++ b/src/openvpnmsica/msiex.c @@ -51,7 +51,7 @@ *pszValue = (LPWSTR)malloc(++dwLength * sizeof(WCHAR)); if (*pszValue == NULL) { - msg(M_FATAL, "%s: malloc(%u) failed", dwLength * sizeof(WCHAR)); + msg(M_FATAL, "%s: malloc(%u) failed", __FUNCTION__, dwLength * sizeof(WCHAR)); return ERROR_OUTOFMEMORY; } diff --git a/src/tapctl/tap.c b/src/tapctl/tap.c index 6ed395d..cccc0e1 100644 --- a/src/tapctl/tap.c +++ b/src/tapctl/tap.c @@ -487,8 +487,8 @@ } default: - msg(M_NONFATAL, "%s: \"%ls\" registry value is not string (type %u)", __FUNCTION__, - dwValueType); + msg(M_NONFATAL, "%s: \"%ls\" registry value is not string (type %u)", + __FUNCTION__, szName, dwValueType); return ERROR_UNSUPPORTED_TYPE; } }