From patchwork Fri May 8 15:31:51 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4924 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:a719:b0:84a:48f:a1fd with SMTP id hl25csp180036mab; Fri, 8 May 2026 08:32:35 -0700 (PDT) X-Forwarded-Encrypted: i=2; AFNElJ/HtAuxx9dLb9zj7MkjekirSP8y4lSKhDxIWY/o7Mr/Wn8Arkjtl7pLS0UPvQyvWZEaHGN8dSuKxEY=@openvpn.net X-Received: by 2002:a05:7300:6ca8:b0:2d2:96e8:1bf5 with SMTP id 5a478bee46e88-2f54d696b08mr7023827eec.3.1778254355023; Fri, 08 May 2026 08:32:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1778254355; cv=none; d=google.com; s=arc-20240605; b=PM+ovsKgltPMD/WkOsTU7LnPsDXMthumH4dBDPMuhxxG9Ea51XFgBY9i5Imw2f7dIT rb9ocuXSimFYoo5IPWvSxYOpHWV7FEiLNyEPenUsoFnp743wH0ISoYw+YjkuyFCINr3+ /MWZNyAFw6sgVDeQWRovWnL0hRZEVp29tA4vKnOWFx3akdVdq98Kq26CqTKt0efxRpg5 tiLsubgzbA8SwuwgOb1CbFOlJZeAk+upMkfndtckP/u8FcH4D9DgbY5tI5IyoPqpVtUI m0A6QqI6II/gjVLIoc2MnXHL8hd2oMxYSZpccz9ArnOLrmoOheXNsXesPvZCkrYlZH5Z T6MQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=Je8/OqiMQDwQ0/jpYCDPbY6xLTXxUfm8ZIJ0mue/pjY=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=AGQIIZLi7+YAqti3rt32QaOT6jaBwoLB3eFdx+3SVKfsVqfFxr+MGrImH4xDuzp8NA 3GYynPtEpXavXOXZJJuzo74nYIlOYwr47kdRA4wdzFhckZoOu1q2VhhmHlNKi8gcIW8l N4IudSQ6MrrUkdHKUnUQ20vyXJ14Kl5YKIUqU4QbAuGpSqHEInDMbFtDpbm5sfW8mtfK X6qvY08KopapGfnjuffl5vai9trx7XT87T+bnrCsCp2zfFePkplhgvxBHmL8jUG4P4XT y2NXSpP3Z7EkMMFeVRb++XFZBDQg9hU70IbHUu6OZrvM8m+TMpx+3TN/Ab0qc+LfpVUG O2Mw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=Jk6P0CEz; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=luRKGK3U; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=V88tP1Qm; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 5a478bee46e88-2f889443043si4945411eec.76.2026.05.08.08.32.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 May 2026 08:32:34 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=Jk6P0CEz; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=luRKGK3U; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=V88tP1Qm; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Je8/OqiMQDwQ0/jpYCDPbY6xLTXxUfm8ZIJ0mue/pjY=; b=Jk6P0CEzjQx08MGAMkiAuoy0CP AoNdjognksXWsU2MT6KCn2B5OsM69Y8x1cr0zxkKi36yrHaOxD4myhCyrPjfeQmei2saZ/sy8Zb9b xv+JzS9yMvHEgnypIB/jAZb2X6fk3pstoW3SO7eZgGS9g31LQQTg/txj6bWmhtnk+4AU=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wLNBO-00012D-1d; Fri, 08 May 2026 15:32:06 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wLNBM-000123-ST for openvpn-devel@lists.sourceforge.net; Fri, 08 May 2026 15:32:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=EFUXkzhpa4uDhh8jlNv9JE3ktbOSeMUXtLUp4rJLh+E=; b=luRKGK3U/wygqVVxr5qs4Xrf5D mlVXgRCLx1V0Q/G7G10JUvJwH8OKAX7riyuzjO8jsc6k3GHQQDlbyc3IVT6N6bibemAMn5vQwES7A Br45ebPE7U0WzL8X3i3PLGDqGZYD9psqOkkef3dO14YaXeb6SXO4qVm2UXJZpgN/z57I=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=EFUXkzhpa4uDhh8jlNv9JE3ktbOSeMUXtLUp4rJLh+E=; b=V88tP1Qmj0fgtVqFuKMDX+hU6D aiwa94yxBjbZRmmjD5MyHUtmfrACpTHf4ccUoWhEXyLhSmVTCgUwCY5h5tKqVqZq5oxiiGrOHcOwx Ncoa/DdkfIGDn8rpJuQmRz1PCsD4lovpLWE+3H4q0XJYaufAJn7PriPtPDk+SSXGMCrU=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wLNBL-0007U2-KH for openvpn-devel@lists.sourceforge.net; Fri, 08 May 2026 15:32:05 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 648FVv5E013589 for ; Fri, 8 May 2026 17:31:57 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 648FVvaW013588 for openvpn-devel@lists.sourceforge.net; Fri, 8 May 2026 17:31:57 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Fri, 8 May 2026 17:31:51 +0200 Message-ID: <20260508153156.13575-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld Identified by cppcheck. Probably has been a long time since that code has been compiled, though. Change-Id: I09ebbf6f3555dd68ce8d75bfa844ecac518a0cf2 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/open [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1wLNBL-0007U2-KH Subject: [Openvpn-devel] [PATCH v1] pool: Fix a potential NULL pointer de-reference in test code X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1864634838371732095?= X-GMAIL-MSGID: =?utf-8?q?1864634838371732095?= From: Frank Lichtenheld Identified by cppcheck. Probably has been a long time since that code has been compiled, though. Change-Id: I09ebbf6f3555dd68ce8d75bfa844ecac518a0cf2 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1676 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1676 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpn/pool.c b/src/openvpn/pool.c index 15004c0..ff74e7c 100644 --- a/src/openvpn/pool.c +++ b/src/openvpn/pool.c @@ -757,7 +757,7 @@ break; } msg(M_INFO | M_NOPREFIX, "IFCONFIG_POOL TEST pass 1: l=%s r=%s cn=%s", - print_in_addr_t(local, 0, &gc), print_in_addr_t(remote, 0, &gc), cn); + print_in_addr_t(local, 0, &gc), print_in_addr_t(remote, 0, &gc), cn ? cn : "[NULL]"); array[i] = h; } @@ -793,7 +793,7 @@ break; } msg(M_INFO | M_NOPREFIX, "IFCONFIG_POOL TEST pass 3: l=%s r=%s cn=%s", - print_in_addr_t(local, 0, &gc), print_in_addr_t(remote, 0, &gc), cn); + print_in_addr_t(local, 0, &gc), print_in_addr_t(remote, 0, &gc), cn ? cn : "[NULL]"); array[i] = h; }