From patchwork Thu May 14 09:19:12 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4938 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:a719:b0:84a:48f:a1fd with SMTP id hl25csp3708331mab; Thu, 14 May 2026 02:19:35 -0700 (PDT) X-Forwarded-Encrypted: i=2; AFNElJ9waWPpbzknpOrEWkFQkd41U6/gHupmvq1TymAKUsrWHPJ+CTF8JRWjZIiaZoVakvBYu7gS50PG4sU=@openvpn.net X-Received: by 2002:a05:6808:c1a9:b0:467:de9:3eb0 with SMTP id 5614622812f47-482b5cf864emr3750683b6e.1.1778750375598; Thu, 14 May 2026 02:19:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1778750375; cv=none; d=google.com; s=arc-20240605; b=Y0CRB8Hh8hCJK6nP+JdtxDlKtx3DiLd5XYColkAkEOlhyTcVwMYjZKu1TeW1erZO/i R2oCGoWsBUkCnD6qooc0vAe8FnArHSDacDcaHO+O5jYbzkoThfHT/mMcGwVbyS2Q37rd Bm3GtxdlasnGmUm+AKkqAz+eOlbtqwGVWEa+GPd0Ub18qK88THagELnnvkz7m2XBtgaV yVHj+Lf1n//Vqj56SE9G4NUkVuY5vfcwT5CuO/CwFJE5s1NUt6evAswO3MVfwRPsJCc2 yeA2BCBGKAP/MawaE/LyN7ACngCDxg2uWTWg4GgPzQa8n61vbQD2C/BpbsvFJY5qkgXf o0eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=12u5XCiOD9sKjhz615QQ24ldVNvZZSlgY3Ii4SbUko0=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=SXFb0qhs0yFaaK2s+ppgL5Xcb2aVdck2LuNlTJhOV2B+dGgPsvPImSHGNjK/HdAKM6 gdh9IdJnQ3fgd6JnBnFvysBHrCd8kM/0FQiPj4Iu+cjbedu5EES9BmvmnLRcQYlxHmth 6jAMBWZAJ/mr2VzuxAXdknMa2Mz12Ha78L9NkJuO7xs5gZZ5TWG3W+mPyW6XLkvq1Qi1 a7KcR96rDlP5lOIoH9t85Ua/7w+hwKPbBdYol8qCew6UUTQMUrL0rvRhDTj799Az6fNn SdlvlD6qP1GxDwy4FuGUTMkPJOolEHkr1ZC5AXaiNz/F8tAR3JqQk1P7Tu82qFErn9u4 1zBw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=TIvsGhaA; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=G2zwjG3O; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=hKs5Z1tn; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-439fc7c4656si1496549fac.324.2026.05.14.02.19.35 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 May 2026 02:19:35 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=TIvsGhaA; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=G2zwjG3O; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=hKs5Z1tn; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=12u5XCiOD9sKjhz615QQ24ldVNvZZSlgY3Ii4SbUko0=; b=TIvsGhaAJciOOgUpu4YvDnSiSH ZbnnwKUgjmSLM8+mi0JNEShmG9HFqFlK4CW46gsug3YKF9nkND4ersE186H9llNP8xdz/2Xza6E4M aG0op82asO6O44kneM+2EFAvh/+eXnG1kXbgIUVsBXJX6RSo3nq7PyytKMlo2XT/WMAs=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wNSE5-00051J-T3; Thu, 14 May 2026 09:19:30 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wNSE4-00051A-0x for openvpn-devel@lists.sourceforge.net; Thu, 14 May 2026 09:19:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=mYBy7O91h8gttg1Er3MEOvdqrKcXnYUw+tdgy4ToglI=; b=G2zwjG3O2+2nr8jJNXbH3SwgyP D80ob/RODY8H+13LvlWqYUgOozyqEqkakPwjaxjJMdCzzpLtyxVwpt8BUVhqK2vXSQwG/eMazyFu2 +OyZfK5HNYUdc00mPHImAbTBBRM0m5gv1Xd+sh3nEipdNI/gotyyaLeGgH5Yre0PtCq4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=mYBy7O91h8gttg1Er3MEOvdqrKcXnYUw+tdgy4ToglI=; b=hKs5Z1tn9vQ+lAvMGLD2PBLIl5 R+cy8A2rHKvcbNf7SDQkkrCTx3Rt84RGAJcHLNunHBo5NtzmqX9O+uvJyXEl3BJxMaHqtnA/YAoEq AKveJarEXPoMxbWHpym/vFIjQKyS5e5ZJbCCMDV+67ysfZ1cw55MmpYeROsoFDXa+BPA=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wNSE0-0002Zd-UF for openvpn-devel@lists.sourceforge.net; Thu, 14 May 2026 09:19:28 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 64E9JI4b018222 for ; Thu, 14 May 2026 11:19:18 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 64E9JIUh018221 for openvpn-devel@lists.sourceforge.net; Thu, 14 May 2026 11:19:18 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Thu, 14 May 2026 11:19:12 +0200 Message-ID: <20260514091918.18197-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld Probably not a real issue since it should always use the W version in our case, but still unclean. Fixes a cppcheck complaint. Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1wNSE0-0002Zd-UF Subject: [Openvpn-devel] [PATCH v2] openvpnserv: Use same variant of UuidToString and RpcStringFree X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1865154954167465833?= X-GMAIL-MSGID: =?utf-8?q?1865154954167465833?= From: Frank Lichtenheld Probably not a real issue since it should always use the W version in our case, but still unclean. Fixes a cppcheck complaint. Change-Id: I3d391016dcd3c66e58f3f05b356bcd419224acb1 Signed-off-by: Frank Lichtenheld Acked-by: Heiko Hund Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1671 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1671 This mail reflects revision 2 of this Change. Acked-by according to Gerrit (reflected above): Heiko Hund diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c index e25c511..bd310e4 100644 --- a/src/openvpnserv/interactive.c +++ b/src/openvpnserv/interactive.c @@ -3484,7 +3484,7 @@ swprintf(ovpn_pipe_name, _countof(ovpn_pipe_name), L"\\\\.\\pipe\\" _L(PACKAGE) L"%ls\\service_%lu_%ls", service_instance, GetCurrentThreadId(), pipe_uuid_str); - RpcStringFree(&pipe_uuid_str); + RpcStringFreeW(&pipe_uuid_str); /* make a security descriptor for the named pipe with access * restricted to the user and SYSTEM