From patchwork Mon Jun 8 13:32:51 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Antonio Quartulli X-Patchwork-Id: 5005 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:bc1d:b0:861:c897:cb9d with SMTP id jc29csp1885199mab; Mon, 8 Jun 2026 06:33:13 -0700 (PDT) X-Forwarded-Encrypted: i=2; AFNElJ9OKUH3Rv4FEC2MXFD+ORn0n1BhR1cXDw7BfkfX6OVjjMQsPcoAFISksgGLEUf+yDkvcLJZd79mMI8=@openvpn.net X-Received: by 2002:a05:6870:2246:b0:435:25c0:a4b0 with SMTP id 586e51a60fabf-4413db33a22mr6930152fac.15.1780925592732; Mon, 08 Jun 2026 06:33:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1780925592; cv=none; d=google.com; s=arc-20240605; b=e6D/yTqMDPdU8iPVJBB/FTx8KUHgO3tpFiUGpmr3zo+5ess3fae2GcJAux2GGXtJ6g uUJ4Bvg4mBJso/KMYt934VSLYXCEFCzB9TpiHhgChMEKvscXbfHC8xfXBD8PUimUwV+4 rlSFBS8YxODJgrTYYJhiFOdvvAq5my7JXETNX31cjDb2hOeeviM0iQrH/J7+h21sp9fy /bZFD8DeggGukq6+VWe2QXXPDqjBtm+o+gSaA81NkkhfSoc/VZ/0qaV9MUyX1cphPw01 fcsLek+Xkx0a/U3wQTyn9sVrGSk72z3tzcmj8ff0iKJ3Vfvf6te0p5PITsIu5y/8ROZO 0lcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:cc:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature:dkim-signature; bh=rUWQF8SNLD3wFAs7D7NWrVe1YnReAFzszAGiE/rgB48=; fh=BsMg/B0Yb/hS/rzP5Npz4luh0IleZm8REk1XWiWRt2A=; b=Y4Z55/v0cmZK9z+OLWurkyqI7YMTQTUwNVuvt3wAChfJv1waYx/EIKXYmcDn65zdlw CyGSa+sfgIKLw3gyCJptIA8FVSeynEcs0FspX1ji6Zpizco7cSDY0cGhgSqmqgKE+oI+ bA87lB4Z5/b7tq7q/yRH7Uyi/99AGtIklqz4UWsqpNAWo2xCX42wGw1y3U6xnmRsuJWK BaMoGSuouUJURCErQt+2d3DWWRRf07lVX1F+MZnIIcAfTTPcxUyN0G8om8Lf1kFnjg10 OjGpj+3ZJ4uKQ307ApWT+Lw97duRxSdXqEx/yfJ51cvWzTLMRzOzCSYlbr37CXgKf/1R SifA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=UhRjEu4a; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=GE3CaN4J; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=kTBhqr2x; dkim=neutral (body hash did not verify) header.i=@unstable.cc header.s=MBO0001 header.b="G2M/i67q"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-440d85dff51si13382501fac.138.2026.06.08.06.33.12 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Jun 2026 06:33:12 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=UhRjEu4a; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=GE3CaN4J; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=kTBhqr2x; dkim=neutral (body hash did not verify) header.i=@unstable.cc header.s=MBO0001 header.b="G2M/i67q"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rUWQF8SNLD3wFAs7D7NWrVe1YnReAFzszAGiE/rgB48=; b=UhRjEu4aMoZxq2d2dbcy3pvWhR a9d0G6VHSrnyfRHU+ugHALS7hdHKFZpXmtjt4ZkoEWnuPW3jJJe8JVCd7JFhJsuv1alPjZ7nRDgVM 5d/+RnM2Y8nArHmAhaRTIguU61IZUcgD0RRNStCdtDf8QK7jtF5M319EGEj8H67u4xMU=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wWa6K-0001wK-BE; Mon, 08 Jun 2026 13:33:09 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wWa6J-0001wC-D4 for openvpn-devel@lists.sourceforge.net; Mon, 08 Jun 2026 13:33:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=oUrXqBhmSv6hUIjm7a15fhpW2j0ChPArt7p7zWguUEE=; b=GE3CaN4JLtwDXlqa7ikyV5y1X/ 5bzp6Y1lxSttg4tLedoYaYgXQbiBVomm4no0G+M0XxCf2cokDADaFlJ3KYRMLb9EFdHr73dTWzIue rf7lDIOgzo3ZIykmC5oazXxO4g+qMpkRlwe30MUtdweDjtIdDukPRmasCT64ROhaxZNw=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=oUrXqBhmSv6hUIjm7a15fhpW2j0ChPArt7p7zWguUEE=; b=kTBhqr2xmOGuLGXcbAb5eCQ1/W Zj4rt75W0A+G0P9G3zkeUVKuidg9RYviaZD3gzAaZvgIJS/bv7c9IkCYT8XhRQ0qgO0R9k5wkWJ5F jFB4DIOwrZntg5hmx9089+Cm0fDcA0kyJzkhZZMaEcIAnn1u8sqnhb91vU0GM8R9ZEzk=; Received: from mout-p-101.mailbox.org ([80.241.56.151]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wWa6F-0004wS-38 for openvpn-devel@lists.sourceforge.net; Mon, 08 Jun 2026 13:33:08 +0000 Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4gYtJq6Nztz9thr; Mon, 8 Jun 2026 15:32:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unstable.cc; s=MBO0001; t=1780925579; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oUrXqBhmSv6hUIjm7a15fhpW2j0ChPArt7p7zWguUEE=; b=G2M/i67quH8YxhFkZeZGTvlh+kMGwTHt5vghTDvL5jZrltKV6/SWG87YfjdOXMcncEYVHc Md2IdQMJOj9Mp2IZAvXveoht6VEHYUMAghkZNPP8AeGBZEz0xElZMaimGsUyyRuXRf2HPN 9ZmI9ERLaU17XeD7JZZNveE3Qw7ZmHX59GnfMTQam/NWh1J/6TmSWptnH4cAv9idRwtjYa g1WVxhTEd/Al7i/yz2z0raeuPNzdsKVZwHAPjriNGe1dDbnxnfm1E5CPMsvgo8PvzRIcY9 uwCyx/GyKudpdXgkbRBZIS9KJvK1KNDBoNbdGC1xlLZ0k0vTSsSrX5s5sUwJaA== Authentication-Results: outgoing_mbo_mout; dkim=none; spf=pass (outgoing_mbo_mout: domain of a@unstable.cc designates 2001:67c:2050:b231:465::102 as permitted sender) smtp.mailfrom=a@unstable.cc From: Antonio Quartulli To: openvpn-devel@lists.sourceforge.net Date: Mon, 8 Jun 2026 15:32:51 +0200 Message-ID: <20260608133251.3128542-9-a@unstable.cc> In-Reply-To: <20260608133251.3128542-1-a@unstable.cc> References: <20260608133251.3128542-1-a@unstable.cc> MIME-Version: 1.0 X-Rspamd-Queue-Id: 4gYtJq6Nztz9thr X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Antonio Quartulli Netlink calls may access TCP global vars (i.e. when attaching a TCP socket), therefore we need to make sure the latters are initialized beforehand. For this reason move the global TCP initialization at the top of the module init function. Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-Headers-End: 1wWa6F-0004wS-38 Subject: [Openvpn-devel] [PATCH ovpn net v2 9/9] ovpn: ensure TCP vars are initialized first X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Antonio Quartulli Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1867435834549063503 X-GMAIL-MSGID: 1867435834549063503 From: Antonio Quartulli Netlink calls may access TCP global vars (i.e. when attaching a TCP socket), therefore we need to make sure the latters are initialized beforehand. For this reason move the global TCP initialization at the top of the module init function. Fixes: 11851cbd60ea ("ovpn: implement TCP transport") Signed-off-by: Antonio Quartulli --- drivers/net/ovpn/main.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/net/ovpn/main.c b/drivers/net/ovpn/main.c index a881510aaac0..0a88ca6bbf97 100644 --- a/drivers/net/ovpn/main.c +++ b/drivers/net/ovpn/main.c @@ -244,8 +244,14 @@ static struct rtnl_link_ops ovpn_link_ops = { static int __init ovpn_init(void) { - int err = rtnl_link_register(&ovpn_link_ops); + int err; + /* init TCP first so that any subsequent netlink operation + * is ensured to access initialized TCP global vars + */ + ovpn_tcp_init(); + + err = rtnl_link_register(&ovpn_link_ops); if (err) { pr_err("ovpn: can't register rtnl link ops: %d\n", err); return err; @@ -257,8 +263,6 @@ static int __init ovpn_init(void) goto unreg_rtnl; } - ovpn_tcp_init(); - return 0; unreg_rtnl: