From patchwork Thu Jul 2 10:06:59 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5065 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:1887:b0:869:83bc:8c48 with SMTP id r7csp442629max; Thu, 2 Jul 2026 03:07:24 -0700 (PDT) X-Forwarded-Encrypted: i=2; AFNElJ8WOJNYf3ytsm3lFyw3qZvKBpmxK0Y2+9cpp9IGWg89gU9MvToWersVshRDm9bY7pd4/qzm2Zd6Qmg=@openvpn.net X-Received: by 2002:a05:6820:81d3:b0:69d:c0a9:c1a5 with SMTP id 006d021491bc7-6a30996f82fmr2807002eaf.27.1782986844080; Thu, 02 Jul 2026 03:07:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1782986844; cv=none; d=google.com; s=arc-20260327; b=aChG4XhnIUq361YFsfo18QtFsPpQ2wL4G4VkEaOkUtjIKk95givhJhhh1ksiYkRed6 P5WKQLhe0M/IiNVG28kYGssgWuJCi9HsAdYwwvchti7J65bB9Oc2zSLjJGF3fGMLRSbd YPr86EpezkbrCJ3qTxmQJkf+V8ScsXkrjQfNvCYqeCNSJHuIwyIpwIAGXx+398UCG7yg arlsUqcAlCmlmMnS+9j3siGLzpuEy5cMu6NMQx7f9vhjx4XKLMsU3slnVoS3h8B/hkrt scUR0ZfKPVJt+lYc3JaJNeKOsHlF9MA4pbjYptawhFHQROPOpr/OgShpDDnWFA5aOSii iE0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=AOoRqp8c5JkU9AX4ATOW05Lz+pIPHUtf5/1F02Rk1dY=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=WzXTvFKOKThrqPOu5pSvbd4ti8Yl9QY8ym9qAw3UitYYjJi5MflTQYPEB9iL68/0LG MT+KvsD9mtkWRPd4J9AMDeSXmpXDbAm2HATOWRgG5cNAaWZyTwBn1FYFowJUcdFeBGwb z7RMyAsvKPDf6gXNixYucCsv/rRZ7+SliiiaHnptuj9emkAXw6LqO/tnSBVhwOhy6dT/ Boxn5hssgc1yykRiuOSt87ObjwllaaBWd7VojacQ5r87s/5Oxhc3/SoobxE0xReYbSjC ZO0gC+NZsDZPowtrPWbELacHC6aK+l0+i79yDnJf6/2MqsYgWcgKP473HBB4lsqQ7Z7c j6nw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=KZR5VMoI; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=C+8lt96H; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=icGsF9PJ; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 006d021491bc7-6a310424934si1941431eaf.85.2026.07.02.03.07.23 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Jul 2026 03:07:23 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=KZR5VMoI; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=C+8lt96H; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=icGsF9PJ; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AOoRqp8c5JkU9AX4ATOW05Lz+pIPHUtf5/1F02Rk1dY=; b=KZR5VMoI4p9lGRbePusAuOvFCc BvH/TyWxsklqam2qmX1IinOd8Cu3B8hAEZZtDcWgE2X3htgXPqTufs1m4eNfBZVWN/vebe/CxygkN js71wyZ4JvuAfNJ31EQgP0fd2u+Q79Ho4naC3od829e7yEtE5j9+DIbddWgcW/7t4Pp4=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wfEKJ-0007lx-A5; Thu, 02 Jul 2026 10:07:20 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wfEKG-0007lk-Ic for openvpn-devel@lists.sourceforge.net; Thu, 02 Jul 2026 10:07:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=oZmlQnOyZi3zaUwJ9q6uTYcVxzfqyaWQJ/klbpHfS5o=; b=C+8lt96Hl40gciEXfFu67oI9xD RNE7D+VlCDesyozGoO5xBZiFGxTbI4y/dCD9rxBV97tzIgI4DnbVsf+8WeIOw1qyxwjGmaUOsAA9H cLUy4DGYI/MoLruu0qf/KHhIat6mxoJX1MckrzcFM7iib7snd8RyBWydxTjJr8RVD2QA=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=oZmlQnOyZi3zaUwJ9q6uTYcVxzfqyaWQJ/klbpHfS5o=; b=icGsF9PJCqT85UEhZkN7GYLarH STLtcPRr6asSU/xDvIEAHujpwa17QxJcgIMCcRc8JQFzP9hkWTV7d0+EryCOOS7r5lcdMAY9jXAEE qDOl2DrzcRNQPkUw37PzE/sn0sVe9XyrDvbGVhjz7jWIzAjp8rOHrnmkZNtE2g3JsDR4=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wfEKC-00076N-HU for openvpn-devel@lists.sourceforge.net; Thu, 02 Jul 2026 10:07:18 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 662A75pS024730 for ; Thu, 2 Jul 2026 12:07:05 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 662A75ig024729 for openvpn-devel@lists.sourceforge.net; Thu, 2 Jul 2026 12:07:05 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Thu, 2 Jul 2026 12:06:59 +0200 Message-ID: <20260702100704.24692-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld Commit 01ee1693f960a696a613e7b83f9960002264a379 ("Ensure tls-crypt keys are not setup twice") removed the argument but did not delete it from the doxygen documentation, leading to warnings. Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1wfEKC-00076N-HU Subject: [Openvpn-devel] [PATCH v1] ssl_pkt: Fix doxygen warning about read_control_auth X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1869597212583415986 X-GMAIL-MSGID: 1869597212583415986 From: Frank Lichtenheld Commit 01ee1693f960a696a613e7b83f9960002264a379 ("Ensure tls-crypt keys are not setup twice") removed the argument but did not delete it from the doxygen documentation, leading to warnings. Change-Id: I20cc89a546b69aceadcd1630828de407d530d7c7 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1765 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1765 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpn/ssl_pkt.h b/src/openvpn/ssl_pkt.h index 640885e..82cb5b1 100644 --- a/src/openvpn/ssl_pkt.h +++ b/src/openvpn/ssl_pkt.h @@ -207,7 +207,6 @@ * @param ctx control channel security context * @param from incoming link socket address * @param opt tls options struct for the session - * @param initial_packet whether this is the initial packet for the connection * @return if the packet was successfully processed */ bool read_control_auth(struct buffer *buf, struct tls_wrap_ctx *ctx,