diff mbox series

[Openvpn-devel,v2] Remove --providers from --help output for Mbed TLS

Message ID 20260722163800.2474-1-gert@greenie.muc.de
State New
Headers
Series [Openvpn-devel,v2] Remove --providers from --help output for Mbed TLS |

Commit Message

Gert Doering July 22, 2026, 4:37 p.m. UTC 
  From: Max Fillinger <maximilian.fillinger@sentyron.com>

This option is OpenSSL-only. When used with Mbed TLS, it prints warnings
and does not do anything. With this change, the option is still parsed,
to ensure compatiblity of configurations, but it is removed from the
--help text.

Change-Id: I0f56ca69efae0ca376eb9eae064a893c8768188e
Signed-off-by: Max Fillinger <maximilian.fillinger@sentyron.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1799
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1799
This mail reflects revision 2 of this Change.

Acked-by according to Gerrit (reflected above):
Gert Doering <gert@greenie.muc.de>

Comments

Gert Doering July 22, 2026, 8:48 p.m. UTC | #1 
Documentation fixes are always welcome :-)
(though I'm not overly enthusiastic about new #ifdefs).

Your patch has been applied to the master and release/2.7 branch (docs).

commit 4b80a129999aceaeb429ebd703f618a51775d955 (master)
commit 339f6f17ce515687ecf8615fc5651c1d312871c8 (release/2.7)
Author: Max Fillinger
Date:   Wed Jul 22 18:37:55 2026 +0200

     Remove --providers from --help output for Mbed TLS

     Signed-off-by: Max Fillinger <maximilian.fillinger@sentyron.com>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1799
     Message-Id: <20260722163800.2474-1-gert@greenie.muc.de>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg37781.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering
diff mbox series

Patch

diff --git a/src/openvpn/options.c b/src/openvpn/options.c
index 87218d4..2424431 100644
--- a/src/openvpn/options.c
+++ b/src/openvpn/options.c
@@ -606,7 +606,9 @@ 
     "                : Use --show-tls to see a list of supported TLS ciphers (suites).\n"
     "--tls-cert-profile p : Set the allowed certificate crypto algorithm profile\n"
     "                  (default=legacy).\n"
+#ifndef ENABLE_CRYPTO_MBEDTLS
     "--providers l   : A list l of OpenSSL providers to load.\n"
+#endif
     "--tls-timeout n : Packet retransmit timeout on TLS control channel\n"
     "                  if no ACK from remote within n seconds (default=%d).\n"
     "--reneg-bytes n : Renegotiate data chan. key after n bytes sent and recvd.\n"