From patchwork Fri Jul 24 01:49:26 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qingfang Deng X-Patchwork-Id: 5125 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:6384:b0:87d:a69c:34be with SMTP id i4csp1112536mag; Thu, 23 Jul 2026 18:50:16 -0700 (PDT) X-Forwarded-Encrypted: i=2; AHgh+RpTI0PoAD7hnUZjYp5tg+tqa8TMG9R5cJi3xWr05xbHxzBBFqMfuoJQ5/VpfruejFb12CdGTc78+EI=@openvpn.net X-Received: by 2002:a05:6870:c083:b0:456:7fda:5dd4 with SMTP id 586e51a60fabf-457a4778b7dmr2243219fac.14.1784857816553; Thu, 23 Jul 2026 18:50:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1784857816; cv=none; d=google.com; s=arc-20260327; b=apDfxgI8H87HOfWtHmjPfCsRMCVh/hScliBO++230B2FBPUVOxTdBvkepy1zlSee68 MJuTG9pLHLnl745HknK+08dBeS4RBvPUv8Mv0/+J51YxUuF39lpMx9H3ER75eAOKftsf T5OFk9uO1coJH+wWsxxd1YnIZWAnDMUH8hNJItMfbCC62TKexY6Mo0MEvKNvC7PCskcX iCog8xZH63jRnZGER7njnv11lIyTBqfLDNrd1o1QSz1Itk2xGNCbQgUD29mlnMsVZfH6 +y7lRoWOabLUvN0jWYyNA8M9ebeUvc7ArfGX+p3KeIYKvz64ZgG/SaLybJqmrc98hu4P 1e8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:cc:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:date:to:from:dkim-signature:dkim-signature :dkim-signature:dkim-signature; bh=XZYt3GYxOULJXu4Rtc6oi7cxjQ+1zVMIPhXM8JC11WI=; fh=u7UzJ/hONCfQI9Qs6zPCSi5Cs4RoG6y2IW7vCahm/zo=; b=caLtKhTUlQjeuZ8WRky0X2JtOfdFDWljOGJc+OxZVXAL/7tLRcsg4PZWVJwxo0nkQL oUy6zaLzE0hkCBg/UnGW0U4XpwOG7hm6Mly0xkeo6qOiUKRAyBsH9EDfLm1D17GOmc+4 oWn3bphM1hH4TbB1TRbcMoKlXD9FHqrz8stxLk3nPgh6NeW7GbYIYsdUvvxetVr2zlQ5 W2251XJcfL1F5llvJmB2vSjaSo/UAGZ6fsG/RTxO4fFYOeAOQnFapuErOeZCfPJzotE0 df8oRKjLcpGHTG53IqhW/Jf5g3OAPoZ3604wFPkRQSYLusxIJpUK2ORWGwy96gy5xf8I EEbg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=YWM2W76x; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=m1r+2BVL; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=kNZ9twn+; dkim=neutral (body hash did not verify) header.i=@linux.dev header.s=key1 header.b=GxBxNr9s; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-457aa9a65b1si2711696fac.312.2026.07.23.18.50.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Jul 2026 18:50:16 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=YWM2W76x; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=m1r+2BVL; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=kNZ9twn+; dkim=neutral (body hash did not verify) header.i=@linux.dev header.s=key1 header.b=GxBxNr9s; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linux.dev DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:Message-ID:Date:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Owner; bh=XZYt3GYxOULJXu4Rtc6oi7cxjQ+1zVMIPhXM8JC11WI=; b=YWM2W76xPnU9jC4MNr+NBuWCNM oB7SU7NvR6HYYie0CM+XAHINde0Zf6H2+R9GnqFyJw6ZNwRokSaMya+7g2YW2o7xgihUOpGllSyi/ tRFMqeCqUAYp0I0UHa6FEMSGIeF0MkbtwkpNhylMJ2laeJluj01/o8aleuF25Rd4GszM=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wn53G-0006fD-4Q; Fri, 24 Jul 2026 01:50:11 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wn53E-0006cV-Fm for openvpn-devel@lists.sourceforge.net; Fri, 24 Jul 2026 01:50:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5c4OvNGaZtH3rIpGU3wmibiDmqCdeKwggxfAKQdCr9s=; b=m1r+2BVL69C/3nbSABomqM55dy Lx7rgOYD19rvn2NYA98KVlloQ7kpHQKjY3R+4MoD1lZjLJM+8x0fhBg3uinp61KVbb+kdkP6tIA0W A3T7xWpANZsP36X5dRz4rDAHVrxhHG5d8hC4s+qyB5/y+WamhWhZcT5KJOMxkUFsnGe0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=5c4OvNGaZtH3rIpGU3wmibiDmqCdeKwggxfAKQdCr9s=; b=k NZ9twn+gygoLb3n7EIMNNeTwcTehLheW7GNTs+SCIQCu/dPA1MSyku23+nE4/ILpEfwUoWnfel6wv mbVR0m4Uo4N/y97ih4g/Ggvave5IuTLYhpeRARYAoffienc9z9rWRc8lw4FtWt3gqRbURPhCIvcL+ DTW6UGYjSXEbWGeQ=; Received: from out-171.mta1.migadu.com ([95.215.58.171]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wn53A-0004ed-Ew for openvpn-devel@lists.sourceforge.net; Fri, 24 Jul 2026 01:50:09 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1784857801; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=5c4OvNGaZtH3rIpGU3wmibiDmqCdeKwggxfAKQdCr9s=; b=GxBxNr9sAmuE6LVrekGG+pw79IdExSIJKZ6r8eXhbgAyBcqtpWjR+adbLC62U8XUiEGTvt 2Itbtj2lSnTXEqHvDiLhQCGDdC2LuFAIipY1PFy9PfkdNGuFokSfuC94bHTidoPzTs3IBx 086wzQ12OxV5ZqtQCywYOrI+mpSbBns= From: Qingfang Deng To: openvpn-devel@lists.sourceforge.net, Antonio Quartulli Date: Fri, 24 Jul 2026 09:49:26 +0800 Message-ID: <20260724014926.102443-1-qingfang.deng@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: rcu_access_pointer() should only be used to test the value of a pointer, not to dereference it. As it's in a spin_lock_bh() critical section, use rcu_dereference_bh() instead, avoiding an extra rcu_re [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-Headers-End: 1wn53A-0004ed-Ew Subject: [Openvpn-devel] [PATCH ovpn-net v2] ovpn: fix incorrect use of rcu_access_pointer() X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Qingfang Deng Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1871559069863697199 X-GMAIL-MSGID: 1871559069863697199 rcu_access_pointer() should only be used to test the value of a pointer, not to dereference it. As it's in a spin_lock_bh() critical section, use rcu_dereference_bh() instead, avoiding an extra rcu_read_lock(). Fixes: f6226ae7a0cd ("ovpn: introduce the ovpn_socket object") Signed-off-by: Qingfang Deng --- v2: use rcu_dereference_bh() to make lockdep happy drivers/net/ovpn/peer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ovpn/peer.c b/drivers/net/ovpn/peer.c index a21d02ac715e..bb3d409b9f1c 100644 --- a/drivers/net/ovpn/peer.c +++ b/drivers/net/ovpn/peer.c @@ -1165,7 +1165,7 @@ static void ovpn_peer_release_p2p(struct ovpn_priv *ovpn, struct sock *sk, } if (sk) { - ovpn_sock = rcu_access_pointer(peer->sock); + ovpn_sock = rcu_dereference_bh(peer->sock); if (!ovpn_sock || ovpn_sock->sk != sk) { spin_unlock_bh(&ovpn->lock); return;