From patchwork Thu Aug 13 18:08:45 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5232 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:5508:b0:87d:ab56:3700 with SMTP id e8csp1222685mah; Thu, 13 Aug 2026 11:09:10 -0700 (PDT) X-Forwarded-Encrypted: i=2; AHgh+Rr8qCWicfSdUdgofEOuPu4Wli1YlBgdM2y+q/RCYq9AX3x3D/ofLpOr2zB5k+9h/z18OQ95DSO1moA=@openvpn.net X-Received: by 2002:a05:6830:6404:b0:7e9:3765:79c2 with SMTP id 46e09a7af769-7f3ca6d1f1cmr8126573a34.12.1786644550191; Thu, 13 Aug 2026 11:09:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1786644550; cv=none; d=google.com; s=arc-20260327; b=m4+g0znFOSeacEQ8XTO8bgiU5mzKemtMj5/Jdih+Qe8cuBXDcGCLdO6PdzlDEqP8xM wovkkovGvQ0MjPwn6koTEenHakEJAUmN1Uw5UxLKQQKYyvLArx+pwFDTsfCJ1+VCDjku xPHNZxnlVN3Fhxa4w87VX8HDv+t98ypPtMvWCZYTZ4ui21g+H8sTLntt0AfTc4XVnsEA 6BdvrZ1ZxwqCYOLIsyLcsnmNJ5+nt4VEltifGwdOIs/u0dWyzw4tBLrnm5MHYWf6RfeP yD6BAI7HH8WJJ7MvvWecMoU/jpt5f+YaZrU+g5NkjZSmS7VqtI32pn/2R6QQj049Empj Wd9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=nff5REdKlGgH+FhiBMShTdZrQGt+yhplx96wjVIXLvw=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=TSh9OMLYz0cVSeQd69yZT20hsCUIbcQTVIwUa9WvTJAO9E309Q/g3aQn/UIWSBQjVX wJdioMRJFYqWK57F1jCveDY8xIhoZUglEIiShZbcxRFkfqViVWj8m5JVbKsKl+I1U1Ww 6bqZd51YFgEbQ/2g3QAF0SwYcDTJeo9HtZtDTzcCMULaxtdeN/aHneplItNQWX27Qmbq i+xHQYblIsD622lHEKJAevU6nfCdAP9RB7M2rVmaJEkwLZHPXVzkXp0bCCoDTGPsHwQm dGU67Cf3hVRO1Ne2VyHPmY+N+LDcoRjrJcm4bItBo/OtDsjB1ZFbRttzosfrRO36XMyN Ko+A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=XlSmDDB+; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=al04kbdV; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=iYcKygA7; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 46e09a7af769-7f3c9ee6247si7250915a34.86.2026.08.13.11.09.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Aug 2026 11:09:10 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=XlSmDDB+; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=al04kbdV; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=iYcKygA7; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nff5REdKlGgH+FhiBMShTdZrQGt+yhplx96wjVIXLvw=; b=XlSmDDB+6kUt1tpXrDLpqUlTUY t0LGdddO0NaNQYw2qaEisQMRGJMZpfIzxfQZUPPMEfVdNSAIO/KkjXnooOZUdsB3gbYC0aFaUN/hq f4YzzE/2hcbw6JC2jVAwIZvwJqF898gi2NTRci6fEnKFfZu3g5loGOtDQq42dDdPsFuA=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wuZrW-0007sk-0u; Thu, 13 Aug 2026 18:09:06 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wuZrT-0007sU-UJ for openvpn-devel@lists.sourceforge.net; Thu, 13 Aug 2026 18:09:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=veZGtbfQeP38nfVcrYgiGclwgEdIknSIG9bhLfZIM/A=; b=al04kbdV3kUkSAtO/9WEs/hZl+ oZObd22Gk8DiY3W8hgGX7xqsSEdF14kOj47S1rdptr2AUKJxc2hk8UlWdDvqlFQNMVNpiks1gjoVr 6vySWM6mVg5tm4QIsOLAoGIV7bL/77LldXD/xD+8WOI+B121x38PzX2BcjuXpNN1kPMs=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=veZGtbfQeP38nfVcrYgiGclwgEdIknSIG9bhLfZIM/A=; b=iYcKygA7DsIZlG2SkAIOpvF2Mx CYXOKRqTQL6NssuDkP7lKL9aCZxFlSnEonufJF5vyH4EPjCmpQbz316v7+dC5jq8Mz5cvcxahoBRF sE3i4QsWYguN0KsUwFz41o0irP0/B09Z14LhmlFrs+FN4aCeABXS5yPY59l5m1eCrPLM=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wuZrW-0001X9-Cb for openvpn-devel@lists.sourceforge.net; Thu, 13 Aug 2026 18:09:04 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 67DI8uLO003226 for ; Thu, 13 Aug 2026 20:08:56 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 67DI8uPt003225 for openvpn-devel@lists.sourceforge.net; Thu, 13 Aug 2026 20:08:56 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Thu, 13 Aug 2026 20:08:45 +0200 Message-ID: <20260813180856.3208-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld It is not realistic that this produced big values and we already discard negative values. So just use whatever we get. Change-Id: Iac4af315c6d7798f09a27383fc0a755a874b9881 Signed-off-by: Frank Lichtenheld Acked-by: Razvan Cojocaru Gerrit URL: https://gerrit.openvpn.net/c/o [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1wuZrW-0001X9-Cb Subject: [Openvpn-devel] [PATCH v3] reliable: Avoid conversion warning in reliable_send_timeout X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1873432596141363297 X-GMAIL-MSGID: 1873432596141363297 From: Frank Lichtenheld It is not realistic that this produced big values and we already discard negative values. So just use whatever we get. Change-Id: Iac4af315c6d7798f09a27383fc0a755a874b9881 Signed-off-by: Frank Lichtenheld Acked-by: Razvan Cojocaru Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1480 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1480 This mail reflects revision 3 of this Change. Acked-by according to Gerrit (reflected above): Razvan Cojocaru diff --git a/src/openvpn/reliable.c b/src/openvpn/reliable.c index 52adacf..690e50d6 100644 --- a/src/openvpn/reliable.c +++ b/src/openvpn/reliable.c @@ -687,11 +687,6 @@ } } -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wconversion" -#endif - /* in how many seconds should we wake up to check for timeout */ /* if we return BIG_TIMEOUT, nothing to wait for */ interval_t @@ -713,7 +708,7 @@ } else { - ret = min_int(ret, e->next_try - local_now); + ret = min_int(ret, (int)(e->next_try - local_now)); } } } @@ -724,10 +719,6 @@ return ret; } -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic pop -#endif - /* * Enable an incoming buffer previously returned by a get function as active. */