diff mbox series

[Openvpn-devel,v1] Fix compiling with mbed TLS 3 and cmake

Message ID	20260815130008.19708-1-gert@greenie.muc.de
State	New
Headers	Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; From: Gert Doering <gert@greenie.muc.de> To: openvpn-devel@lists.sourceforge.net Date: Sat, 15 Aug 2026 14:59:38 +0200 Message-ID: <20260815130008.19708-1-gert@greenie.muc.de> In-Reply-To: <gerrit.1782744874000.I08281cb511dacb2a69ff4a9607c5daf09157337b@gerrit.openvpn.net> References: <gerrit.1782744874000.I08281cb511dacb2a69ff4a9607c5daf09157337b@gerrit.openvpn.net> MIME-Version: 1.0 preview: From: Arne Schwabe <arne@rfc2549.org> The crypto_mbedtls_legacy.c has been added to the Makefile.am files but was forgotten in the Cmake build system. Change-Id: I08281cb511dacb2a69ff4a9607c5daf09157337b Signed-off-by: Arne Schwabe <arne@rfc2549.org> Acked-by: Frank Lichtenheld <frank@lichtenheld.com> Gerrit URL: https://gerrit.openvpn.net/c/openvpn [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS Subject: [Openvpn-devel] [PATCH v1] Fix compiling with mbed TLS 3 and cmake Precedence: list Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox
Series	[Openvpn-devel,v1] Fix compiling with mbed TLS 3 and cmake \| [Openvpn-devel,v1] Fix compiling with mbed TLS 3 and cmake

Commit Message

Gert Doering Aug. 15, 2026, 12:59 p.m. UTC

  From: Arne Schwabe <arne@rfc2549.org>

The crypto_mbedtls_legacy.c has been added to the Makefile.am files
but was forgotten in the Cmake build system.

Change-Id: I08281cb511dacb2a69ff4a9607c5daf09157337b
Signed-off-by: Arne Schwabe <arne@rfc2549.org>
Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1757
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1757
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Frank Lichtenheld <frank@lichtenheld.com>

Comments

Gert Doering Aug. 15, 2026, 8:13 p.m. UTC | #1

We seem to miss having something that builds this particular combination
(GHA or Gerrit, with cmake) so it never actually failed - change makes
sense, of course.  Thanks Razvan for digging it up :-)

Tested via GHA build, which only does... tada... mbedTLS4...

Your patch has been applied to the master branch.

commit 4acebd72c1c6bc0a4a2ee2b4288c18214fead278
Author: Arne Schwabe
Date:   Sat Aug 15 14:59:38 2026 +0200

     Fix compiling with mbed TLS 3 and cmake

     Signed-off-by: Arne Schwabe <arne@rfc2549.org>
     Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1757
     Message-Id: <20260815130008.19708-1-gert@greenie.muc.de>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg38406.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

diff mbox series

Patch

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 4779d69..3f38ab9 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -443,6 +443,8 @@ 
     src/openvpn/crypto_openssl.h
     src/openvpn/crypto_mbedtls.c
     src/openvpn/crypto_mbedtls.h
+    src/openvpn/crypto_mbedtls_legacy.c
+    src/openvpn/crypto_mbedtls_legacy.h
     src/openvpn/cryptoapi.c
     src/openvpn/cryptoapi.h
     src/openvpn/dco.c
@@ -761,6 +763,7 @@ 
         src/openvpn/base64.c
         src/openvpn/crypto_epoch.c
         src/openvpn/crypto_mbedtls.c
+        src/openvpn/crypto_mbedtls_legacy.c
         src/openvpn/crypto_openssl.c
         src/openvpn/crypto.c
         src/openvpn/otime.c
@@ -773,6 +776,7 @@ 
 
     target_sources(test_crypto PRIVATE
         src/openvpn/crypto_mbedtls.c
+        src/openvpn/crypto_mbedtls_legacy.c
         src/openvpn/crypto_openssl.c
         src/openvpn/crypto_epoch.c
         src/openvpn/crypto.c
@@ -790,6 +794,7 @@ 
             src/openvpn/base64.c
             src/openvpn/crypto_epoch.c
             src/openvpn/crypto_mbedtls.c
+            src/openvpn/crypto_mbedtls_legacy.c
             src/openvpn/crypto_openssl.c
             src/openvpn/crypto.c
             src/openvpn/cryptoapi.c
@@ -825,6 +830,7 @@ 
     target_sources(test_ncp PRIVATE
         src/openvpn/crypto_epoch.c
         src/openvpn/crypto_mbedtls.c
+        src/openvpn/crypto_mbedtls_legacy.c
         src/openvpn/crypto_openssl.c
         src/openvpn/crypto.c
         src/openvpn/otime.c
@@ -853,6 +859,7 @@ 
         src/openvpn/base64.c
         src/openvpn/crypto_epoch.c
         src/openvpn/crypto_mbedtls.c
+        src/openvpn/crypto_mbedtls_legacy.c
         src/openvpn/crypto_openssl.c
         src/openvpn/crypto.c
         src/openvpn/env_set.c
@@ -927,6 +934,7 @@ 
             src/openvpn/networking_sitnl.c
             src/openvpn/crypto_epoch.c
             src/openvpn/crypto_mbedtls.c
+            src/openvpn/crypto_mbedtls_legacy.c
             src/openvpn/crypto_openssl.c
             src/openvpn/crypto.c
             src/openvpn/crypto_epoch.c
@@ -948,6 +956,7 @@ 
             src/openvpn/base64.c
             src/openvpn/crypto_epoch.c
             src/openvpn/crypto_mbedtls.c
+            src/openvpn/crypto_mbedtls_legacy.c
             src/openvpn/crypto_openssl.c
             src/openvpn/crypto.c
             src/openvpn/env_set.c