From patchwork Tue Aug 18 14:22:46 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5251 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:798a:b0:87d:ab56:3700 with SMTP id o10csp4563475maz; Tue, 18 Aug 2026 07:23:15 -0700 (PDT) X-Forwarded-Encrypted: i=2; AHgh+RqBT0oFHW4pQitvWjyS5EvvdfDs61zJE1c9iz84H+ji7pKpzP+lPIsIYIL32s3N4HYJ2QS45TpgshY=@openvpn.net X-Received: by 2002:a05:6820:4c07:b0:6a1:363d:bc42 with SMTP id 006d021491bc7-6b0d61bec3dmr29748895eaf.15.1787062995268; Tue, 18 Aug 2026 07:23:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1787062995; cv=none; d=google.com; s=arc-20260327; b=M28t1TwWYBrDx8flxJiuoM7Polg1keg9sDaG30Qf/A0bNKdQ7DSntW90MsA6ZYTbcT 3Mc6399fHItQx0zVU8peWl5ShD01k6Pwiif8UMv6vbapQE+tJ4i/wcpUfAAvfCuS5UzJ 9dY9jE4k89M5xeRbot0LISnJuny9YQGWfyR3OuB3cxPJhRfUy4g9wPBPKIw7ZhrBlMOW ZyIDbmt5Zhv3MxdV6cJLzjnLQx5kaoDn2xdW5Fklo2Bxb7O9YkaQTbnWeczqNNtkqwlA 2gORmQG4Hy8gsuLPxZQTEUhRH76XMZbRTs71LsQDROFRJVxmD+dbVckIA6Ew2WCMzSp5 4chg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=yC38FF+7ItIaQPJJ4xinNWGrjtW5B06jQiRrcET3MX0=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=UVJlmVEjwvuxj/Exu5NpNrCsmJ6kjq/EJ2LEYhmKEDuDPPSlKUQYBEvoFPKLeUtNjQ g05+G79sdbPPbWLTkm4W+F4THwaHhnjIVvLrz5yqbQFq9GLpr9KJtkON2NvKndeUSk3I l2GsMeXISZf2OmOBubLRABGXQPIK9FeDGh1IIqH4z7dDNOt2yaYaDsCiswGtUEEIGkvU R2BWj3q7uPVlphpHAuWVwiQQ+L7C1KE/bJse7xV8PPaC0+KzbOBZX6Qlm8dFnJHCIb0W mi5QKPdAwwYCrYbT8cLm7zKKAwFRMegrfVUxHLZX0Fv13dL9dSdJbkBzs1rLQ300svr8 h8bg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=N+8e62P+; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="D/o5UtpS"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=HjhjSzkt; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-45f22e34d42si5020977fac.240.2026.08.18.07.23.15 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Aug 2026 07:23:15 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=N+8e62P+; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="D/o5UtpS"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=HjhjSzkt; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yC38FF+7ItIaQPJJ4xinNWGrjtW5B06jQiRrcET3MX0=; b=N+8e62P+y9n8Q5kDRQ1vIwBZPS H27RNPkUBDeaxdeaOEMkvCpGqyx0ekiMAoncvenwdeSVEIStybVQS+5/qGvxx/G+5oQ2T4/Jbf7SG s4l2J+VXox6czKFi/yRlYZn0dfqEaf+gNnfoMAGdowv/7lKn4j+jkGwhKSKcmCuF5FGs=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wwKid-0007Cv-Cd; Tue, 18 Aug 2026 14:23:12 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wwKia-0007C7-Rr for openvpn-devel@lists.sourceforge.net; Tue, 18 Aug 2026 14:23:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=2A3Egs8K6eYSRn4b0lath2ENyWOtz8WGeVSL3f/RBDE=; b=D/o5UtpSNgA/EYpqXTUwhl0q8v w6+K0uO5dv53vFlLBGZy7JqQWD0A4LeqZ+YE7SNzbY5WdPJnxnsHFH0haNm8Q0lohx8Qnm+7bev4x 4hRirW71BB/5qDq9IJmOVTS6T+sUbIqpGM2gzNqGi0fq6oE0p9FX3FMJHFD0d6LFyupI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=2A3Egs8K6eYSRn4b0lath2ENyWOtz8WGeVSL3f/RBDE=; b=HjhjSzktWkBy8o2AvVcLcE321s DlePgHXhD4iTaLiHfm7Lz3h/yM2kLkLhR5n9lzlCRpnLxV4cX9AjfAEhVhCxqX+G5K8EgwS2YaQK6 lM0MiTwD7FDwmd4GJpeSP9viuASurepbJFkICFcTZBEjQutawZcce7JxwvGUR33NSGxw=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wwKiR-000624-B0 for openvpn-devel@lists.sourceforge.net; Tue, 18 Aug 2026 14:23:00 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 67IEMqvt027242 for ; Tue, 18 Aug 2026 16:22:52 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 67IEMqFT027241 for openvpn-devel@lists.sourceforge.net; Tue, 18 Aug 2026 16:22:52 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Tue, 18 Aug 2026 16:22:46 +0200 Message-ID: <20260818142252.27227-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld We can compare to '\0' without having to do casting. Change-Id: I450568c0307a6372506d115cb389d172472140d4 Signed-off-by: Frank Lichtenheld Acked-by: Razvan Cojocaru Gerrit URL: https://gerrit.openvpn.net/c/o [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1wwKiR-000624-B0 Subject: [Openvpn-devel] [PATCH v1] buffer: Remove some useless casts on BLAST returns X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1873871367426636233 X-GMAIL-MSGID: 1873871367426636233 From: Frank Lichtenheld We can compare to '\0' without having to do casting. Change-Id: I450568c0307a6372506d115cb389d172472140d4 Signed-off-by: Frank Lichtenheld Acked-by: Razvan Cojocaru Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1845 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1845 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Razvan Cojocaru diff --git a/src/openvpn/buffer.c b/src/openvpn/buffer.c index bf38c68..87d3094 100644 --- a/src/openvpn/buffer.c +++ b/src/openvpn/buffer.c @@ -500,7 +500,7 @@ void buf_null_terminate(struct buffer *buf) { - const char *last = (char *)BLAST(buf); + const uint8_t *last = BLAST(buf); if (last && *last == '\0') /* already terminated? */ { return; @@ -523,12 +523,12 @@ { while (true) { - const char *last = (char *)BLAST(buf); + const uint8_t *last = BLAST(buf); if (!last) { break; } - if (char_class((unsigned char)*last, CC_CRLF | CC_NULL)) + if (char_class(*last, CC_CRLF | CC_NULL)) { if (!buf_inc_len(buf, -1)) {