diff mbox series

[Openvpn-devel,v1] mroute: Remove unused functions

Message ID 20260824161743.2156-1-gert@greenie.muc.de
State New
Headers
Series [Openvpn-devel,v1] mroute: Remove unused functions |

Commit Message

Gert Doering Aug. 24, 2026, 4:17 p.m. UTC 
  From: Frank Lichtenheld <frank@lichtenheld.com>

Both of these have been unused since commit
1308ccec9f85418b088723bb870855c0a933311b
("Remove support for PF").
The first is ipv4 specific and very limited in scope.
The second is equivalent to just using CLEAR (at least
in actual usage).
So I think both can safely be removed.

Identified by cppcheck.

Change-Id: Iad13c3bf73dbe073e52ede504ced7fb2f6a9b71d
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1866
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1866
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Gert Doering <gert@greenie.muc.de>
diff mbox series

Patch

diff --git a/src/openvpn/mroute.h b/src/openvpn/mroute.h
index 639281b..9d61b22 100644
--- a/src/openvpn/mroute.h
+++ b/src/openvpn/mroute.h
@@ -249,24 +249,4 @@ 
     dest->v4.addr = htonl(src);
 }
 
-static inline in_addr_t
-in_addr_t_from_mroute_addr(const struct mroute_addr *addr)
-{
-    if ((addr->type & MR_ADDR_MASK) == MR_ADDR_IPV4 && addr->netbits == 0 && addr->len == 4)
-    {
-        return ntohl(addr->v4.addr);
-    }
-    else
-    {
-        return 0;
-    }
-}
-
-static inline void
-mroute_addr_reset(struct mroute_addr *ma)
-{
-    ma->len = 0;
-    ma->type = MR_ADDR_NONE;
-}
-
 #endif /* MROUTE_H */