diff mbox series

[Openvpn-devel,v2] route: Remove unused function route_list_vpn_gateway_needed

Message ID 20260826204139.28986-1-gert@greenie.muc.de
State New
Headers
Series [Openvpn-devel,v2] route: Remove unused function route_list_vpn_gateway_needed |

Commit Message

Gert Doering Aug. 26, 2026, 8:40 p.m. UTC 
  From: Frank Lichtenheld <frank@lichtenheld.com>

This function has not been used since commit
840799182c0769c8ac9d014d09a497563516fc0d from 2011.
So it is probably safe to assume it is not useful.

Identified by cppcheck.

Change-Id: I7217d87a0f133e0bbee7896984e668cd28db73bd
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Razvan Cojocaru <razvanc@mailbox.org>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1864
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1864
This mail reflects revision 2 of this Change.

Acked-by according to Gerrit (reflected above):
Razvan Cojocaru <razvanc@mailbox.org>

Comments

Gert Doering Aug. 28, 2026, 10:23 a.m. UTC | #1 
Another easy one, with no conflicts, and no questions on "will this
break functionality" and all this ;-)

Your patch has been applied to the master branch.

commit 5aa5a11d395b9b18b9d814724eddb564e28d7e9d
Author: Frank Lichtenheld
Date:   Wed Aug 26 22:40:47 2026 +0200

     route: Remove unused function route_list_vpn_gateway_needed

     Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
     Acked-by: Razvan Cojocaru <razvanc@mailbox.org>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1864
     Message-Id: <20260826204139.28986-1-gert@greenie.muc.de>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg38743.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering
diff mbox series

Patch

diff --git a/src/openvpn/route.h b/src/openvpn/route.h
index bae8659..0d33d36 100644
--- a/src/openvpn/route.h
+++ b/src/openvpn/route.h
@@ -407,19 +407,6 @@ 
     return mask;
 }
 
-static inline bool
-route_list_vpn_gateway_needed(const struct route_list *rl)
-{
-    if (!rl)
-    {
-        return false;
-    }
-    else
-    {
-        return !(rl->spec.flags & RTSA_REMOTE_ENDPOINT);
-    }
-}
-
 static inline int
 route_did_redirect_default_gateway(const struct route_list *rl)
 {