| Message ID | 20260826204139.28986-1-gert@greenie.muc.de |
|---|---|
| State | New |
| Headers |
Return-Path: <openvpn-devel-bounces@lists.sourceforge.net>
Delivered-To: patchwork@openvpn.net
Received: by 2002:a05:7000:4306:b0:87d:ab56:3700 with SMTP id q6csp7802889mae;
Wed, 26 Aug 2026 13:41:57 -0700 (PDT)
X-Forwarded-Encrypted: i=2;
AHgh+Rq1DbHsmomgzqp2lrin5uP9E3edmPw4lnlf4dhpbLDfufHdtUalfxLSErivSJrHDRx0FJdjLtripmE=@openvpn.net
X-Received: by 2002:a05:6820:7085:20b0:6b1:31f:b0b0 with SMTP id
006d021491bc7-6b1a037461cmr7367175eaf.6.1787776917123;
Wed, 26 Aug 2026 13:41:57 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1787776917; cv=none;
d=google.com; s=arc-20260327;
b=KZdMOh8OUljA5FoHSI8w6caWBIadJNKCwOoFjSyGuxhISq3kL83PK+YtQCqYgM2PQZ
+1FI0N8EKp5zJp92dFRQz1om+AroqNjtOopvNRCdVE8l/iv1jm8yqLzzZZ8ZsKBbKMEq
QU4IiOGKGmEXqlYBx/12htHBFhmUcIirpprD16qUjJemUsyZ/5MYoSWYKdX9bRv8UMEH
A6F3qGUKmcCr1pHWRGNgOZ3RUHs7WvwTpE9w1Vj299YqUlW+25qqVLj1YbV0bXSFhNlY
UFc3oilq9O/5M0nQ+AhdfOB6yJataSfjh9lP2bAG42QK1tbsvVl4s0yzfNLHnX/kJiF+
uL2A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20260327;
h=errors-to:content-transfer-encoding:list-subscribe:list-help
:list-post:list-archive:list-unsubscribe:list-id:precedence:subject
:mime-version:references:in-reply-to:message-id:date:to:from
:dkim-signature:dkim-signature:dkim-signature;
bh=4FRElYLe4F6qts5Yv7597XoMbBgDFMGNgbrXz64stII=;
fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=;
b=aJhmxs5nsxXv5JfgEtABvdygzQ951KcWKwzOFUTcYl7ENFXXQYStNqiNQ4j4uAtMrY
3w7QFN0EoicxBIg9FiPIGsMpuwCD3ySUyLeX6MfaxW51qlswF9J8n4wwZ8q93kQYkNHp
e5QsseHXvUhPcQ9TYc5vkxxERf6SK8GcPYokmERABLATlV9jMV1PkbrEyWLvfarLlmjW
ziBli3HqvEixpCUXJOuwUbkNaF62F4dZ089jGrzgcNJoCR5pYnckYEpjWqkHW5qmXNhd
i1+ACO3Mc1LGrvSMGeH9Y3RHRFMgS+lXvQo5MeA5iiDx72yiL9Rkd9DbwnVq+3a5rQTz
TETQ==;
dara=google.com
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@lists.sourceforge.net header.s=beta
header.b=dj0BT6ay;
dkim=neutral (body hash did not verify) header.i=@sourceforge.net
header.s=x header.b=Gxhqadct;
dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x
header.b=Pjo1mKhk;
spf=pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de
Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7])
by mx.google.com with ESMTPS id
46e09a7af769-7f4c85942e3si5079500a34.94.2026.08.26.13.41.56
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Wed, 26 Aug 2026 13:41:57 -0700 (PDT)
Received-SPF: pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) client-ip=216.105.38.7;
Authentication-Results: mx.google.com;
dkim=pass header.i=@lists.sourceforge.net header.s=beta
header.b=dj0BT6ay;
dkim=neutral (body hash did not verify) header.i=@sourceforge.net
header.s=x header.b=Gxhqadct;
dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x
header.b=Pjo1mKhk;
spf=pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:
List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:
Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender:
Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From:
Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;
bh=4FRElYLe4F6qts5Yv7597XoMbBgDFMGNgbrXz64stII=; b=dj0BT6aytuWVxrCRKM9s6XMjUl
ng9ZI5bMiIXY0nMcCiLRHh4LqL6KfdFXb8umbWr1O3Q16W+YkExes0nphlEOLetJsR6O1QfftYyFu
qCycfNrq0/Bi6JstAeUcf88Lm3cbW8jb+CzGkxI2Az9KFKcRyws0CbhJ+wNIuRlWRxdc=;
Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com)
by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95)
(envelope-from <openvpn-devel-bounces@lists.sourceforge.net>)
id 1wzKRT-00075D-0m;
Wed, 26 Aug 2026 20:41:51 +0000
Received: from [172.30.29.66] (helo=mx.sourceforge.net)
by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95)
(envelope-from <gert@blue4.greenie.muc.de>) id 1wzKRR-00074x-0d
for openvpn-devel@lists.sourceforge.net;
Wed, 26 Aug 2026 20:41:49 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References:
In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=dC87h3UdOhMZSDqVPbeakQoo+/MZAG4mwO7mxUY1nVQ=; b=GxhqadctzW/iWzmRmyMc/Ot/tA
RtIokDqxFLLetnj3bSO1TjEBOu0U92+Bp0LGzoKSrkLxp3If7PM+xcncA0iqvhypW7mMqGD5BQo+u
APddbF3remTBfk2PFb7LwM0JZf/V5TOnXwdi3z/nsINuhS5DiMi8xAyJrxWRUpQrKmas=;
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x
;
h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:
Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID:
Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
List-Post:List-Owner:List-Archive;
bh=dC87h3UdOhMZSDqVPbeakQoo+/MZAG4mwO7mxUY1nVQ=; b=Pjo1mKhkMuJfah3rPJqonTwBnJ
ks7zCLiCCmEb9MNuxHWCfiuikiP0sEUOmh5EG38gAYdwHE1DKJ/5SYkgSqs+vPUAL4STSXRqOPkPh
zjImTopIjTBqE5CHrhmPSQ5WuaHiHL1okqvAGpmcqLFp0U+hq7W8ytPsIueRxJQOiu/0=;
Received: from [193.149.48.129] (helo=blue.greenie.muc.de)
by sfi-mx-2.v28.lw.sourceforge.com with esmtps
(TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95)
id 1wzKRP-000160-Da for openvpn-devel@lists.sourceforge.net;
Wed, 26 Aug 2026 20:41:49 +0000
Received: from blue.greenie.muc.de (localhost [127.0.0.1])
by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 67QKfemk029133
for <openvpn-devel@lists.sourceforge.net>; Wed, 26 Aug 2026 22:41:40 +0200
Received: (from gert@localhost)
by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 67QKfear029132
for openvpn-devel@lists.sourceforge.net; Wed, 26 Aug 2026 22:41:40 +0200
From: Gert Doering <gert@greenie.muc.de>
To: openvpn-devel@lists.sourceforge.net
Date: Wed, 26 Aug 2026 22:40:47 +0200
Message-ID: <20260826204139.28986-1-gert@greenie.muc.de>
X-Mailer: git-send-email 2.53.0
In-Reply-To:
<gerrit.1787570563000.I7217d87a0f133e0bbee7896984e668cd28db73bd@gerrit.openvpn.net>
References:
<gerrit.1787570563000.I7217d87a0f133e0bbee7896984e668cd28db73bd@gerrit.openvpn.net>
MIME-Version: 1.0
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software,
running on the system "sfi-spamd-1.hosts.colo.sdot.me",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: From: Frank Lichtenheld <frank@lichtenheld.com> This
function
has not been used since commit 840799182c0769c8ac9d014d09a497563516fc0d from
2011. So it is probably safe to assume it is not useful. Identified by
cppcheck. Content analysis details: (1.3 points, 5.0 required)
pts rule name description
---- ----------------------
--------------------------------------------------
1.3 RDNS_NONE Delivered to internal network by a host with no rDNS
X-Headers-End: 1wzKRP-000160-Da
Subject: [Openvpn-devel] [PATCH v2] route: Remove unused function
route_list_vpn_gateway_needed
X-BeenThere: openvpn-devel@lists.sourceforge.net
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <openvpn-devel.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/options/openvpn-devel>,
<mailto:openvpn-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive:
<http://sourceforge.net/mailarchive/forum.php?forum_name=openvpn-devel>
List-Post: <mailto:openvpn-devel@lists.sourceforge.net>
List-Help: <mailto:openvpn-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/openvpn-devel>,
<mailto:openvpn-devel-request@lists.sourceforge.net?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: openvpn-devel-bounces@lists.sourceforge.net
X-getmail-retrieved-from-mailbox: Inbox
X-GMAIL-THRID: 1874619968653558967
X-GMAIL-MSGID: 1874619968653558967
|
| Series |
[Openvpn-devel,v2] route: Remove unused function route_list_vpn_gateway_needed
|
|
Commit Message
Gert Doering
Aug. 26, 2026, 8:40 p.m. UTC
From: Frank Lichtenheld <frank@lichtenheld.com> This function has not been used since commit 840799182c0769c8ac9d014d09a497563516fc0d from 2011. So it is probably safe to assume it is not useful. Identified by cppcheck. Change-Id: I7217d87a0f133e0bbee7896984e668cd28db73bd Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com> Acked-by: Razvan Cojocaru <razvanc@mailbox.org> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1864 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1864 This mail reflects revision 2 of this Change. Acked-by according to Gerrit (reflected above): Razvan Cojocaru <razvanc@mailbox.org>
diff --git a/src/openvpn/route.h b/src/openvpn/route.h index bae8659..0d33d36 100644 --- a/src/openvpn/route.h +++ b/src/openvpn/route.h @@ -407,19 +407,6 @@ return mask; } -static inline bool -route_list_vpn_gateway_needed(const struct route_list *rl) -{ - if (!rl) - { - return false; - } - else - { - return !(rl->spec.flags & RTSA_REMOTE_ENDPOINT); - } -} - static inline int route_did_redirect_default_gateway(const struct route_list *rl) {