From patchwork Wed Sep 23 13:07:56 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5405 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:546b:b0:8b3:6e77:b38b with SMTP id d11csp677104mas; Wed, 23 Sep 2026 06:08:17 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBz9TdDb2TFPxoQoOX2EIME9cR1wEcOLcVAThTPEtHcRFAnal2hsfuIxYpQoFwttAwwLQaw2GPJVnnM=@openvpn.net X-Received: by 2002:a05:6830:a90:b0:80b:6c70:94b9 with SMTP id 46e09a7af769-815f0678de5mr2607822a34.19.1790168896900; Wed, 23 Sep 2026 06:08:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1790168896; cv=none; d=google.com; s=arc-20260327; b=jbUVHnz/q/+4WwffKNgagII3emBkHPwwQ2sRIWqQsl0eZnz+gC4107rUR5bTeU67kI 0mFTm8E2vjxM5ZTg3sRQmEFhnGb+Ej4kPPQgfKLYZjhpDz6n75SmPREJZmbIU5I8yg0S DiMPL1Ls8htGWkCppV1CygSdH8M59uCEZNib4dQW18tGGVXUa/ICh5HcQtfWUU9ssOlp L7G6SFW9zIm3wnzS7phPTGtNmvvpNvtxRd9vIUZUACDA0zgjJ0t8BxqOs9x/xCxc9TOv w7xu0phCcPCfOoyk7cXByPX4eB8cPvUq49uSb6IqBfiy/9KFpCPqucl+WulO7B+LmW5j zGFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=jFdqI5BYyi+EYt06chEL+jswkbepcsgq2D6opFsGHy0=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=GbS+7sE1oU5+DRRrY9WvxY2e+oemUVhEumOO85zmnm8xhMbDWYs1iIbfY7KRZod8nY +qQwaLCPO4tACSmgvnLg4jkQ6Qr+Z3mVWl50tMpRqdlrekR0qHsvb5z82EG8/ws/m9rV yCgNqoP3yGgb9nzB1gVU7GxveIYnpGD2rJc76BU/UXTuudhbrqOGeERwtcjFjHRPYJYE KBMmeU0WirrE11G+9FhXZoxYk/VFzSr930hs1R4fexNsHYiTMI7Vf/3jE+MYgyN3l0Op Nvx/GDF70JmVnn8Oxnne9Lnd/0uOzhbr4A7fZqrju9RcB5LOJK+1DEMRLIWbsb2gRGF1 rFCQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=lDlbI3eh; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=S2CHm+Tx; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="S1zT0OK/"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 46e09a7af769-816068d65a0si4267582a34.120.2026.09.23.06.08.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Sep 2026 06:08:16 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=lDlbI3eh; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=S2CHm+Tx; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="S1zT0OK/"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jFdqI5BYyi+EYt06chEL+jswkbepcsgq2D6opFsGHy0=; b=lDlbI3ehFbgFa7eCOAE/soWcDe 2J0KpXtYI8TvnypnylnDOjd4YeE9oS4qVNLMbQklVbfZwnpKxikdjpEpxcIGyvdTzZMV9rR7egrL8 u4unvlZEfHb2sVZ+aJOPUCGOb4iG/br1eYzykBGhGhB8fr1eFeceslbEBapPlv6t8klY=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1x9Mho-0005SF-2Z; Wed, 23 Sep 2026 13:08:12 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1x9Mhm-0005S9-LS for openvpn-devel@lists.sourceforge.net; Wed, 23 Sep 2026 13:08:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=y6vGv1JsRzliRjXknLiQ1n7pztRUfRbXt/IekOiqVZo=; b=S2CHm+TxVsG8n2T2/nprSyV6Bf weOsCSGlLxYpi3pd3AbCw0NqKPn79lnD4t0qJzLBMhhf+X8TYU8KanJcSElMvZLuyNFIbFMtdGpw8 kIC/1UUhwMSETCavgDIqJodbb9sA5nuff+nKT99w7399c3ZhwPGBm4mLqr6LW64uUXFE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=y6vGv1JsRzliRjXknLiQ1n7pztRUfRbXt/IekOiqVZo=; b=S1zT0OK/2CsfB/eyaVkreMxR1r 46ct+0PRKRLSGf8rUL/6TBplxKWbAz7nuauXvDTCBB6yJjeRFVq2AMegKZuXmm4G3jIbWJbI8pc+4 G1aVHCr80DHx2NSNvznD+hGWCZyQRkrG2Va7CLFLHl3i582myxzHyEsP62NmY2nzf2ek=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1x9Mhl-0000DW-GY for openvpn-devel@lists.sourceforge.net; Wed, 23 Sep 2026 13:08:10 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 68ND82Zu016814 for ; Wed, 23 Sep 2026 15:08:02 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 68ND82DY016813 for openvpn-devel@lists.sourceforge.net; Wed, 23 Sep 2026 15:08:02 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Wed, 23 Sep 2026 15:07:56 +0200 Message-ID: <20260923130801.16802-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld mingw in Ubuntu 26.04 has issues with checking snprintf format strings against original MS implementation even though it uses the GCC implementation. Apply work-around that is good enough for code that is already gone in master. Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1x9Mhl-0000DW-GY Subject: [Openvpn-devel] [PATCH v1] proxy: Work-around spurious warning on mingw builds X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1877128141018566530 X-GMAIL-MSGID: 1877128141018566530 From: Frank Lichtenheld mingw in Ubuntu 26.04 has issues with checking snprintf format strings against original MS implementation even though it uses the GCC implementation. Apply work-around that is good enough for code that is already gone in master. Change-Id: If276bd4c5d07fcd26f6749f514f0257eab73249f Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1945 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to release/2.7. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1945 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Arne Schwabe diff --git a/src/openvpn/proxy.c b/src/openvpn/proxy.c index 7101d9f..857bf03 100644 --- a/src/openvpn/proxy.c +++ b/src/openvpn/proxy.c @@ -767,7 +767,9 @@ char get[80]; CLEAR(buf2); - snprintf(get, sizeof(get), "%%*s NTLM %%%zus", sizeof(buf2) - 1); + /* mingw checks calls to the builtin snprintf() with the + * ms_printf archetype, which does not know the 'z' modifier */ + snprintf(get, sizeof(get), "%%*s NTLM %%%us", (unsigned int)(sizeof(buf2) - 1)); nparms = sscanf(buf, get, buf2); /* check for "Proxy-Authenticate: NTLM TlRM..." */