From patchwork Wed Oct 7 17:21:18 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5444 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:32d1:b0:8d1:cccb:4552 with SMTP id y17csp575738mad; Wed, 7 Oct 2026 10:22:03 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBzJCcVQ7RqQB1zrWitbMFRBkBFMZt61G/YycbtIWyQf090qQ/QjgDn5PsQn4hOiFMXlR9viF86LkN4=@openvpn.net X-Received: by 2002:a05:6820:1612:b0:6da:3a3b:5266 with SMTP id 006d021491bc7-6e7a60b6ef7mr2868833eaf.41.1791393723615; Wed, 07 Oct 2026 10:22:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1791393723; cv=none; d=google.com; s=arc-20260327; b=q5VPPoJVZ2qGMi6TYeho+3DUJpHFx2Xd8g54VeNHTavf9kY3O1ocVDfGXcvL/C2LnJ c5RiMs7VNUadCg1tJUpL58ssgKSiMVdDvBNP8KzJoau5IF2eoteoMpL2uN4I19ODxN91 SnQ2D5ZEMM21Fu3NpWKJBBz7c+m6S2OtJxBaZn76Gl1mKcu0IQpGFRM02n0c/j9Toj8y H+Nrx2FP/T0DnVVkIH/CDF0t0HxHI0BhIyYWdx0BSr6PRtEmowAvNW3j3gi4yQvHYv7E loFd0RqvERKcRoLS0KOYtf3U+W2MbIGGSgqAK6T77nJPH7D1fePAILWdFmibv/DYt4M5 LhmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=Q8ctK5gFmBTTkaIQcOr0pNA20+XD3FyVRBG60EdT2As=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=GYj3xH2ZqnYY0SK07PR4ntJk5wxGu8M1Dp+CKxGVkZ5/Sm55f9tXKiZACNxmmW2CRX HqyCvrlJuc/thnPoX/Rf9JpuJ0ceDAo4ND3L5oTnQFDlSH04lGGPyJ+Ngj6d9ebZrKN8 DqWwQNBxX135oLwgXgmWJDhVl2grSFAz2b3BVFFoYJZKfKwHF4W4neDxoy+0J/wx0Vih Snhfdx/NzvEDbLKkWZcfRYDolezXZp1TOtf9zU6qtJ7Sx0QhpTPQWMxmIlBwaQ6kqMlh 0Qo1cLq3SyqBoCTzEgGqYQMJbpW1yKKeNipLMvOxtmoKXQrjq2LihEhZly9fqTLljRzQ xvUg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=UrWd8XbS; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=QM3v8qSs; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=BzwblsnJ; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-4a274c4ffa2si1734998fac.158.2026.10.07.10.22.03 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Oct 2026 10:22:03 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=UrWd8XbS; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=QM3v8qSs; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=BzwblsnJ; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Q8ctK5gFmBTTkaIQcOr0pNA20+XD3FyVRBG60EdT2As=; b=UrWd8XbSbwRf3LoiF2v+PqWBV/ v0PaDkcKOzZEeM8pPRHjsXu59uht+vmBt0/VlV6I87aTM9O6mcxPiqsr4xmQIIa0f7mgKM0SetPTl NjmAU5Ns1/jvL3KKFfREBP/tcF49o6Cawo2P+3lGy3fgnUwFIe46BruETXfcVR8uk2Xw=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1xEVL8-0001qg-Rq; Wed, 07 Oct 2026 17:22:00 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1xEVKr-0001qL-K3 for openvpn-devel@lists.sourceforge.net; Wed, 07 Oct 2026 17:21:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4znPwuYRwaDb6sz2jJwzfRJbAiPPJpRLvhEBkYzZlF8=; b=QM3v8qSsuU4L9Hlhj5Zr9+AG6e YpVjeYqzGPacJEoYUueQxZ7mNW910lOfkruBBPlBcm5oDRacixELYNuWS6oXyw3yDJ9qGS7B8pz+e hw6pl/QSU9wrUTKn06Kadm2hXR+y3USrXz2d/BKzFhfOPca9bo9cEdHjETeIhGwaJThQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=4znPwuYRwaDb6sz2jJwzfRJbAiPPJpRLvhEBkYzZlF8=; b=BzwblsnJRR78SdERVxonkxCXsD gsXDGRRR27O6eWtElyGTPvTMpqzKh1YtG+BTxYiDr1vPQ2TFnhc0tQgq8MQq03+vgkxkJUCr474yF sJlTdyk+TWpWCmHchiUHGiDiVrvBOvRdkdl42kLa2U6E0q9xeblTL/2F80ViaHjs30N8=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1xEVKe-0004iW-52 for openvpn-devel@lists.sourceforge.net; Wed, 07 Oct 2026 17:21:33 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 697HLPob023590 for ; Wed, 7 Oct 2026 19:21:25 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 697HLPig023589 for openvpn-devel@lists.sourceforge.net; Wed, 7 Oct 2026 19:21:25 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Wed, 7 Oct 2026 19:21:18 +0200 Message-ID: <20261007172125.23573-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld I reviewed all the occurrences of the two cppcheck errors constParameter and constParameterCallback. All of constParameterCallback occurences were bogus and I think in most cases they will be. So continue to ignore it completely but document that we considered it and it is not useful. Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1xEVKe-0004iW-52 Subject: [Openvpn-devel] [PATCH v5] cppcheck: Review suppressions for constParameter and constParameterCallback X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1878052108994165416 X-GMAIL-MSGID: 1878412465189452683 From: Frank Lichtenheld I reviewed all the occurrences of the two cppcheck errors constParameter and constParameterCallback. All of constParameterCallback occurences were bogus and I think in most cases they will be. So continue to ignore it completely but document that we considered it and it is not useful. All existing cases of constParameter were bogus, but there might be useful hits in the future so I only suppress the existing occurrences. Change-Id: I76c310f9e69276d4f21a4ad31a24490553d6d5c4 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1966 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1966 This mail reflects revision 5 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/dev-tools/cppcheck-suppressions.xml b/dev-tools/cppcheck-suppressions.xml index bd24c3b..33337cf 100644 --- a/dev-tools/cppcheck-suppressions.xml +++ b/dev-tools/cppcheck-suppressions.xml @@ -3,23 +3,20 @@ - constParameter - - - constParameterCallback - - unusedFunction usleepCalled - + missingIncludeSystem - nullPointerOutOfMemory @@ -27,9 +24,6 @@ nullPointerArithmeticOutOfMemory - getgrnamCalled @@ -62,6 +56,11 @@ badBitmaskCheck tests/unit_tests/openvpn/test_pkt.c + + + constParameterCallback + constParameterPointer @@ -74,6 +73,12 @@ src/openvpn/buffer.c buf + + + constParameter + src/openvpn/openvpn.c + wargv + constParameterPointer @@ -81,6 +86,10 @@ + constParameter + tests/unit_tests/openvpn*/test_* + + constParameterPointer tests/unit_tests/openvpn*/test_*