| Message ID | 20261015200214.32007-1-gert@greenie.muc.de |
|---|---|
| State | New |
| Headers |
Return-Path: <openvpn-devel-bounces@lists.sourceforge.net>
Delivered-To: patchwork@openvpn.net
Received: by 2002:a05:7001:a68f:b0:8d7:ebbe:b250 with SMTP id
wf15csp2296710mab;
Thu, 15 Oct 2026 13:02:31 -0700 (PDT)
X-Forwarded-Encrypted: i=2;
AKwUvBz/BvtI12IQ8sJTCWh/nfS34z9YxF5UotGIhe9g95GqJ3sXjND6+ut0DboPJfiWlpTzWWD5+ECvq/s=@openvpn.net
X-Received: by 2002:a4a:ec4a:0:b0:6dd:6d12:231a with SMTP id
006d021491bc7-6ef0fcaae7amr14750808eaf.71.1792094551638;
Thu, 15 Oct 2026 13:02:31 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1792094551; cv=none;
d=google.com; s=arc-20260327;
b=bBUJnxr+h6Wpq0gE6idb5wrOTEiuBBq/Mr3iIXkbR7sQUI8MjxQZRQwXL9AGPfdT86
+UcUXcAvMvp5DVsUfbtIaZ3uh1V7S5slX3MOIwKKy+qIDjS0GXNypQt5KYP1eKYtqQPZ
jN2ZNlupP5H6jmoUqHu84k1bG6CTHzrXpE/gQidpd7L3YyzdFD1Jcks2Dq1rdw+W8ILD
F9YJElIajwPpbgI3tuL2zUKLnVn/POu2oMYJPCBku7zAIdLjWGPuL9YbwXxEEzqJnMLw
y2fOoMix9GC8eNbiJ9yIUnrYd9n5Ts5PmK2ByAlVnMKfPZvaXXZULTdwoAqnu8jWKXPd
x1EA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20260327;
h=errors-to:content-transfer-encoding:list-subscribe:list-help
:list-post:list-archive:list-unsubscribe:list-id:precedence:subject
:mime-version:references:in-reply-to:message-id:date:to:from
:dkim-signature:dkim-signature:dkim-signature;
bh=Iitf0LcXWEqmNiF+WH8K+ednQI5xq+U6i2Fz4Z9s2dE=;
fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=;
b=G8UOoVbyTGkfaZzuVs/J+xF9zl2yTUa4OX1jhz1lVE1Hu+9EXF54eHX2jkry7u9omN
Ikn3UrJdvwZUjrER43DT6kr3DPVgruOhLGtOOLCvJI+GFjzVigM3QorY1mBrNRvP3THg
1AaZFO3Hc1QZvJ07cyP/q3ltISdz3fsL3pgZKAJhamd6vWunfwAlbgI6fBo/32ckBaMa
MzK/tAUKPHTIImxo5eq8ja1XylrHhHRa/1HVO5qb7eec1y5zHKsfgEHUfrMvnCHur0ej
HnIx/ESxP8HoChsSOviNJQbK9oiJMrcvpihmX/FQvPgKs+ksbADwkgSu4kVWo2/74a/n
kSNQ==;
dara=google.com
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@lists.sourceforge.net header.s=beta
header.b=liaPwmfu;
dkim=neutral (body hash did not verify) header.i=@sourceforge.net
header.s=x header.b=IZZFXrXF;
dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x
header.b=UT18o4nv;
spf=pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de
Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7])
by mx.google.com with ESMTPS id
586e51a60fabf-4a6dfd6f08csi10811848fac.278.2026.10.15.13.02.30
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Thu, 15 Oct 2026 13:02:31 -0700 (PDT)
Received-SPF: pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) client-ip=216.105.38.7;
Authentication-Results: mx.google.com;
dkim=pass header.i=@lists.sourceforge.net header.s=beta
header.b=liaPwmfu;
dkim=neutral (body hash did not verify) header.i=@sourceforge.net
header.s=x header.b=IZZFXrXF;
dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x
header.b=UT18o4nv;
spf=pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:
List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:
Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender:
Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From:
Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;
bh=Iitf0LcXWEqmNiF+WH8K+ednQI5xq+U6i2Fz4Z9s2dE=; b=liaPwmfu62FS1/goYIRwpdJN8N
jfFZTbjJl5WGvAMYX/+zoXlSpScU2E31T3giJnWPXLAAxEJZpdY8mpDugZ7UWVa2lkNQrO8Kr3hUK
T2FwezV+8qQjElbZfcRtwGc1Fb28XO7dtEQ+IEajZ68xRqao7Gh1jZ1dg3Jgt9FaXK/k=;
Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com)
by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95)
(envelope-from <openvpn-devel-bounces@lists.sourceforge.net>)
id 1xHRej-0006Wh-1G;
Thu, 15 Oct 2026 20:02:25 +0000
Received: from [172.30.29.66] (helo=mx.sourceforge.net)
by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95)
(envelope-from <gert@blue4.greenie.muc.de>) id 1xHReh-0006WZ-78
for openvpn-devel@lists.sourceforge.net;
Thu, 15 Oct 2026 20:02:23 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References:
In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=XRS9S3h58rwDblC3Zarnh3OmHr6io+VEymuRbvAQY5g=; b=IZZFXrXFePWanWu8yGKuYaS52S
mtQyS1K6czwRnl8OUJvCXXTM9Z6GnBztqbILx63Upexj+SZcW2iGmXhoCazaXsTSM6lXdgSyRnI8A
LVGlqX09TK20A5h42qbEQjZOD2IlqUwK0cGe9lp4KMAY/ZOFcbGQd+jbTAs2IB2v0VJA=;
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x
;
h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:
Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID:
Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
List-Post:List-Owner:List-Archive;
bh=XRS9S3h58rwDblC3Zarnh3OmHr6io+VEymuRbvAQY5g=; b=UT18o4nv+n2cqG21nxhu0F61ho
We8Iv0mtuICyhPxjK6xDSIzY1HvN6+qbS3DcwzQnV9H6ZLuXYXqQ34oFel8nSNFLqQQU6ZVbX540d
ww0jJ/s5vcGM06ZowXEEsb7AXg50ZWS2GF2roVeJA7sDFCJsDya6M2Cvm1r8xpriAgfw=;
Received: from [193.149.48.129] (helo=blue.greenie.muc.de)
by sfi-mx-1.v28.lw.sourceforge.com with esmtps
(TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95)
id 1xHRef-0001dw-TP for openvpn-devel@lists.sourceforge.net;
Thu, 15 Oct 2026 20:02:23 +0000
Received: from blue.greenie.muc.de (localhost [127.0.0.1])
by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 69FK2FKN032019
for <openvpn-devel@lists.sourceforge.net>; Thu, 15 Oct 2026 22:02:15 +0200
Received: (from gert@localhost)
by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 69FK2EDs032018
for openvpn-devel@lists.sourceforge.net; Thu, 15 Oct 2026 22:02:14 +0200
From: Gert Doering <gert@greenie.muc.de>
To: openvpn-devel@lists.sourceforge.net
Date: Thu, 15 Oct 2026 22:02:08 +0200
Message-ID: <20261015200214.32007-1-gert@greenie.muc.de>
X-Mailer: git-send-email 2.55.0
In-Reply-To:
<gerrit.1792079013000.I9a3598382ecf928aa81f027b55352175ad93165c@gerrit.openvpn.net>
References:
<gerrit.1792079013000.I9a3598382ecf928aa81f027b55352175ad93165c@gerrit.openvpn.net>
MIME-Version: 1.0
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software,
running on the system "sfi-spamd-2.hosts.colo.sdot.me",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: commit 571caa34e2f added the "const" to the function
declaration
but for whatever reason the necessary change in the prototype was lost, so
"make check" failsed to compile the siphash parts of crypto_ [...]
Content analysis details: (1.3 points, 5.0 required)
pts rule name description
---- ----------------------
--------------------------------------------------
1.3 RDNS_NONE Delivered to internal network by a host with no rDNS
X-Headers-End: 1xHRef-0001dw-TP
Subject: [Openvpn-devel] [PATCH v1] repair const mismatch in
siphash_openssl_available() prototype
X-BeenThere: openvpn-devel@lists.sourceforge.net
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <openvpn-devel.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/options/openvpn-devel>,
<mailto:openvpn-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive:
<http://sourceforge.net/mailarchive/forum.php?forum_name=openvpn-devel>
List-Post: <mailto:openvpn-devel@lists.sourceforge.net>
List-Help: <mailto:openvpn-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/openvpn-devel>,
<mailto:openvpn-devel-request@lists.sourceforge.net?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: openvpn-devel-bounces@lists.sourceforge.net
X-getmail-retrieved-from-mailbox: Inbox
X-GMAIL-THRID: 1879147336732479968
X-GMAIL-MSGID: 1879147336732479968
|
| Series |
[Openvpn-devel,v1] repair const mismatch in siphash_openssl_available() prototype
|
|
Commit Message
Gert Doering
Oct. 15, 2026, 8:02 p.m. UTC
commit 571caa34e2f added the "const" to the function declaration but for whatever reason the necessary change in the prototype was lost, so "make check" failsed to compile the siphash parts of crypto_testdriver. Fix. Change-Id: I9a3598382ecf928aa81f027b55352175ad93165c Signed-off-by: Gert Doering <gert@greenie.muc.de> Acked-by: Arne Schwabe <arne-openvpn@rfc2549.org> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2000 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2000 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Arne Schwabe <arne-openvpn@rfc2549.org>
diff --git a/tests/unit_tests/openvpn/siphash_openssl.h b/tests/unit_tests/openvpn/siphash_openssl.h index 49c6a9d..a44457e 100644 --- a/tests/unit_tests/openvpn/siphash_openssl.h +++ b/tests/unit_tests/openvpn/siphash_openssl.h @@ -60,5 +60,5 @@ * */ bool -siphash_openssl_available(void *sip_context); +siphash_openssl_available(const void *sip_context); #endif /* ifndef SIPHASH_OPENSSL_H */