[Openvpn-devel,v1] crypto_openssl: Avoid conversion warning in hmac_ctx_size (1.1.1 variant)

Message ID 20261018154358.23797-1-gert@greenie.muc.de
State New
Headers
Series [Openvpn-devel,v1] crypto_openssl: Avoid conversion warning in hmac_ctx_size (1.1.1 variant) |

Commit Message

Gert Doering Oct. 18, 2026, 3:43 p.m. UTC
  From: Frank Lichtenheld <frank@lichtenheld.com>

We already have a similar conversion in hmac_ctx_size 3.0
variant.

Change-Id: I7c54aba5ce771fc4a10e4efde7d14721cbcd7bc1
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Razvan Cojocaru <razvanc@mailbox.org>
Acked-by: Gert Doering <gert@greenie.muc.de>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2006
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2006
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Razvan Cojocaru <razvanc@mailbox.org>
Gert Doering <gert@greenie.muc.de>
  

Patch

diff --git a/src/openvpn/crypto_openssl.c b/src/openvpn/crypto_openssl.c
index 29c5fa6..e6abd8f 100644
--- a/src/openvpn/crypto_openssl.c
+++ b/src/openvpn/crypto_openssl.c
@@ -1172,21 +1172,12 @@ 
     HMAC_CTX_reset(ctx);
 }
 
-#if defined(__GNUC__) || defined(__clang__)
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wconversion"
-#endif
-
 int
 hmac_ctx_size(HMAC_CTX *ctx)
 {
-    return HMAC_size(ctx);
+    return (int)HMAC_size(ctx);
 }
 
-#if defined(__GNUC__) || defined(__clang__)
-#pragma GCC diagnostic pop
-#endif
-
 void
 hmac_ctx_reset(HMAC_CTX *ctx)
 {