diff mbox series

[Openvpn-devel,v1] ssl_verify_mbedtls: Avoid conversion warning in x509_get_fingerprint

Message ID 20261018154604.24008-1-gert@greenie.muc.de
State New
Headers
Series [Openvpn-devel,v1] ssl_verify_mbedtls: Avoid conversion warning in x509_get_fingerprint |

Commit Message

Gert Doering Oct. 18, 2026, 3:45 p.m. UTC 
  From: Frank Lichtenheld <frank@lichtenheld.com>

We already convert mbedtls_md_get_size to int in other
places, so just use that here as well.

Change-Id: Iae70a03c2bcc502f62133abcbfd1c92528e65d69
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Razvan Cojocaru <razvanc@mailbox.org>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2007
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2007
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Razvan Cojocaru <razvanc@mailbox.org>
diff mbox series

Patch

diff --git a/src/openvpn/ssl_verify_mbedtls.c b/src/openvpn/ssl_verify_mbedtls.c
index b9a36a6..6680ccc 100644
--- a/src/openvpn/ssl_verify_mbedtls.c
+++ b/src/openvpn/ssl_verify_mbedtls.c
@@ -542,25 +542,16 @@ 
     return FAILURE;
 }
 
-#if defined(__GNUC__) || defined(__clang__)
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wconversion"
-#endif
-
 static struct buffer
 x509_get_fingerprint(const mbedtls_md_info_t *md_info, mbedtls_x509_crt *cert, struct gc_arena *gc)
 {
     const size_t md_size = mbedtls_md_get_size(md_info);
     struct buffer fingerprint = alloc_buf_gc(md_size, gc);
     mbedtls_md(md_info, cert->raw.p, cert->raw.len, BPTR(&fingerprint));
-    ASSERT(buf_inc_len(&fingerprint, md_size));
+    ASSERT(buf_inc_len(&fingerprint, (int)md_size));
     return fingerprint;
 }
 
-#if defined(__GNUC__) || defined(__clang__)
-#pragma GCC diagnostic pop
-#endif
-
 struct buffer
 x509_get_sha1_fingerprint(mbedtls_x509_crt *cert, struct gc_arena *gc)
 {