From patchwork Tue Oct 20 13:17:04 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5492 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:848c:b0:8dc:5c83:a4ec with SMTP id z12csp2715916max; Tue, 20 Oct 2026 06:17:36 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBwEexqBXAQPX7XvnXYkqSQ0NDq56VpAB3R5OAQ0nf4q6jxRuJWBukp0ilmtnfnT+496zQuHNxfiuVo=@openvpn.net X-Received: by 2002:a05:6820:1ca7:b0:6dd:5306:d1a1 with SMTP id 006d021491bc7-70352297e25mr8090735eaf.3.1792502256576; Tue, 20 Oct 2026 06:17:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1792502256; cv=none; d=google.com; s=arc-20260327; b=kK40FJRQg/lteQK61shg++E53u3rOQx3w+58ewtCzY3NJWXYxN9ZEyzspNCUbtDrB0 o7JADG+noWohnoryvRt6VwdAh8k/7LvIlm+zVdpPlbQ24iwwfqj9izHnughCabRQRBpR 1iZ0egxPX6p5hufS5z6CdxD68Deyc7z3TJXwZ13O3l3qni9867Bm8e6MdXr+jzneFv2+ 9JQbgF/2fluYXY65uLtqmNXM2wG7sdob5FDnxE63x7pGkj9hj7LD7lr73Oy6/2AKdpJI Q69cpmPJuCHuTyeDoIt9p4sm1fNuzAyDNwsOwGFQQh6mX9tOmtySQG+sEBHmq4xutunl Keyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=tzJQyNySTg9D7N6gW1jvvKT/C4QjJ74+HC4ebMUkY8g=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=sOp3cJ0tbeQfMpb/7ynS0MRIv2C3Rq7n5ce5LDWM4EklT2mNeNe1k6dTWwxUd5kYdo BzHKVEmjZ+D3qB2RhuNumfWlO1tgFWPh6K2cMWV0TtBlMKG5r4EpkwiWwl+SC2NycsFb 6oAQCUSekdCC9DMWgbjK0JN/wKnH9qRb7pUoP5wO+XTE6hjvmnwmDA0kybxsQjDe75QC EVMNwo4bspXijNPabVpcJBHXauBMHsdpQnWjq67gEIm4U9/LV0qAX1+OzKtJs/aStgYV Qm/tU+x0BzWHNApWwnY8XxneIyhziS+RnmncMTAEZfsFJ5OwDeoWFhoqpXedJcN7zIx2 NXvA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=iiKuQxuf; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=BKhOQwXj; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=mEjl5pWS; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 006d021491bc7-7018ef047ffsi17384737eaf.30.2026.10.20.06.17.35 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Oct 2026 06:17:36 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=iiKuQxuf; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=BKhOQwXj; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=mEjl5pWS; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tzJQyNySTg9D7N6gW1jvvKT/C4QjJ74+HC4ebMUkY8g=; b=iiKuQxufcvW1XyJ4AJKjeoZ1t4 0DtQ3OwxZq176WPTbOqWy7sXlGWo8sVPJV46yyxo83ZTjKDX+6hcfvjtdcQhX8JwHkWag7vu61dHJ tmSKmmz8/dgtSr+XBKJlwaoLzj+JsfHIii2WUDFmuBRa01DidOUzBb/NoE81NMMpvEOI=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1xJ9iU-0008I0-EY; Tue, 20 Oct 2026 13:17:23 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1xJ9iS-0008Hr-Or for openvpn-devel@lists.sourceforge.net; Tue, 20 Oct 2026 13:17:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=2oT1IbWF3qddHaq1KeMxNT6S9pjHL2HokAkSxongUgs=; b=BKhOQwXjU2hmug+I6qOf/2Nc/s GDwaRIc+g00/rHeQ7jdusKGC8BS6cNSNKIT/1dK5Bo6aobbYQsikKc4q99qCw2qXEbfKADNSxjaA6 awYE9Hr851kKquxC0WWESrD1b5zJQcTxinXq43nYjLSSghIDm2SttcTwA4oCzGS/GULo=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=2oT1IbWF3qddHaq1KeMxNT6S9pjHL2HokAkSxongUgs=; b=mEjl5pWS0nOgnVFAKmJICmdX5s hQdORN5dJIUJS2sDO4nCLl4+iXm6QhSUZbfum9IGyBu/08YO3UuYsk5UXUdgT/P1F0S2PqG0vz6rE TryY+yl8BFN6H4uWP/2eRaQDh+xYUED3J1i3Z30nkfimOM1u5hEMtN0Xnez/djiHWjWM=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1xJ9iP-0004t2-2r for openvpn-devel@lists.sourceforge.net; Tue, 20 Oct 2026 13:17:21 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 69KDHAaX024594 for ; Tue, 20 Oct 2026 15:17:10 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 69KDHAkp024593 for openvpn-devel@lists.sourceforge.net; Tue, 20 Oct 2026 15:17:10 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Tue, 20 Oct 2026 15:17:04 +0200 Message-ID: <20261020131709.24574-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld I found out due to an unrelated problem that the comment is wrong. So let's fix it before it confuses the next person. Change-Id: Ib99618742929fd96562884d071f3bedc5ca309e4 Signed-off-by: Frank Lichtenheld Acked-by: Razvan Cojocaru Gerrit URL: https://gerrit.openvpn.net/c/o [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1xJ9iP-0004t2-2r Subject: [Openvpn-devel] [PATCH v1] test_pkt: Correct comment about which systems use ushort sin_family X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1879574845868258272 X-GMAIL-MSGID: 1879574845868258272 From: Frank Lichtenheld I found out due to an unrelated problem that the comment is wrong. So let's fix it before it confuses the next person. Change-Id: Ib99618742929fd96562884d071f3bedc5ca309e4 Signed-off-by: Frank Lichtenheld Acked-by: Razvan Cojocaru Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2025 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2025 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Razvan Cojocaru diff --git a/tests/unit_tests/openvpn/test_pkt.c b/tests/unit_tests/openvpn/test_pkt.c index 51c73d8..fbbb40f 100644 --- a/tests/unit_tests/openvpn/test_pkt.c +++ b/tests/unit_tests/openvpn/test_pkt.c @@ -579,13 +579,14 @@ struct session_id expected_server_id = { { 0xec, 0xa3, 0xd5, 0xcc, 0xb4, 0x7c, 0xa1, 0xee } }; /* We have to deal with different structs here annoyingly */ - /* Linux has an unsigned short int as family_t and this is field is always + /* Some systems have an unsigned short int as family_t and the field is always * stored in host endianness even though the rest of the struct isn't..., - * so Linux little endian differs from all BSD and Linux big endian */ + * This affects at least Linux, Windows, and OpenIndiana. + */ if (sizeof(addr.addr.in4.sin_family) == sizeof(unsigned short int) && ntohs(AF_INET) != AF_INET) { - struct session_id linuxle = { { 0x70, 0x04, 0x8c, 0x0f, 0xfe, 0x30, 0x85, 0x12 } }; - expected_server_id = linuxle; + struct session_id short_le = { { 0x70, 0x04, 0x8c, 0x0f, 0xfe, 0x30, 0x85, 0x12 } }; + expected_server_id = short_le; } assert_memory_equal(expected_server_id.id, server_id.id, SID_SIZE);