[Openvpn-devel,v1] test_provider: Fix compiler warning with clang 23

Message ID 20261029143143.19636-1-gert@greenie.muc.de
State New
Headers
Series [Openvpn-devel,v1] test_provider: Fix compiler warning with clang 23 |

Commit Message

Gert Doering Oct. 29, 2026, 2:31 p.m. UTC
  From: Frank Lichtenheld <frank@lichtenheld.com>

With --disable-management it complains
"variable 'mgmt_callback_called' set but not used
[-Werror,-Wunused-but-set-global]".

Change-Id: If33596abef4e97aa9b58f12cd866a5cded17fd4f
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Razvan Cojocaru <razvanc@mailbox.org>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2070
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2070
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Razvan Cojocaru <razvanc@mailbox.org>
  

Patch

diff --git a/tests/unit_tests/openvpn/test_provider.c b/tests/unit_tests/openvpn/test_provider.c
index e5562ee..5d31da3 100644
--- a/tests/unit_tests/openvpn/test_provider.c
+++ b/tests/unit_tests/openvpn/test_provider.c
@@ -42,7 +42,9 @@ 
 #include "test_common.h"
 
 struct management *management; /* global */
+#ifdef ENABLE_MANAGEMENT
 static int mgmt_callback_called;
+#endif
 
 #ifndef _countof
 #define _countof(x) sizeof((x)) / sizeof(*(x))
@@ -156,8 +158,9 @@ 
     char *out = NULL;
 
     /* indicate entry to the callback */
+#ifdef ENABLE_MANAGEMENT
     mgmt_callback_called = 1;
-
+#endif
     const char *expected_tbs = test_digest_b64;
     if (strstr(algorithm, "data=message"))
     {