From patchwork Mon Nov 2 14:19:55 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5554 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:6022:3119:b0:118:2077:975e with SMTP id e25csp5473133laa; Mon, 2 Nov 2026 06:20:35 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvBwoVpV2807TN5hSbCsMLrGdHepywAGFntH2AzOAXGpwCBr5FAOUijzbkJxNX8xysDe3v6H/1y13Ock=@openvpn.net X-Received: by 2002:a05:7022:b053:10b0:190:da74:2c89 with SMTP id a92af1059eb24-1ac5bda4447mr16572697c88.21.1793629234805; Mon, 02 Nov 2026 06:20:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793629234; cv=none; d=google.com; s=arc-20260327; b=V4ehWhVeFKuflA6kbOWSNbD93rDb/+ocSPydtmfbO+tRZW2McfovfFlBckawtmYjIx 2VUSLCJlKE/vUmgQKCCrxE6USRdzLXqEX+gAsdEtXENtu6EqGosXSKLiFdRMTQ8D58j9 vsg9ROI8juSYyvAh6nz35L0iJfDXQuWb5JSFEmMxWj0YnWDFwvEzb9ouYy70oZP94RwS 1YEa2gMkl0Ii6i+eaQYkq2d8bQxHC5fvnJRnaKmz0fa8LLOD+LZapY+0Rx/muZom+pgT 3ci7Xtbs94jZS41T4wL84ThDbIOEPjNXBN9gLNSs6sKmzEM8ghof6Ne/VNQ9yUYTbwtP gfSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=FWPA3c7Qr+ZO+ygckGz7mERhytcmt6h5BgPcydd4L7M=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=IBXyGIoGKmvTtyvLl0o0pWu5LUI3yw8xizCaR5NbGB4KpFGYbpYg/e6R6cmzR9Uz4G 0vcA8iRffkM8z3Ys8d6rOhOy8uWzFIQWAtC0zFKR1T4pUI2BHIHCZBovaRevfuJ3hwGN h/UpIK43F5KOxEAvjZp4UejHW/6+iHOX0+K7Q0HQMoVJzhGMRObHuzWGCb278+0u6ewU 55gpxSvbpdUH0VV9WTNBi31ygHPW6sQnPdY4d0cWk6raK50kdBg8XVsN9r4O2y0pf8fV k3v3UGIWWc1yz/gpl+/5oLOj9770pVwMoRxVSDkvpJrQ39V2mNmmBjQvcpQBvTYZ6TR6 gAjw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=htv+M06c; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=ED247vDM; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=HmFPEWrp; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id a92af1059eb24-1ae2be00d3csi25944441c88.80.2026.11.02.06.20.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Nov 2026 06:20:34 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=htv+M06c; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=ED247vDM; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=HmFPEWrp; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=FWPA3c7Qr+ZO+ygckGz7mERhytcmt6h5BgPcydd4L7M=; b=htv+M06c/8pacn 3C8O4ZvIyYpBe7hZn+UcjHAwEq+jdtIU9v4zFOqfFvB/xv7mLVJpskVlV7y10VjUqxT1/XiLss470 YaXwYxEbDFxBEpPPYzCTzm1fe4YprnlZP9YynNlohrwR7Tp4P6scGYov2sV0hZoNE26SJ0D/ohPm+ GT4=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.100.1) (envelope-from ) id 1xNstl-000000008RU-2Msz; Mon, 02 Nov 2026 14:20:33 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xNstU-000000008R1-1tKd for openvpn-devel@lists.sourceforge.net; Mon, 02 Nov 2026 14:20:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Unsubscribe-Post:List-Subscribe:List-Post:List-Owner:List-Archive; bh=TKu3Pzfom8EsoHKeN4Zm7+GbiAYYc9bQlJDA9ST9mr0=; b=ED247vDMPBMaGFmW645K0sJwoW pMG5A0GwaQhSMJj6+LQTqAz8UcV3eA4Ln6hcsSgujuOUc5Lrtt2pobs9eN4waEoD6KuiUULdhfJm/ OYdlhdmEWTBnOgAltv8+pFldJJSyEpVa1TR6Tu4FC3EzzNcEmcYo1u1yfNvszNR02iCs=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=TKu3Pzfom8EsoHKeN4Zm7+GbiAYYc9bQlJDA9ST9mr0=; b=HmFPEWrpWqK/jCzx98u3wJDw+T bnMaU4iM4LPzxaesCdtXj3VQ3AHjsUm8vz4stwQgx13wsbF9mRdXrwx6MYqaGj5MQyQEckKRMZ2WR Sel1TKldpZvH142PQsbf8r1hY8m4JjvMNJnscXgaaS4F4Ud4r3DsjJVeQo2oR+clBI7I=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.100.1) id 1xNstM-000000001PN-0M65 for openvpn-devel@lists.sourceforge.net; Mon, 02 Nov 2026 14:20:08 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 6A2EK1uV030481 for ; Mon, 2 Nov 2026 15:20:01 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 6A2EK1Bm030480 for openvpn-devel@lists.sourceforge.net; Mon, 2 Nov 2026 15:20:01 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Mon, 2 Nov 2026 15:19:55 +0100 Message-ID: <20261102142000.30467-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Razvan Cojocaru init_route_list() and init_route_ipv6_list() print rgi/rgi6 before they are filled, so ROUTE_GATEWAY/ROUTE6_GATEWAY were never logged. Print ngi/ngi6, which the surrounding block checks and exports. Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#DnsBlocklists-dnsbl-block for more information. [193.149.48.129 listed in list.dnswl.org] 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1xNstM-000000001PN-0M65 Subject: [Openvpn-devel] [PATCH v1] route: print net_gateway info instead of unset rgi/rgi6 X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1880756568616707379 X-GMAIL-MSGID: 1880756568616707379 From: Razvan Cojocaru init_route_list() and init_route_ipv6_list() print rgi/rgi6 before they are filled, so ROUTE_GATEWAY/ROUTE6_GATEWAY were never logged. Print ngi/ngi6, which the surrounding block checks and exports. Broken since 2777cdd3 ("route: handle default gateway (net_gateway) and nexthop towards VPN server separately"). Change-Id: I73cebcb7649e7c2bfdd29fee955b192f143a5ab9 Signed-off-by: Razvan Cojocaru Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2086 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2086 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpn/route.c b/src/openvpn/route.c index 0bce966..7a475a6 100644 --- a/src/openvpn/route.c +++ b/src/openvpn/route.c @@ -619,7 +619,7 @@ { setenv_route_addr(es, "net_gateway", rl->ngi.gateway.addr, -1); #ifndef ENABLE_SMALL - print_default_gateway(D_ROUTE, &rl->rgi, NULL); + print_default_gateway(D_ROUTE, &rl->ngi, NULL); #endif } else @@ -770,7 +770,7 @@ { setenv_str(es, "net_gateway_ipv6", print_in6_addr(rl6->ngi6.gateway.addr_ipv6, 0, &gc)); #ifndef ENABLE_SMALL - print_default_gateway(D_ROUTE, NULL, &rl6->rgi6); + print_default_gateway(D_ROUTE, NULL, &rl6->ngi6); #endif } else