From patchwork Mon Nov 2 17:00:41 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Lichtenheld X-Patchwork-Id: 5566 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:6022:3119:b0:118:2077:975e with SMTP id e25csp5693271laa; Mon, 2 Nov 2026 09:00:56 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvBya/0yx+aDVhX8MIbn91sDgjOZ9zLO4pQ28WkoueYH04gCoHprspQ2aDTOL4bfslMORbMkEhMYxIok=@openvpn.net X-Received: by 2002:a05:6830:82f4:b0:80c:d34f:5f5e with SMTP id 46e09a7af769-85d364551c5mr7255256a34.23.1793638855801; Mon, 02 Nov 2026 09:00:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793638855; cv=none; d=google.com; s=arc-20260327; b=IP2yNLeE4gVo5WlApXNRKdb9/GmlDhbjlB3NE1AGXyahoLwjPPrE4UZGMM4/hFtff1 tSIlrmcFnrVsb6UK0jXNLYjJbk0Sf8B5m5kPPwUrT0OUXZm3/EvHud2Thm/yIfELzjGg nvNaxuLevJ6HJVy4uTVpWynsltUTr3XTTaQYysatkX28CP+yCDeTzKN+/i4Q7iPQZfAh 1nLQQZj12tYkbxwFe+DrLkZRTCBZP/PhDKHGq3a+g6qC5kaxW6AeVrlek+97WYm181co RY75foeP87ElsE2xltAMwOIRn9GCkueWBKhjdDb3V+NTJkuhheEFassgvxDSrVnEkkfj EhuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature:dkim-signature; bh=Y00fywgM9sAFQtUSYiMh+ieBU0YKxs5yL8b7CcjuTDQ=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=JXEnhHjxjQXLxSfrYzxIshghEVZugua4IrrbjLYM9iLuCFhKD0ZbW6uJxOLXeg6FjR WNlSnVf57TlmFhG8q5hQymV8KB2skuPH/h+ZjiGrhqqYo0C2JRuUz7Fmi2qvU/aO2nt/ sOEagC5gOAs/5ytOTMjtYlHuZlK75yIcbf9QQLQMmBVO8NgpyIYpF428XJLPRsAPD1XK +l2hg2IggLYtmS0aYkQrkbB9FipQfROAP7CbLhCiJapIw+N6j+Pcm9/k04QnFFdKw/OU AIjG7EMtVytv5FJKcaquKKhvlcxXt/k2VnPrr+oWib7AEn8BriiQkmZ82yhCzFP7yJ8j yw3A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=M40hDNGe; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="ZmKOtN7/"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=bqTG2MwC; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=EHzs3y6H; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 46e09a7af769-85d357b672fsi17237350a34.135.2026.11.02.09.00.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Nov 2026 09:00:55 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=M40hDNGe; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="ZmKOtN7/"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=bqTG2MwC; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=EHzs3y6H; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=Y00fywgM9sAFQtUSYiMh+ieBU0YKxs5yL8b7CcjuTDQ=; b=M40hDNGe8brpqq 2ZW+U2ZMN9zWIJU0btmda26Y9o1vP6rSrtPk4ZCisI0a3OUpZi9OJIQwc0S42lwaFwo7hVnd55mAC ESy4GKCdQ+ib+3Qs6W77Cw4Bu3vwnMOAL0+6He94L67Naj5/jGc9+ggXdsQ9RgXoGtafc4KbMlD/Q qPU=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.100.1) (envelope-from ) id 1xNvOu-000000002oR-3vRq; Mon, 02 Nov 2026 17:00:52 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xNvOu-000000002oK-1o6q for openvpn-devel@lists.sourceforge.net; Mon, 02 Nov 2026 17:00:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Unsubscribe-Post:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZyoXMDq1TD2JsqePzGiS0gFzO7cUfijUrXD6Dz7k+uM=; b=ZmKOtN7/nb2izmq2gXzslFxZlB B/Glz0AJUL11xDzlfSVR5gLQ7vzeSY1f0ClbxdybUONSW6dgZQNx9VToGRL2xN0+g2TdJXfUmCcHy fr/FkN7cmsStQ/izHbqNElCXLSPNTZ3h+G3e5RlS1QwycZNgQMk+M3WGt04zyZ7FTzUw=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZyoXMDq1TD2JsqePzGiS0gFzO7cUfijUrXD6Dz7k+uM=; b=bqTG2MwCwL+wZ3JN3V6a3grtU0 HmhBvKs764iVtCb23KMpXolNhn3Ld47iAJx54mb1PcngWJ8YnVD99V2xOWPykUAqKA69hbJFXhkq6 E2lyolb2M1ycdP2HYHIUSqiRtZ9db357bCvz1Qwuf0rWKqB7JIN8kk8jl8bijg1CCl20=; Received: from mout-p-101.mailbox.org ([80.241.56.151]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.100.1) id 1xNvOs-000000005xj-39kw for openvpn-devel@lists.sourceforge.net; Mon, 02 Nov 2026 17:00:52 +0000 Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:b231:465::202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519MLKEM768 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4jJHyf27nhz8v9C for ; Mon, 02 Nov 2026 18:00:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lichtenheld.com; s=MBO0001; t=1793638842; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZyoXMDq1TD2JsqePzGiS0gFzO7cUfijUrXD6Dz7k+uM=; b=EHzs3y6HBxoE6NYkDQR8AMs0i0zHTb7ZH8BOOKlRfAHMsqXQpjKk1mD9SH7QA8r4NucIfB h+DbcqFMgJL1IdXF3iRkjaQNQSudVS5EMblwUZskDhvLDI8h+muY9sWJxj8E7em8P6unuL l+x6xQLNuYk2QDxITqW3G5sr23FVDuzOB+UpCayGsSvCsGgxHUM7WfYDYgkVv7gQ68gUYn 0gRqrvjlUczUzcSI2laAd6u5FPi7qpcckoKILkSU2lQLosRR/H6zAUHh0LcWqIIwV0oMNQ 4wDC3GEA1UrxO49cUiymvc9vlES9t5MuaO2pOmulah5XuJu9qcBe8vTYTRuluw== Authentication-Results: outgoing_mbo_mout; dkim=none; spf=pass (outgoing_mbo_mout: domain of frank@lichtenheld.com designates 2001:67c:2050:b231:465::202 as permitted sender) smtp.mailfrom=frank@lichtenheld.com From: Frank Lichtenheld To: openvpn-devel@lists.sourceforge.net Date: Mon, 2 Nov 2026 18:00:41 +0100 Message-ID: <20261102170041.110861-1-frank@lichtenheld.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 X-Rspamd-Queue-Id: 4jJHyf27nhz8v9C X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Razvan Cojocaru It passed the global management to management_query_multiline_flatten_newline() while using its man argument for the state and input buffers. No functional change, the only caller passes the global. Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-Headers-End: 1xNvOs-000000005xj-39kw Subject: [Openvpn-devel] [PATCH v1] manage: use man argument in management_query_cert() X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1880766656882762549 X-GMAIL-MSGID: 1880766656882762549 From: Razvan Cojocaru It passed the global management to management_query_multiline_flatten_newline() while using its man argument for the state and input buffers. No functional change, the only caller passes the global. Change-Id: Ifc12dafe9621ca00dc0022ad426afebcf38fbc3b Signed-off-by: Razvan Cojocaru Acked-by: Frank Lichtenheld Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2094 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2094 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Frank Lichtenheld diff --git a/src/openvpn/manage.c b/src/openvpn/manage.c index 16864c8..d391559 100644 --- a/src/openvpn/manage.c +++ b/src/openvpn/manage.c @@ -3937,8 +3937,8 @@ char *result; result = management_query_multiline_flatten_newline( - management, NULL, (char *)buf_bptr(&buf_prompt), "certificate", - &man->connection.ext_cert_state, &man->connection.ext_cert_input); + man, NULL, (char *)buf_bptr(&buf_prompt), "certificate", &man->connection.ext_cert_state, + &man->connection.ext_cert_input); free_buf(&buf_prompt); return result; }