diff mbox series

[Openvpn-devel,v2] openvpnserv: fix inverted inet_ntop() check in GetItfDnsServersV6()

Message ID 20261102170238.111437-1-frank@lichtenheld.com
State New
Headers
Series [Openvpn-devel,v2] openvpnserv: fix inverted inet_ntop() check in GetItfDnsServersV6() |

Commit Message

Frank Lichtenheld Nov. 2, 2026, 5:02 p.m. UTC 
  From: Razvan Cojocaru <razvanc@mailbox.org>

inet_ntop() returns NULL on failure, but the check treated success as
an error, so DHCPv6 DNS servers were never returned.

Broken since 0f3b7d17 ("win: implement --dns option support with
NRPT").

Change-Id: I97a14086258c08b47e37f07f103460a9d0bb9afd
Signed-off-by: Razvan Cojocaru <razvanc@mailbox.org>
Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2090
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2090
This mail reflects revision 2 of this Change.

Acked-by according to Gerrit (reflected above):
Frank Lichtenheld <frank@lichtenheld.com>
diff mbox series

Patch

diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c
index e2f17f0..484f27c 100644
--- a/src/openvpnserv/interactive.c
+++ b/src/openvpnserv/interactive.c
@@ -2217,7 +2217,7 @@ 
                 s--;
             }
 
-            if (inet_ntop(AF_INET6, &in_addrs[i], pos, s) != NULL)
+            if (inet_ntop(AF_INET6, &in_addrs[i], pos, s) == NULL)
             {
                 *size = 0;
                 return ERROR_MORE_DATA;