| Message ID | 20261103123455.4065-1-gert@greenie.muc.de |
|---|---|
| State | New |
| Headers |
Return-Path: <openvpn-devel-bounces@lists.sourceforge.net>
Delivered-To: patchwork@openvpn.net
Received: by 2002:a05:6022:4121:b0:118:2077:975e with SMTP id d33csp560054laa;
Tue, 3 Nov 2026 04:35:06 -0800 (PST)
X-Forwarded-Encrypted: i=2;
AKwUvBz1EFBx0LchX7PCUEbFFODA4/WYLmsJCLpcA7oi20VjHZaM7ttbmlorf3d9uPyt8xa2Qe51E0fa4PU=@openvpn.net
X-Received: by 2002:a05:7022:eb44:10b0:166:29a2:f83f with SMTP id
a92af1059eb24-1ac55774bdfmr20734860c88.5.1793709306035;
Tue, 03 Nov 2026 04:35:06 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1793709306; cv=none;
d=google.com; s=arc-20260327;
b=nRJu9TAkRkUiGEitBpWRzVYlOMi8jPOTbPUOcS4/NyWmnpEjsK6C5Jh1Q1+aq5Gtz5
zAKG/gLaCO3/VOY18xxFr1uzlGtNJNU2XRvluNW+zX2AIM9rF/5yd/QH8TxafMSbxkYg
5JYuORSUVs/P4yh89CiovEKD6mmp54aDz8H6LMDI5/3DFFUT99uIp1D6yj8p5swnaiy6
SaBWW/vuWygIFaipAAhwTFhLpSvCfOlQTTLYIZh2NJesXRsGXguFS7iwuz5/eaIuUxR8
BRrRg86EkVZDswq7bIy/NhuEvtavOKW0dySsd03aNVJg5HhG6pichbHsY8EJJr7CUAGS
uDIA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20260327;
h=errors-to:content-transfer-encoding:list-subscribe:list-help
:list-post:list-archive:list-unsubscribe:list-id:precedence:subject
:mime-version:references:in-reply-to:message-id:date:to:from
:dkim-signature:dkim-signature:dkim-signature;
bh=g8zM5DZRvtiT4pH7WYuj8X80EYOmkbdwCh9IsBzrgF4=;
fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=;
b=Va3TR5j28R7b1MM7ZTZMdZEuOhyw/4s9YqdX0cFtr8SbN/He5KZJE99SFROkHuitxX
T8u0IoBYD33yCv2scSm02u5ECW0GaMy07TyDBzVpG+ZSmviPyl2af9r2lZvYYy1iTAuI
iSTtCJRwaWc9OFZQ2w6Q4pgb28jBnyllVf3o/b61g/RPDhPATiuFospaLC6+TaYIj6c2
s2Rn3xT2NkBTV9tBFI6kIxxHMYkWxzAk7wOgTx8i86LeXH7WpE5tpcfng2xA4Y2FCW6B
8yTJZ66Cm+nMgGjJgZggNA5nvQ/DhJWVHlHMgpr+eBiDQUDuiktNJo7MYfaFSpCagytY
84Pw==;
dara=google.com
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@lists.sourceforge.net header.s=beta
header.b=cP4IyBeY;
dkim=neutral (body hash did not verify) header.i=@sourceforge.net
header.s=x header.b=EfQeGg4Z;
dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x
header.b=X78yhIz2;
spf=pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de
Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7])
by mx.google.com with ESMTPS id
a92af1059eb24-1ac1b86c5e4si37256389c88.90.2026.11.03.04.35.05
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Tue, 03 Nov 2026 04:35:06 -0800 (PST)
Received-SPF: pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) client-ip=216.105.38.7;
Authentication-Results: mx.google.com;
dkim=pass header.i=@lists.sourceforge.net header.s=beta
header.b=cP4IyBeY;
dkim=neutral (body hash did not verify) header.i=@sourceforge.net
header.s=x header.b=EfQeGg4Z;
dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x
header.b=X78yhIz2;
spf=pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:
List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:
Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender:
Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From:
Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post:
List-Owner; bh=g8zM5DZRvtiT4pH7WYuj8X80EYOmkbdwCh9IsBzrgF4=; b=cP4IyBeY86C/my
3CqvK8koO5BL4OR4EX8Hi5WIBavU1azmzszKWV1JO8TGsVNHmqv+Wdgj+ZNa937OcwA5oRRGTRLPy
Kpa7xO3jnhCMrqPb8iF69kdDwji+Z91BjpSwbaFovnxkWln6F4LOh+sIT4vaq0sXx1BmRqJCU2AkA
AJI=;
Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com)
by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.100.1)
(envelope-from <openvpn-devel-bounces@lists.sourceforge.net>)
id 1xODjE-000000003bw-04AZ;
Tue, 03 Nov 2026 12:35:04 +0000
Received: from [172.30.29.66] (helo=mx.sourceforge.net)
by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.100.1)
(envelope-from <gert@blue4.greenie.muc.de>)
id 1xODjD-000000003bq-1SLh for openvpn-devel@lists.sourceforge.net;
Tue, 03 Nov 2026 12:35:03 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References:
In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Unsubscribe-Post:List-Subscribe:List-Post:List-Owner:List-Archive;
bh=86bvpoR3MD0fr+A+PhBiZ/W+/6Wp48dGmppJEjclMzQ=; b=EfQeGg4ZS+2w4iTNLMvKAkqSUt
bLAuO+xpHj6YxpfCguxcCQiA/3MltUmjtj/CtKGPN015nOTWDfBuPBOLKi0U8g6V7soG1rUJtMCJd
PooCbYDEJrdRGCWQGk3XOMVPwxAZnYuUuzzS9RKdAIss6UImq/oOSTO8hCQ1sAHt52A4=;
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x
;
h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:
Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID:
Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=86bvpoR3MD0fr+A+PhBiZ/W+/6Wp48dGmppJEjclMzQ=; b=X78yhIz2gw5DqvBTpA/D6HpMV/
XVzlrm4eZdyPutxB/9ebBI85mz2YUlSc01fumOgmcq0Iwf7ynFNlJ3Q64B/NjMWKsjWuAejpgXK/2
kWnrUx1RS6BLDFpEuOi3BfYBdDM8YshJm9xHT4ple7O9Hx/x1UqoXG5S9ssy8EjkhWGI=;
Received: from [193.149.48.129] (helo=blue.greenie.muc.de)
by sfi-mx-2.v28.lw.sourceforge.com with esmtps
(TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.100.1)
id 1xODjC-000000003bC-1ZWM for openvpn-devel@lists.sourceforge.net;
Tue, 03 Nov 2026 12:35:03 +0000
Received: from blue.greenie.muc.de (localhost [127.0.0.1])
by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 6A3CYtqb004079
for <openvpn-devel@lists.sourceforge.net>; Tue, 3 Nov 2026 13:34:55 +0100
Received: (from gert@localhost)
by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 6A3CYtkC004078
for openvpn-devel@lists.sourceforge.net; Tue, 3 Nov 2026 13:34:55 +0100
From: Gert Doering <gert@greenie.muc.de>
To: openvpn-devel@lists.sourceforge.net
Date: Tue, 3 Nov 2026 13:34:50 +0100
Message-ID: <20261103123455.4065-1-gert@greenie.muc.de>
X-Mailer: git-send-email 2.55.0
In-Reply-To:
<gerrit.1793704368000.I88ea70e88c3ec133261210e0404f324bbf025d9b@gerrit.openvpn.net>
References:
<gerrit.1793704368000.I88ea70e88c3ec133261210e0404f324bbf025d9b@gerrit.openvpn.net>
MIME-Version: 1.0
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software,
running on the system "sfi-spamd-2.hosts.colo.sdot.me",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: From: Razvan Cojocaru <razvanc@mailbox.org> The Digest
challenge
stored by store_proxy_authenticate() was never freed when the proxy info
was released. Reported-by: hz86
https://github.com/OpenVPN/openvpn/issues/1134
Content analysis details: (1.3 points, 5.0 required)
pts rule name description
---- ----------------------
--------------------------------------------------
1.3 RDNS_NONE Delivered to internal network by a host with no rDNS
X-Headers-End: 1xODjC-000000003bC-1ZWM
Subject: [Openvpn-devel] [PATCH v1] proxy: free proxy_authenticate in
http_proxy_close()
X-BeenThere: openvpn-devel@lists.sourceforge.net
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <openvpn-devel.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/options/openvpn-devel>,
<mailto:openvpn-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive:
<http://sourceforge.net/mailarchive/forum.php?forum_name=openvpn-devel>
List-Post: <mailto:openvpn-devel@lists.sourceforge.net>
List-Help: <mailto:openvpn-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/openvpn-devel>,
<mailto:openvpn-devel-request@lists.sourceforge.net?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: openvpn-devel-bounces@lists.sourceforge.net
X-getmail-retrieved-from-mailbox: Inbox
X-GMAIL-THRID: 1880840529243992120
X-GMAIL-MSGID: 1880840529243992120
|
| Series |
[Openvpn-devel,v1] proxy: free proxy_authenticate in http_proxy_close()
|
|
Commit Message
Gert Doering
Nov. 3, 2026, 12:34 p.m. UTC
From: Razvan Cojocaru <razvanc@mailbox.org> The Digest challenge stored by store_proxy_authenticate() was never freed when the proxy info was released. Reported-by: hz86 https://github.com/OpenVPN/openvpn/issues/1134 GitHub: closes OpenVPN/openvpn#1134 Change-Id: I88ea70e88c3ec133261210e0404f324bbf025d9b Signed-off-by: Razvan Cojocaru <razvanc@mailbox.org> Acked-by: Frank Lichtenheld <frank@lichtenheld.com> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2104 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2104 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Frank Lichtenheld <frank@lichtenheld.com>
diff --git a/src/openvpn/proxy.c b/src/openvpn/proxy.c index c3ad7de..7b5a289 100644 --- a/src/openvpn/proxy.c +++ b/src/openvpn/proxy.c @@ -523,6 +523,10 @@ void http_proxy_close(struct http_proxy_info *hp) { + if (hp) + { + free(hp->proxy_authenticate); + } free(hp); }