[Openvpn-devel,v1] proxy: free proxy_authenticate in http_proxy_close()

Message ID 20261103123455.4065-1-gert@greenie.muc.de
State New
Headers
Series [Openvpn-devel,v1] proxy: free proxy_authenticate in http_proxy_close() |

Commit Message

Gert Doering Nov. 3, 2026, 12:34 p.m. UTC
  From: Razvan Cojocaru <razvanc@mailbox.org>

The Digest challenge stored by store_proxy_authenticate() was never
freed when the proxy info was released.

Reported-by: hz86 https://github.com/OpenVPN/openvpn/issues/1134

GitHub: closes OpenVPN/openvpn#1134
Change-Id: I88ea70e88c3ec133261210e0404f324bbf025d9b
Signed-off-by: Razvan Cojocaru <razvanc@mailbox.org>
Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2104
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2104
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Frank Lichtenheld <frank@lichtenheld.com>
  

Patch

diff --git a/src/openvpn/proxy.c b/src/openvpn/proxy.c
index c3ad7de..7b5a289 100644
--- a/src/openvpn/proxy.c
+++ b/src/openvpn/proxy.c
@@ -523,6 +523,10 @@ 
 void
 http_proxy_close(struct http_proxy_info *hp)
 {
+    if (hp)
+    {
+        free(hp->proxy_authenticate);
+    }
     free(hp);
 }