From patchwork Tue Nov 3 14:14:33 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5580 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7301:d09:b0:369:de73:f82e with SMTP id kl9csp796678dyb; Tue, 3 Nov 2026 06:14:52 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvByjCCpu+gH3WjBVXzaJdtEcZrtCgzwNV0ejpNFRJMTYqisfz1CI1xVMTzlZ7u2UNuzve1pP7ebDJd8=@openvpn.net X-Received: by 2002:a05:693c:639c:10b0:36a:1f8:a56e with SMTP id 5a478bee46e88-36a423bb931mr18929707eec.23.1793715291623; Tue, 03 Nov 2026 06:14:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793715291; cv=none; d=google.com; s=arc-20260327; b=i7iEsx5lDfp9cBnoFuS0PK8Zu0P9/+vHwAk99xaLkg4rCe2vn/xMEXknY2Nf0HDhWa 9QJdNaZnIz/ioJZPp8eCt0CN3DOwW6w02Rtwe0iXtFPvDJFDBXwZIN73oOBvoA1xTjdf Wj1JxAYEDbjVogm8i/O6AnWkiW0TYEtZiFbheu0dCf8fT7KQ2+R3j8Mlh+jeAZrcUIi5 tFieHZN1o+XtJ+PgJvnzrL4y60D6NiLUflFGVRoZzfHaq5M7gzLhSyG457lokYoMOu57 tRoMlkxLeLygSc85Ge8DnnjqWvK9XDjUzmBiG66734kENmsjpc7sfZhwS//WAvHLkUdc OUjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=NPLtEQcdRYqia94rfCo9be4MfYm7wBHuBOIjFSELP/I=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=lO2a7meuP7/LbdI+Zx+l25xJfbVtwYanw5iB5U+PQTqSziM16QbM9Vu0bGxGcs4CV7 n6xKpXq/ULetK0j2SHu7NH5tRKhA1t/4Ht0jgyZbSCEds7LQHoPC1b1sJX0yVgoPoUPc cRFsRpWFht1KIo25JdkMydb9IZXeh9Qoz6PjJqBeui5WKknI3uuSbQW33eQyAlERNYZS hPQQSTDNGkmtkv5ocFteEHcnwwyBhTo+djl8qtTJFUar/L/h9NST/JZ8hFpH3zILU8Oc XjsoVoV3XCmZRZbJALvX1qa6F0zl07Ccwpv3QZ4wEB1BG8YBwRL96kMsFezRgPaQac+Y Rd2Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=DVa4chsL; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=jmykXdu9; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=g6RseTeh; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 5a478bee46e88-36a42b4c856si39008963eec.66.2026.11.03.06.14.51 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Nov 2026 06:14:51 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=DVa4chsL; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=jmykXdu9; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=g6RseTeh; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=NPLtEQcdRYqia94rfCo9be4MfYm7wBHuBOIjFSELP/I=; b=DVa4chsLHHG1JF vXZ2SQYHrseVr7CCZaIN5DZip36jm8wMlSxvdooP/Ol50uMdpt/LLg0qO8O7RSaeYjEOPeP4Rnvcf oTvDqk0NiwnULtqAS5dP2EG8e+Tx7CbgCE1+NWr4qmb8KYmgKDQfLG5ClxNWEPHpR1ZJ8Qs1rzX3R 9/c=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.100.1) (envelope-from ) id 1xOFHl-000000006NI-3af9; Tue, 03 Nov 2026 14:14:49 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xOFHk-000000006NB-18ot for openvpn-devel@lists.sourceforge.net; Tue, 03 Nov 2026 14:14:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Unsubscribe-Post:List-Subscribe:List-Post:List-Owner:List-Archive; bh=cgJY/jo15dN4LVyG8liv0uuVelqtppxfzEqVUOo0Xdk=; b=jmykXdu9ltGQ3/KSbEWvXaK8L7 EQZojK4Y3tHPPnMDcAudJYFRd3xY0zLLMTwR/a8XC+5/b19iHTprB55LmhJrlk2eME1rtqKJI+GLo 4TfwCE16rGUPBlvKfOG+9ZBd5cxrgXwwJGtlFDHZqIgLt+vPnVMdrwmPi96YrZ2k97Po=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=cgJY/jo15dN4LVyG8liv0uuVelqtppxfzEqVUOo0Xdk=; b=g6RseTehsuDeRyFkTxJALVQx4v XdzdW4FXTShLWHLyYRW8R1dQlhBpwu9gehPJzTnxPhKQy5jFFPiLFlJzcNfeSg3xFZwzBsdj5Vytu /0DLdxxveOT5QveyLpYNYqR86cBqF3GrQeuR3YvqqPaAHNyK99ZB+SCgP9pB0YvTa5Vs=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.100.1) id 1xOFHi-000000006GI-1MXc for openvpn-devel@lists.sourceforge.net; Tue, 03 Nov 2026 14:14:48 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 6A3EEdnO014056 for ; Tue, 3 Nov 2026 15:14:39 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 6A3EEdxZ014055 for openvpn-devel@lists.sourceforge.net; Tue, 3 Nov 2026 15:14:39 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Tue, 3 Nov 2026 15:14:33 +0100 Message-ID: <20261103141439.14041-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Arne Schwabe Without these defines and the hidden goto inside the NLA_PUT functions cppcheck complains about ret in dco_linux.c. This allows to run cppcheck on macOS and FreeBSD without triggering these warnings. Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1xOFHi-000000006GI-1MXc Subject: [Openvpn-devel] [PATCH v1] Provide minimal netlink defines for cppcheck on FreeBSD and macOS X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1880846805122846333 X-GMAIL-MSGID: 1880846805122846333 From: Arne Schwabe Without these defines and the hidden goto inside the NLA_PUT functions cppcheck complains about ret in dco_linux.c. This allows to run cppcheck on macOS and FreeBSD without triggering these warnings. Change-Id: I36430bab897e5fe9b1cfd48de50224395d56d8fc Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2107 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2107 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Frank Lichtenheld diff --git a/dev-tools/openvpn-cppcheck-netlink.cfg b/dev-tools/openvpn-cppcheck-netlink.cfg new file mode 100644 index 0000000..b63adf0 --- /dev/null +++ b/dev-tools/openvpn-cppcheck-netlink.cfg @@ -0,0 +1,7 @@ + + + + + + + diff --git a/dev-tools/run-cppcheck.sh b/dev-tools/run-cppcheck.sh index d1c22c5..debcd46 100755 --- a/dev-tools/run-cppcheck.sh +++ b/dev-tools/run-cppcheck.sh @@ -20,9 +20,11 @@ if [ $(uname) = "Darwin" ] || [ $(uname) = "FreeBSD" ]; then SCRIPT_DIR=$(dirname $(readlink -f "${BASH_SOURCE[0]}")) num_procs=$(sysctl -n hw.ncpu) + EXTRA_LIBRARY="--library=${SCRIPT_DIR}/openvpn-cppcheck-netlink.cfg" else SCRIPT_DIR=$(dirname $(readlink -e "${BASH_SOURCE[0]}")) num_procs=$(nproc) + EXTRA_LIBRARY="" fi : ${SOURCE_DIR:=$SCRIPT_DIR/..} : ${BUILD_DIR:=$PWD} @@ -35,6 +37,7 @@ -I${BUILD_DIR} -I${BUILD_DIR}/include/ \ --enable=all ${disable_arg} \ --library=${SCRIPT_DIR}/openvpn-cppcheck-library.cfg \ + ${EXTRA_LIBRARY} \ --library=openssl.cfg \ --suppress-xml=${SCRIPT_DIR}/cppcheck-suppressions.xml --inline-suppr \ --cppcheck-build-dir=${CPPCHECK_DIR} \