From patchwork Wed Nov 4 12:48:54 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5595 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:6022:30a9:b0:118:2077:975e with SMTP id f41csp315723laa; Wed, 4 Nov 2026 04:49:13 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvByCxgXXewPeravw8YDb7yWXt6PinlzC/gbF92JlZWdLBJGvqCkA8ohXNyJcWJqd9MMaLOBloQ6OeeM=@openvpn.net X-Received: by 2002:a05:7301:1caf:b0:36c:a104:90db with SMTP id 5a478bee46e88-36ca104983fmr4236706eec.41.1793796552677; Wed, 04 Nov 2026 04:49:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793796552; cv=none; d=google.com; s=arc-20260327; b=JVY9IeJC9S+TEMxNPqU5VTM/m8A87Q8ZtpFH97v0yaSj8dEcopU6+YT9wI5Bqtd/gi E6gRAvd10IuKjK/fyfYci0mMpGuBO81MAvoPvHzXDnE7w4vrl6prafIuumgEYU7N7dt2 10YIVxjBTiHEPh7Ji4UOyW1AQaKcJM0fs7uTtEQhSRvcQWTPJ6xEblgyrYB3SsikL3sp F0oyRx9DQwKZFd1eaDgqW3KFuMflQXVKPKJ4uHjrSV+GKAyvIE8qAZloCGa1vPj03JKm XyPxcppuzOHcq7vD27IV+sWRMdNMh/TIgyZyGsy5cwbMOKQufMTG0TCIA2KKj2g6ojYt fDKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=0YEIYJMm+YP+iWsOStPwrJtAA9gXzFQug0bYWvuIYLw=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=LMEE2qyYco56nGAxwQdKZbql/SnpiPeFEJLbZ9d94T692Oz44FwZok0QmdCgWEgXj3 UMK2W7aTI4GWMBpu/MMqZ3ea1FKzre00RrtCpgD2rY4JGbFpzBrx3yBBycrGlpcmGsIA w7tcVDJOviATazR44Y96zxOMFeO1TClIZTGWICG0UkW+HCpfa9pQ1iwq3l+YCcufi6qM AtAGZXm/LcyR3h2PQc7cY6K4Ac3ivF2Ke4jwXpBkBq0nidxU+Yjr4fASQ0BizFB8n/J4 wfEz5iC+epYTwtxOe/7SVpSxFKxWhZQVypCdKkA9KRNQhqrgRcokv2AKxO6qW8db14/v IJWg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=b8DSq7vi; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=mTpfZnLX; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Fi5zklZd; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 5a478bee46e88-36ca3a11283si5937148eec.96.2026.11.04.04.49.12 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Nov 2026 04:49:12 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=b8DSq7vi; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=mTpfZnLX; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Fi5zklZd; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=0YEIYJMm+YP+iWsOStPwrJtAA9gXzFQug0bYWvuIYLw=; b=b8DSq7vi0KKn8U Uy7B5+2ZuigNaco0/eVIS7Z26xDlKGgczkTCveRMX8q2g4CTC4iQ33MOLjgsqkO0eAWqpduLpxGQe Bibulnv2DGxLihGr8z6uR6T24/wgzKdsM4SUl4jimqwUGdRDsGyQk1Ort5BLtyrpZ1AmLlOygDi6z KpY=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.100.1) (envelope-from ) id 1xOaQQ-000000001c4-30Bk; Wed, 04 Nov 2026 12:49:10 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xOaQO-000000001bw-32Ii for openvpn-devel@lists.sourceforge.net; Wed, 04 Nov 2026 12:49:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Unsubscribe-Post:List-Subscribe:List-Post:List-Owner:List-Archive; bh=hiqc+QwwSKkvX/Q8gASp2uy0ZmpLf9hHCMwhBwMjDIc=; b=mTpfZnLX9qHCsYf/JYQjUl1uJQ a1h7GHzVYhE/WtOuy+G2BETNE8nfeygMPrMsiIzQjaqLiADOGjMwJvUbB2VCnNO4WOYzuZ8HYMiEP MskaisqXUvkaW3YGsBlv1ZwQEdnoXc3j3hg22pnwGvH9QT5La1qG0tuo6jLh1CffhbmE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=hiqc+QwwSKkvX/Q8gASp2uy0ZmpLf9hHCMwhBwMjDIc=; b=Fi5zklZdpZPS4h4lF+5oDMsvMT cNEO8PSmbR5CL67iURka366nZKraLwIaIAtenn1i07n0ZEfA6Pw8sixM+oqfoNch1HN3VQjug2tDf w1hcP42snp4hhuv9WWzDTaEANfiQkMPimpKgfLiefsgYJtHDpuTavon3zmi1M3VPJTIU=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.100.1) id 1xOaQN-000000002oZ-0AER for openvpn-devel@lists.sourceforge.net; Wed, 04 Nov 2026 12:49:08 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 6A4CmxvF018431 for ; Wed, 4 Nov 2026 13:48:59 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 6A4CmxSF018430 for openvpn-devel@lists.sourceforge.net; Wed, 4 Nov 2026 13:48:59 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Wed, 4 Nov 2026 13:48:54 +0100 Message-ID: <20261104124859.18417-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Razvan Cojocaru The parameter has never been used since the function was added in 39e3d336 ("Mac OS X Keychain management client"). Its callers read the input list themselves. Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1xOaQN-000000002oZ-0AER Subject: [Openvpn-devel] [PATCH v1] manage: drop unused input parameter of management_query_multiline() X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1880932013971198987 X-GMAIL-MSGID: 1880932013971198987 From: Razvan Cojocaru The parameter has never been used since the function was added in 39e3d336 ("Mac OS X Keychain management client"). Its callers read the input list themselves. Change-Id: I40059eb9af845a5070ebb8caff741b0794632de2 Signed-off-by: Razvan Cojocaru Acked-by: Frank Lichtenheld Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2125 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2125 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Frank Lichtenheld diff --git a/src/openvpn/manage.c b/src/openvpn/manage.c index 58f63e6..57a9561 100644 --- a/src/openvpn/manage.c +++ b/src/openvpn/manage.c @@ -3830,7 +3830,7 @@ static int management_query_multiline(struct management *man, const char *b64_data, const char *prompt, - const char *cmd, int *state, struct buffer_list **input) + const char *cmd, int *state) { struct gc_arena gc = gc_new(); int ret = 0; @@ -3914,7 +3914,7 @@ int ok; char *result = NULL; - ok = management_query_multiline(man, b64_data, prompt, cmd, state, input); + ok = management_query_multiline(man, b64_data, prompt, cmd, state); if (ok && buffer_list_defined(*input)) { buffer_list_aggregate_separator(*input, 10000, "\n"); @@ -3941,7 +3941,7 @@ { char *result = NULL; - const int ok = management_query_multiline(man, b64_data, prompt, cmd, state, input); + const int ok = management_query_multiline(man, b64_data, prompt, cmd, state); if (ok && buffer_list_defined(*input)) { buffer_list_aggregate(*input, 2048);