From patchwork Wed Nov 4 12:49:27 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5597 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:6022:30a9:b0:118:2077:975e with SMTP id f41csp316792laa; Wed, 4 Nov 2026 04:50:10 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvBxHiNkweyr2V2Nq6dMRBAqcZ078mjZzTHyZfYyutUqVwN12XWh+JsaEihZUHv98L2gL1a+eWGE+swg=@openvpn.net X-Received: by 2002:a05:7300:5b89:b0:36a:1732:1e7 with SMTP id 5a478bee46e88-36a424c7b7dmr36458888eec.31.1793796610172; Wed, 04 Nov 2026 04:50:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793796610; cv=none; d=google.com; s=arc-20260327; b=lvMuISHxjBGukNjCi+PV5d5mOk3iL5F4AVugCfcsxaCHPg2btHCLWtNNlz/NSCgAQU DMk7fMeZAT2s+WrsiW+sL89qCiYAR9V9Ykj9LQac/TSXoPFQlClnf1q7hSRtvjO5Nde9 q18qog0qt7JSfF8FmyVzadWrXcHjQ6XIrXglO+jYJsLo3VRxZtYZRUzFVRNC3IQJ57EH Qd8dA1m91DdMjdMM/lPGSymgitU5u2E4ignxUjzuXr0EG+f/IZZQYaK/Pt090+6cWWrX 4CLSfBAWUS69d+ukOMwQ+9VugCUMy8TSkK0KWykNboBIPMlyJ7gROXBQqN1WzMJgjzzi VCxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=YMmn/7iL0AgOxuttjreLY4PKGR5TFs3eq3BeU7T19Hs=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=UoTYsTaXeyX26gSZ2zaC7XrjFegY5C96oXdjvWJ+CDclXSRukDQwjBLbsYKfe84ehJ KuqqmGsFaUSQ1cJ6XjOyDf4YoPkJGjUBZpaJHEHO7qUvMU6Kq+EqJoXzEmkaIY8fbSuf qpqOmbarnCeL+4KXNP6phfL3P9jd5th2ywc3MNrjlHAzrTicZx8otEOjyMCBxY16W1dP SF2LpzUJ6ZOUsYeOW18E6dKl7XRPSrXPi/Z4TbLPGQyaCQXcUEuhDfBjfsl6NT35Jl6T 1eYtpYu0ag27HLgSc8luqX7PIQvPGDpyATSr1b6x1S/seGT0ChiEmhshvU9IEhnkaLSU WdMQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=Dz9MDxIw; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=CQFmhQpo; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=gYBbula2; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 5a478bee46e88-36ca39e26e2si7797235eec.83.2026.11.04.04.50.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Nov 2026 04:50:10 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=Dz9MDxIw; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=CQFmhQpo; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=gYBbula2; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=YMmn/7iL0AgOxuttjreLY4PKGR5TFs3eq3BeU7T19Hs=; b=Dz9MDxIwCeOhvi WXgu3fkOWwEk6pZxg5NydO7gxjtI+5rHUcfVlu6HJOm5vcG/+VBTya2JZfSHscitGAlRGEXXQhRyP OotkWYGxVx7Um2EUQ/PVDhTtevTcRF9lrw8Nauh/mX9QakpMQxzcmqVMuTpQUkKL0lwF5dvv7UxmW Rqo=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.100.1) (envelope-from ) id 1xOaRM-000000006aw-3FkA; Wed, 04 Nov 2026 12:50:08 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xOaRG-000000006Zg-2kb7 for openvpn-devel@lists.sourceforge.net; Wed, 04 Nov 2026 12:50:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Unsubscribe-Post:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Qeiq7uK4FrQB5RDXZ+m2w3Vey6R3fXbXnVJCH0YlZ8E=; b=CQFmhQpo5t6AfWtUq3cXK7bF7S Ln+8yGNUOxrS6wlNYha5+LeklPagJqFTIVUqWqi/2Fmb5XmYyv8QubRn7jqg+Y74qSzQgmyU7uVlH njTpedg+bet9uv2/2xkqoUwuaw4L6EWIELxDd2iaj022DekuqmP3ECFeBPohad7qCGaA=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Qeiq7uK4FrQB5RDXZ+m2w3Vey6R3fXbXnVJCH0YlZ8E=; b=gYBbula2zeqGA94DZEh9FvLDl1 wkWt210sq0WXyiY/zUnow29dPiuqoqBwHDuiELxg/FuFdve+dBcxVqCJ4596PjWAmtLGCBaVVmVnP WuKvJh/6wQT3y1fEkazo7FlUDLmxFXYlAJGiraluYQyeAU8F16L3t9+3yqNVzBySNktQ=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.100.1) id 1xOaQs-000000000TG-3xJP for openvpn-devel@lists.sourceforge.net; Wed, 04 Nov 2026 12:49:39 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 6A4CnWMl018561 for ; Wed, 4 Nov 2026 13:49:32 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 6A4CnWEH018560 for openvpn-devel@lists.sourceforge.net; Wed, 4 Nov 2026 13:49:32 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Wed, 4 Nov 2026 13:49:27 +0100 Message-ID: <20261104124931.18525-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Razvan Cojocaru The read error message passed the ReadFile() result, which is always FALSE on that path, to strerror_win32() instead of GetLastError()'s err, so it never showed the real error. Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1xOaQs-000000000TG-3xJP Subject: [Openvpn-devel] [PATCH v1] tun: log the actual error in Windows tun_read_queue() X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1880932074606734867 X-GMAIL-MSGID: 1880932074606734867 From: Razvan Cojocaru The read error message passed the ReadFile() result, which is always FALSE on that path, to strerror_win32() instead of GetLastError()'s err, so it never showed the real error. Change-Id: I8b9efc75656e01df9afe99c280ba8c9c82e937f0 Signed-off-by: Razvan Cojocaru Acked-by: Frank Lichtenheld Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2120 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2120 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Frank Lichtenheld diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c index 225d8b1..10f738c 100644 --- a/src/openvpn/tun.c +++ b/src/openvpn/tun.c @@ -3305,7 +3305,7 @@ tt->reads.iostate = IOSTATE_IMMEDIATE_RETURN; tt->reads.status = err; dmsg(D_WIN32_IO, "WIN32 I/O: TAP Read error [%d] : %s", len, - strerror_win32(status, &gc)); + strerror_win32(err, &gc)); gc_free(&gc); } }