| Message ID | 20261104125029.18712-1-gert@greenie.muc.de |
|---|---|
| State | New |
| Headers |
Return-Path: <openvpn-devel-bounces@lists.sourceforge.net>
Delivered-To: patchwork@openvpn.net
Received: by 2002:a05:6022:30a9:b0:118:2077:975e with SMTP id f41csp317381laa;
Wed, 4 Nov 2026 04:50:41 -0800 (PST)
X-Forwarded-Encrypted: i=2;
AKwUvByGDjEg2iiXW175Xwekz4RLmjAzt4KROln0ix/IMjLeBZba9IKf3h6EV7deti2VcAiymbkrbZNemrA=@openvpn.net
X-Received: by 2002:a05:7300:a943:b0:36c:991e:c9b with SMTP id
5a478bee46e88-36c991e288dmr8604149eec.14.1793796641121;
Wed, 04 Nov 2026 04:50:41 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1793796641; cv=none;
d=google.com; s=arc-20260327;
b=sL2xMhFCP7tszciXAy97Cr7Nt4sXeBYnaeguo4Nir8fEciuPxElDqIazbI7UD7HYH7
PuXc+alZcf7wF7vsEDO9nsInwPWDjNk2dE6X2el9nRLIlRArop5QT9bPgS5FxNRk1Q/p
8iTJ5IFSiasbkKu6R/qonN16M5gVPZPy4axBG1iPc7PcaXiRd6rAKUAHSm9vHpfL+5Gw
aRGleeGaREqtdK31n0qskavV/9D+N1nRZyflTUWkUyKq1OmkXh59KYQlZo6eawpo4o4s
iDrE9gVM/8MZ2ixm8noOLa0sxLL0gIaFaoWYf1drhpyavxa02gBeY7sY6pHJOiqH6PYy
PGmw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20260327;
h=errors-to:content-transfer-encoding:list-subscribe:list-help
:list-post:list-archive:list-unsubscribe:list-id:precedence:subject
:mime-version:references:in-reply-to:message-id:date:to:from
:dkim-signature:dkim-signature:dkim-signature;
bh=/z7T13eUgqD+lbHWFwjawH8v8k01KxjIc5tDsZB60qc=;
fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=;
b=VWdgsMLU4mMOCLoVDck/KrKVOhYwInq2DkehskEyFxDqJ3PKe9vsa7+c7lx+SvAj7g
+KpWF/nKALpv8An3U7pNV5zYOOaNaRCUFFqM+00J+qD3mV1YFQ18LxwPW5ho4ANd0dCW
2jZjGPe/pXf5TfQQhbsuTEul2ev40GJ8ErTKrGVgLo2J/n8M8OHowJYzn0HwMy26P7X+
iMbP7CtMmDDTfowl+vktsXkp86pyHutMdB3c/y+89QmBfkdmp5OZp0Mm4NGISZlVTWYL
aYeXeC1KfKAxQwgdH13oOx6qE0PeDDwg3Vg5uiRUOk3SSKDAKglsQhwp2H+5G+MZhu8j
GS2g==;
dara=google.com
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@lists.sourceforge.net header.s=beta
header.b=FdIEN6JH;
dkim=neutral (body hash did not verify) header.i=@sourceforge.net
header.s=x header.b=jK4pGPpA;
dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x
header.b=SGoaKGan;
spf=pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de
Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7])
by mx.google.com with ESMTPS id
5a478bee46e88-36ca398ca8fsi5951832eec.69.2026.11.04.04.50.40
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Wed, 04 Nov 2026 04:50:41 -0800 (PST)
Received-SPF: pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) client-ip=216.105.38.7;
Authentication-Results: mx.google.com;
dkim=pass header.i=@lists.sourceforge.net header.s=beta
header.b=FdIEN6JH;
dkim=neutral (body hash did not verify) header.i=@sourceforge.net
header.s=x header.b=jK4pGPpA;
dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x
header.b=SGoaKGan;
spf=pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:
List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:
Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender:
Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From:
Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post:
List-Owner; bh=/z7T13eUgqD+lbHWFwjawH8v8k01KxjIc5tDsZB60qc=; b=FdIEN6JH9/WUgO
IARec77SRBu7vzOW2D/H0IhwGsOCZDI6wEtNrZ0J4cfIkpK962mbT/x+gcojUdoYjeaqAqHhG4vJt
8OX97+9xmVx12HBNU9+UVtqkDtyc7sEGcF2EyjDrmfhIi/GDRpLrXkqHZgt+I30TLxpFt4ZNAd80+
wSE=;
Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com)
by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.100.1)
(envelope-from <openvpn-devel-bounces@lists.sourceforge.net>)
id 1xOaRr-000000003yU-3P4x;
Wed, 04 Nov 2026 12:50:39 +0000
Received: from [172.30.29.66] (helo=mx.sourceforge.net)
by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.100.1)
(envelope-from <gert@blue4.greenie.muc.de>)
id 1xOaRq-000000003yN-2iiT for openvpn-devel@lists.sourceforge.net;
Wed, 04 Nov 2026 12:50:38 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References:
In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Unsubscribe-Post:List-Subscribe:List-Post:List-Owner:List-Archive;
bh=QruChIZ8ak5adKqW/7m+wWsg+8tkfI6hGVYMCbTw/qc=; b=jK4pGPpAjzkCHXO1Anvkzzf8Vp
hAPf1h/Qxg6s81VeZ9blK+0w0WIFl5hODzOsq2sSjVMnbD338JkcO/BCBwTvYxbeuXvc7195EDJJJ
aSNGaGIr7d/o9fzO+SbwPOe/bI91Jq/4gAKnLR54MTrW7AB1+G5PHVSKMbIp5HmgnIjY=;
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x
;
h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:
Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID:
Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=QruChIZ8ak5adKqW/7m+wWsg+8tkfI6hGVYMCbTw/qc=; b=SGoaKGan/JKawgM9ogYenWQY2X
qA4O1owQ6ZXTL8badYDKoHiBBqkaT5AZpg4devzJT6rPiV5SlcprFR39WJEuwcu0qXF7GgEVgNbPO
7HeU0NRGeaH+xYwM5+O92FUvWbrrjg4oQ0Gf7tslDwqdMrbmDzHRXTeN3dXk/6CjRBog=;
Received: from [193.149.48.129] (helo=blue.greenie.muc.de)
by sfi-mx-2.v28.lw.sourceforge.com with esmtps
(TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.100.1)
id 1xOaRo-000000002r6-1yIL for openvpn-devel@lists.sourceforge.net;
Wed, 04 Nov 2026 12:50:38 +0000
Received: from blue.greenie.muc.de (localhost [127.0.0.1])
by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 6A4CoTWh018726
for <openvpn-devel@lists.sourceforge.net>; Wed, 4 Nov 2026 13:50:29 +0100
Received: (from gert@localhost)
by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 6A4CoTMl018725
for openvpn-devel@lists.sourceforge.net; Wed, 4 Nov 2026 13:50:29 +0100
From: Gert Doering <gert@greenie.muc.de>
To: openvpn-devel@lists.sourceforge.net
Date: Wed, 4 Nov 2026 13:50:25 +0100
Message-ID: <20261104125029.18712-1-gert@greenie.muc.de>
X-Mailer: git-send-email 2.55.0
In-Reply-To:
<gerrit.1793776745000.Ieee93e625bd25f1f674ce1c3b6475fd73770c73f@gerrit.openvpn.net>
References:
<gerrit.1793776745000.Ieee93e625bd25f1f674ce1c3b6475fd73770c73f@gerrit.openvpn.net>
MIME-Version: 1.0
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software,
running on the system "sfi-spamd-1.hosts.colo.sdot.me",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: From: Razvan Cojocaru <razvanc@mailbox.org> The flags
argument
takes S_* values. M_WARN shares no bits with them, so this is no functional
change. Change-Id: Ieee93e625bd25f1f674ce1c3b6475fd73770c73f Signed-off-by:
Razvan Cojocaru <razvanc@mailbox.org> Acked-by: Frank Lichtenheld
<frank@lichtenheld.com>
Gerrit URL: https://gerrit.openvpn.net/c/o [...]
Content analysis details: (1.3 points, 5.0 required)
pts rule name description
---- ----------------------
--------------------------------------------------
1.3 RDNS_NONE Delivered to internal network by a host with no rDNS
X-Headers-End: 1xOaRo-000000002r6-1yIL
Subject: [Openvpn-devel] [PATCH v1] lladdr: pass S_* flags, not M_WARN,
to openvpn_execve_check()
X-BeenThere: openvpn-devel@lists.sourceforge.net
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <openvpn-devel.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/options/openvpn-devel>,
<mailto:openvpn-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive:
<http://sourceforge.net/mailarchive/forum.php?forum_name=openvpn-devel>
List-Post: <mailto:openvpn-devel@lists.sourceforge.net>
List-Help: <mailto:openvpn-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/openvpn-devel>,
<mailto:openvpn-devel-request@lists.sourceforge.net?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: openvpn-devel-bounces@lists.sourceforge.net
X-getmail-retrieved-from-mailbox: Inbox
X-GMAIL-THRID: 1880932106585990990
X-GMAIL-MSGID: 1880932106585990990
|
| Series |
[Openvpn-devel,v1] lladdr: pass S_* flags, not M_WARN, to openvpn_execve_check()
|
|
Commit Message
Gert Doering
Nov. 4, 2026, 12:50 p.m. UTC
From: Razvan Cojocaru <razvanc@mailbox.org> The flags argument takes S_* values. M_WARN shares no bits with them, so this is no functional change. Change-Id: Ieee93e625bd25f1f674ce1c3b6475fd73770c73f Signed-off-by: Razvan Cojocaru <razvanc@mailbox.org> Acked-by: Frank Lichtenheld <frank@lichtenheld.com> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2119 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2119 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Frank Lichtenheld <frank@lichtenheld.com>
diff --git a/src/openvpn/lladdr.c b/src/openvpn/lladdr.c index 195245f..554975c 100644 --- a/src/openvpn/lladdr.c +++ b/src/openvpn/lladdr.c @@ -36,7 +36,7 @@ struct argv argv = argv_new(); argv_printf(&argv, IFCONFIG_LLADDR_FMT, IFCONFIG_PATH, ifname, lladdr); argv_msg(M_INFO, &argv); - int r = openvpn_execve_check(&argv, es, M_WARN, "ERROR: Unable to set link layer address."); + int r = openvpn_execve_check(&argv, es, 0, "ERROR: Unable to set link layer address."); argv_free(&argv); return r; #else