[Openvpn-devel,v1] lladdr: pass S_* flags, not M_WARN, to openvpn_execve_check()

Message ID 20261104125029.18712-1-gert@greenie.muc.de
State New
Headers
Series [Openvpn-devel,v1] lladdr: pass S_* flags, not M_WARN, to openvpn_execve_check() |

Commit Message

Gert Doering Nov. 4, 2026, 12:50 p.m. UTC
  From: Razvan Cojocaru <razvanc@mailbox.org>

The flags argument takes S_* values. M_WARN shares no bits with them,
so this is no functional change.

Change-Id: Ieee93e625bd25f1f674ce1c3b6475fd73770c73f
Signed-off-by: Razvan Cojocaru <razvanc@mailbox.org>
Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2119
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2119
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Frank Lichtenheld <frank@lichtenheld.com>
  

Patch

diff --git a/src/openvpn/lladdr.c b/src/openvpn/lladdr.c
index 195245f..554975c 100644
--- a/src/openvpn/lladdr.c
+++ b/src/openvpn/lladdr.c
@@ -36,7 +36,7 @@ 
     struct argv argv = argv_new();
     argv_printf(&argv, IFCONFIG_LLADDR_FMT, IFCONFIG_PATH, ifname, lladdr);
     argv_msg(M_INFO, &argv);
-    int r = openvpn_execve_check(&argv, es, M_WARN, "ERROR: Unable to set link layer address.");
+    int r = openvpn_execve_check(&argv, es, 0, "ERROR: Unable to set link layer address.");
     argv_free(&argv);
     return r;
 #else