From patchwork Tue Nov 10 15:00:55 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5655 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:6022:20a6:b0:11a:a05e:cb97 with SMTP id 38csp1178122lad; Tue, 10 Nov 2026 07:01:14 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErEjS3jsse7hxbh/rTsIzUMcmV78cMeUepe4AAw26DP61vLToUDTW9bmMJUKSWqxlkWzOo2yGZLkxz0=@openvpn.net X-Received: by 2002:a4a:e845:0:b0:716:c529:7e35 with SMTP id 006d021491bc7-718994ae2a3mr1388379eaf.36.1794322873550; Tue, 10 Nov 2026 07:01:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794322873; cv=none; d=google.com; s=arc-20260327; b=S7sUDwtcvALnY0dBxAqGrScDB2uCf/MYUBXfseuEUpeUIjrIKIGqq17sCTp2XBL4nX Cw2/lz39Fr5Tn8yIKgr4YYSNxGLPoBgUwg17LeGS/ag1aAthUwkaJpg5MM3+b3uSdoGP LiOf9YpKFXQI/nSEL2BgPm+7cMto3jfQRp7s5nWcLGqpfQ+GrcBCkOeaVYUw5YqoL3DQ rOpvloFw0ppkHoBBsaBPh/yDHHeBOUhLl/NV7o/rCrbj7JVYyI9Vpna9wAMyhmui+Lwz r1bjpTY8WOfbQbwlKHOltHToRHAhVEzVCVBLDpoQfzdSB8JhJr/09k+VdY44FIm0/JNN Ix9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=vZ7VgQbvTRC+Un+e3JUMxxDsUGmyJCLri2hR0YOuCs0=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=swYOMeXmpFw8RpJon9iGhDp65KFJBQCYGfSJ5bSbtll7modOWBVuZr21fx2KB5FeXM pHgIKB/6Mmfrgbgdx9Ox+qv+vBwaJ0XP92pg+f6xZldn5xUjbcE3CEL9jQQX/KjKa+E2 NNwqZjPbBy/i85ZmkzEdZ9or5Iw3sab9oNbMZCislZa0rl1xXhgSpBs1+MEEEl7vbxJT hUrc/Cb+AvzWIOd2LZNUefLT/w80zaok021rA0AKYM2zIkM2CXl48nJv7QLXiKTwb59i dC78x5E7q7DC2SMA9OYcYCHBdzQ2sC8rI2L/STLa2f3nsKXY6vkXxHPnVl+j1jNNB7Gv geQQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=NI1rCHMT; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=UPuth98B; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=dbqOLNKP; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-4ae2320094fsi2801943fac.367.2026.11.10.07.01.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Nov 2026 07:01:13 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=NI1rCHMT; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=UPuth98B; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=dbqOLNKP; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=vZ7VgQbvTRC+Un+e3JUMxxDsUGmyJCLri2hR0YOuCs0=; b=NI1rCHMTax0qJl 8mqxI4TvXYRhtcZ1argoYsLvajB9XBVhjE7H9IU/44DT2SK7c6Sv9+uuxIwuIOPltu4MwtZaxSeYj YklMBlEIe94+fln8RIKcmaQ0y8KrKBRRfj4RtjQjMvD0rYh1rrvtJdcSQrnT1jxLujL4kzEfHfWfD bw8=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.100.1) (envelope-from ) id 1xQnLT-000000002Oh-2fkh; Tue, 10 Nov 2026 15:01:11 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xQnLS-000000002OY-1unr for openvpn-devel@lists.sourceforge.net; Tue, 10 Nov 2026 15:01:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Unsubscribe-Post:List-Subscribe:List-Post:List-Owner:List-Archive; bh=iyto1FqbfVce/XSzmeF+v62y818cnyaHdbcei/N6GVg=; b=UPuth98BLae8yFxBatuiM50q/L a8Blw29+YZrBe2ajX0jMwb5m0ALZEIPpc4Hy04U+aAkp+zSlJpPfmVtFdm8WOIVV06Fc1SXQClpUI CfQP/LSmZ5a6Sfxyi8gqw7D/86zsWMbqhgsIIlaY6EToS1aUs85fWac04+5nHBMh0a4M=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=iyto1FqbfVce/XSzmeF+v62y818cnyaHdbcei/N6GVg=; b=dbqOLNKPoNvWQDreC6/GkRXuxR 1M7PhNwu4++hCC5ZMe5KZCY9znKk12ujhCsXLudF/DN32U9WDVOA8vAHYpvWKcQeH433S/QSZ7Euq tZm3iT5vkxi9JakG+bxcXCrjDy/ht/eRIlrDhodiFOO/t978oqccbWHQp4ujZf87oLl8=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.100.1) id 1xQnLP-000000000dP-2IFq for openvpn-devel@lists.sourceforge.net; Tue, 10 Nov 2026 15:01:10 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 6AAF10Yh017837 for ; Tue, 10 Nov 2026 16:01:00 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 6AAF10g4017836 for openvpn-devel@lists.sourceforge.net; Tue, 10 Nov 2026 16:01:00 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Tue, 10 Nov 2026 16:00:55 +0100 Message-ID: <20261110150100.17824-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Razvan Cojocaru The ciphername/authname copies are overwritten by the dest->options = src->options assignment that follows, and the trailing IS_SIG() return is a no-op. Change-Id: I5a827f4c6d169420504a48e13ee6eb28053dbc4c Signed-off-by: Razvan Cojocaru Acked-by: Frank Lichtenheld Gerrit URL: https://gerrit.openvpn.net/c/o [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1xQnLP-000000000dP-2IFq Subject: [Openvpn-devel] [PATCH v1] init: drop dead code in inherit_context_child() X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1881483901659866324 X-GMAIL-MSGID: 1881483901659866324 From: Razvan Cojocaru The ciphername/authname copies are overwritten by the dest->options = src->options assignment that follows, and the trailing IS_SIG() return is a no-op. Change-Id: I5a827f4c6d169420504a48e13ee6eb28053dbc4c Signed-off-by: Razvan Cojocaru Acked-by: Frank Lichtenheld Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2167 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2167 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Frank Lichtenheld diff --git a/src/openvpn/init.c b/src/openvpn/init.c index 3bc4de4..bf88213 100644 --- a/src/openvpn/init.c +++ b/src/openvpn/init.c @@ -4871,9 +4871,6 @@ dest->c1.ks.tls_wrap_key = src->c1.ks.tls_wrap_key; dest->c1.ks.tls_auth_key_type = src->c1.ks.tls_auth_key_type; dest->c1.ks.tls_crypt_v2_server_key = src->c1.ks.tls_crypt_v2_server_key; - /* inherit pre-NCP ciphers */ - dest->options.ciphername = src->options.ciphername; - dest->options.authname = src->options.authname; /* inherit auth-token */ dest->c1.ks.auth_token_key = src->c1.ks.auth_token_key; @@ -4930,10 +4927,6 @@ } init_instance(dest, src->c2.es, CC_NO_CLOSE | CC_USR1_TO_HUP); - if (IS_SIG(dest)) - { - return; - } } void