From patchwork Thu Nov 12 06:39:07 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5676 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:6022:529c:b0:11a:a05e:cb97 with SMTP id x28csp1498832lax; Wed, 11 Nov 2026 22:39:26 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErFkWFIB7mMdtScZ0JjpzweWlMpLBB0Dno5JZrorDsK8kzngzdfpcfNA+PHMgVz7mizKgBvYQA7uwkA=@openvpn.net X-Received: by 2002:a05:7023:d0d:b0:1ae:e0f5:2cdd with SMTP id a92af1059eb24-1b3c0324aa4mr4425384c88.28.1794465566126; Wed, 11 Nov 2026 22:39:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794465566; cv=none; d=google.com; s=arc-20260327; b=VbD3vLgdN0wQg+u4n9obKxoAcEIBQiESUwwaIaNg73+aNHJy8wS3f/hqI0b6qkmPlM u/zIU57MqDN/VstdQCeukELbBrwhogndaGWnQNtwuMqnTXe5nKiRyZ2990Yv4GnICdJF 2rB4bIaKey7q7GerULFx4N2o7+7bHUHM7G4so1K7Ef5Qu17x1tkIZaKDosOuxFgx53fn a4VITFoV9FqfdiAbwuR+S8+DamDmPtSgeWzG2NFoCbAoah4GdJHXB5Smglp2XCenKu0I fnRr0f0h/8hyNuVK8ao4GLzo4kBYTMgiR/MaTCryoQtKgMbApIImdHeSahCs9SfFNTM0 6Tyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=19QsItV7NTpX8P4imby17+s4+iuDIzTXHPEVLbvuW5U=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=QWKnRtVw0Hp+OzOQNLibSJkXGVlrdbVcFeuUpweEHIk49xnMWwgg8UktRRKcNpGx6R qAEYDUS/uYKij74XIIjKrOOYCHIqXs9/8AuID60DrUoj3hUmcxiTk32e4Y7gUEO/lqnN VS27JRGwznog3ClJE65zS6yi9TrEeREsJOov1SVwvvPdI/jZro8m+cxv9DlflKM9ctcf dh7T1laC8zMpJoJaX+avyByheJuY9HnwXWk+pKNdY9m+PfJUhfX3N92bY7HyV3nLjtxI 61u+DF1ngOOK7jJXP2xXS1F7+W1DpxtgeLYdAfuz1+rkxJkK187hWksuXzILO2D76pLd hC/A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=fK7MUNqo; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=S8DENX9x; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=BR1h2mKk; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id a92af1059eb24-1b3b5b5fcc8si23099495c88.19.2026.11.11.22.39.25 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Nov 2026 22:39:26 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=fK7MUNqo; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=S8DENX9x; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=BR1h2mKk; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=19QsItV7NTpX8P4imby17+s4+iuDIzTXHPEVLbvuW5U=; b=fK7MUNqo5Wsg/d 07Rm1bJw15e2fxSqpaSt9o7UhnzeLpFbB5GyKxEldDudIkBE3CaPZPvDg9vE1KUerOnT/34NlgK6Y MmiRPFzm1dn1OMyAbHFLUcPhwawgjiqnxl2/qQJobEZHGJsefSi0r8iiY6lrJWlAcovwv9+RrkqO2 mDE=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.100.1) (envelope-from ) id 1xROSy-000000005Ls-0986; Thu, 12 Nov 2026 06:39:24 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xROSx-000000005Lm-0tDj for openvpn-devel@lists.sourceforge.net; Thu, 12 Nov 2026 06:39:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Unsubscribe-Post:List-Subscribe:List-Post:List-Owner:List-Archive; bh=0i6V3quesO044i4goZ/k05ZtjthBUVyo0DPYlgYcRa4=; b=S8DENX9xki/LoW6ZoWSMOjieB8 ZTu1Rxlz4Z2M4wLrpWzp8BTn9s73m+pxjJhQ42cfoV7PXinz6tpk9uCV5xtsokzMPOFl8LKLcUNK5 FXSF2sckuQ8IMZoP/hyDojQUPtGQRMdFt+2r5o1sM0Gq5nEmu1dzMb3QcjYgN1mqNQhw=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=0i6V3quesO044i4goZ/k05ZtjthBUVyo0DPYlgYcRa4=; b=BR1h2mKk1L8N+hxsXx3VM2bD32 VQbC8V5ukn+Utc4cYRjdZ4O7aoKDhGsOIAcfkeVmdZ82i2wKb0Y4WzRJqA7Cs1jwRlnLuOREydrBh nswz1bmWEiBJx89Hlg13E7XeXj+pbI4XhkOAm/B46tX9K/qUGjug8OHnffwuW4Y1MVBA=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.100.1) id 1xROSu-0000000021g-0dj3 for openvpn-devel@lists.sourceforge.net; Thu, 12 Nov 2026 06:39:23 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 6AC6dDNO024603 for ; Thu, 12 Nov 2026 07:39:13 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 6AC6dDNJ024602 for openvpn-devel@lists.sourceforge.net; Thu, 12 Nov 2026 07:39:13 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Thu, 12 Nov 2026 07:39:07 +0100 Message-ID: <20261112063912.24551-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Razvan Cojocaru The domains string was only freed when the search list key could be opened. Free it unconditionally, as the caller frees the undo data right after. Broken since ae90cbad ("dns: support multiple domains without DHCP"). Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URI: openvpn.net] 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1xROSu-0000000021g-0dj3 Subject: [Openvpn-devel] [PATCH v1] openvpnserv: always free the domains in UndoDnsSearchDomains() X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1881580558183064957 X-GMAIL-MSGID: 1881633525076321866 From: Razvan Cojocaru The domains string was only freed when the search list key could be opened. Free it unconditionally, as the caller frees the undo data right after. Broken since ae90cbad ("dns: support multiple domains without DHCP"). Change-Id: Idf378bb5af0b2b4e8d746e252159b756e96c37fb Signed-off-by: Razvan Cojocaru Acked-by: Antonio Quartulli Acked-by: Heiko Hund Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2160 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2160 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Antonio Quartulli Heiko Hund diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c index 81205d6..710a797 100644 --- a/src/openvpnserv/interactive.c +++ b/src/openvpnserv/interactive.c @@ -1754,10 +1754,10 @@ RemoveDnsSearchDomains(dns_searchlist_key, undo_data->domains); RegCloseKey(dns_searchlist_key); ApplyDnsSettings(gpol); - - free(undo_data->domains); - undo_data->domains = NULL; } + + free(undo_data->domains); + undo_data->domains = NULL; } /**