| Message ID | 20261115170015.10294-1-gert@greenie.muc.de |
|---|---|
| State | New |
| Headers |
Return-Path: <openvpn-devel-bounces@lists.sourceforge.net>
Delivered-To: patchwork@openvpn.net
Received: by 2002:a05:6022:9292:b0:11a:f58a:e788 with SMTP id
dc18csp285384lab;
Sun, 15 Nov 2026 09:00:26 -0800 (PST)
X-Forwarded-Encrypted: i=2;
AL+hErGaFEV1an42ESAi1sEOOwtHTHMPlS6Jib5vNBrpYjf3Z+FLwdj7OJOwIEsL1KMd1t2q8btyDcFE/Hk=@openvpn.net
X-Received: by 2002:a05:7023:c006:b0:1b3:a87d:a6b6 with SMTP id
a92af1059eb24-1b503163eaemr7338697c88.42.1794762026143;
Sun, 15 Nov 2026 09:00:26 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1794762026; cv=none;
d=google.com; s=arc-20260327;
b=iX2OXK/Pj2wfdaNgJY8ZIyfp+6pgexXg/99uKl2PxC1ExP4unPFI+2qPFAHzEApgWd
MRutIiYyiLTtwsaXYOknut/d4QZP9f4PvanBBgTdyHUKdX9VQswbGvcsdfoPNknQsLyT
smvZaBDKCVE/W13YJkiig2dwb6ytZW/VV3OCIxLoNrtpYxgMS0rrP8ia5qKbFziFdsAo
HkY2Ho2kb8rcs9n1Jah1mJNLpb8f4kOIGuiPD4Wi0Q75gISmFVTcx8touW5KnxHtZzRg
RBv9+2vjGPwLfXfbndxKPiauZQZymvNacWHS46TJbJ15IjAdixqK5MW74/FBzCD5GlzQ
L4pg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20260327;
h=errors-to:content-transfer-encoding:list-subscribe:list-help
:list-post:list-archive:list-unsubscribe:list-id:precedence:subject
:mime-version:references:in-reply-to:message-id:date:to:from
:dkim-signature:dkim-signature:dkim-signature;
bh=FjZuz8dTBSQ3x2pwkiCtXGy85uRzbQMkL5+329VgPws=;
fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=;
b=THpnS807BYS54cXhWp7MKMENtOr/e0nHFBz4FArdb/UR8Kxx//fJnUwH4c9vo2Rt1y
AtIWN6WtqGrZQtdK8DJ9NOqPwifyry4JEDEvSs7fjjCmncG7LVyVI91yqn3UVKo9O3S5
CijHyy3ajM2+n0TXcyJZKAZzbLjNZgGnancNUvWOUW+mOUYlluWlkmKUM4SJ6d7wJ/Fv
fB8kgBxRZmqHdtzKlzwCcl6d1AQXUmxzGMjSB/yeP9vpOcXcRKdO0i0MjHL5TEnsDKhu
8wS1FXHb1uNRH5Ni8GPSj3xwJNmKEoy+3noI2MtrKE9zAt14+ttHsFNZ/GjudREN2kTJ
Ec0w==;
dara=google.com
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@lists.sourceforge.net header.s=beta
header.b=DPna6LAf;
dkim=neutral (body hash did not verify) header.i=@sourceforge.net
header.s=x header.b=eyLq0AxU;
dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x
header.b=ZgPWhoCm;
spf=pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de
Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7])
by mx.google.com with ESMTPS id
a92af1059eb24-1b510c6c081si18288034c88.15.2026.11.15.09.00.25
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Sun, 15 Nov 2026 09:00:26 -0800 (PST)
Received-SPF: pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) client-ip=216.105.38.7;
Authentication-Results: mx.google.com;
dkim=pass header.i=@lists.sourceforge.net header.s=beta
header.b=DPna6LAf;
dkim=neutral (body hash did not verify) header.i=@sourceforge.net
header.s=x header.b=eyLq0AxU;
dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x
header.b=ZgPWhoCm;
spf=pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:
List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:
Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender:
Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From:
Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post:
List-Owner; bh=FjZuz8dTBSQ3x2pwkiCtXGy85uRzbQMkL5+329VgPws=; b=DPna6LAfnMlLov
x77A2xGzjkSBeziPEbOHO21oA1hWKEb8ko38nnC8WmZF5IO6bveUaFqvPUaQ4oyvZ7pPjAm9XT6TX
mX266t2cXhpoyDjbzxhgAI/1LvFC6gXrP/xsZ10KxfGyfcu1M9AT/Ui95YXjXUSMBbTD6YwQkKGWp
ZN8=;
Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com)
by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.100.1)
(envelope-from <openvpn-devel-bounces@lists.sourceforge.net>)
id 1xSdab-000000004D1-0sdY;
Sun, 15 Nov 2026 17:00:25 +0000
Received: from [172.30.29.66] (helo=mx.sourceforge.net)
by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.100.1)
(envelope-from <gert@blue4.greenie.muc.de>)
id 1xSdaa-000000004Cq-0H9l for openvpn-devel@lists.sourceforge.net;
Sun, 15 Nov 2026 17:00:24 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References:
In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Unsubscribe-Post:List-Subscribe:List-Post:List-Owner:List-Archive;
bh=JotvMQIueXBZFkWYP9hqhYvfsxHqqMc/pwdQf3Y9h7w=; b=eyLq0AxUejrcTrmEQgE3wmlai6
KlzL3eYyE2Y0OltrkYvtS5f0UgmveDE4+ezw4JumLzoI+y+TLKloB09Lc56RqNq0eEUUvbIC8gsBc
XXoKneQjgjuf9WCD4XnBIidUD6odihzLegs+ii983hsmElbHA9k1aGpT26xcYCGoZd24=;
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x
;
h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:
Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID:
Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=JotvMQIueXBZFkWYP9hqhYvfsxHqqMc/pwdQf3Y9h7w=; b=ZgPWhoCmsp+fgXK8H7e7gW7hB6
QOgMxGG1VoA5nlpCQgk697qI7XwryR9Osbvkrio03oDLge4LkjRxEJ1gAhvLcFsRWgrRY1c0o9wwn
SUyHGh+BrVfeJV12S3k+0wb3X16ltOp57YIDyTC28tkdZGQMFRniV4bgAZqAYeNrLgdE=;
Received: from [193.149.48.129] (helo=blue.greenie.muc.de)
by sfi-mx-2.v28.lw.sourceforge.com with esmtps
(TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.100.1)
id 1xSdaZ-0000000054Y-0Ilq for openvpn-devel@lists.sourceforge.net;
Sun, 15 Nov 2026 17:00:23 +0000
Received: from blue.greenie.muc.de (localhost [127.0.0.1])
by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 6AFH0Gjr010319
for <openvpn-devel@lists.sourceforge.net>; Sun, 15 Nov 2026 18:00:16 +0100
Received: (from gert@localhost)
by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 6AFH0G4Z010318
for openvpn-devel@lists.sourceforge.net; Sun, 15 Nov 2026 18:00:16 +0100
From: Gert Doering <gert@greenie.muc.de>
To: openvpn-devel@lists.sourceforge.net
Date: Sun, 15 Nov 2026 18:00:10 +0100
Message-ID: <20261115170015.10294-1-gert@greenie.muc.de>
X-Mailer: git-send-email 2.55.0
In-Reply-To:
<gerrit.1794653707000.Ib8a47751bb0d559083d1a50aab82c06fb0dad110@gerrit.openvpn.net>
References:
<gerrit.1794653707000.Ib8a47751bb0d559083d1a50aab82c06fb0dad110@gerrit.openvpn.net>
MIME-Version: 1.0
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software,
running on the system "sfi-spamd-2.hosts.colo.sdot.me",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: From: Razvan Cojocaru <razvanc@mailbox.org> With
--enable-pam-dlopen,
auth-pam.c calls dlerror() without a declaration. Broken since ce8271f5.
Change-Id: Ib8a47751bb0d559083d1a50aab82c06fb0dad110 Signed-off-by: Razvan
Cojocaru <razvanc@mailbox.org> Acked-by: Gert Doering <gert@greenie.muc.de>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/ [...]
Content analysis details: (1.3 points, 5.0 required)
pts rule name description
---- ----------------------
--------------------------------------------------
1.3 RDNS_NONE Delivered to internal network by a host with no rDNS
X-Headers-End: 1xSdaZ-0000000054Y-0Ilq
Subject: [Openvpn-devel] [PATCH v1] auth-pam: Include dlfcn.h for dlerror()
X-BeenThere: openvpn-devel@lists.sourceforge.net
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <openvpn-devel.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/options/openvpn-devel>,
<mailto:openvpn-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive:
<http://sourceforge.net/mailarchive/forum.php?forum_name=openvpn-devel>
List-Post: <mailto:openvpn-devel@lists.sourceforge.net>
List-Help: <mailto:openvpn-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/openvpn-devel>,
<mailto:openvpn-devel-request@lists.sourceforge.net?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: openvpn-devel-bounces@lists.sourceforge.net
X-getmail-retrieved-from-mailbox: Inbox
X-GMAIL-THRID: 1881944386206702505
X-GMAIL-MSGID: 1881944386206702505
|
| Series |
[Openvpn-devel,v1] auth-pam: Include dlfcn.h for dlerror()
|
|
Commit Message
Gert Doering
Nov. 15, 2026, 5 p.m. UTC
From: Razvan Cojocaru <razvanc@mailbox.org> With --enable-pam-dlopen, auth-pam.c calls dlerror() without a declaration. Broken since ce8271f5. Change-Id: Ib8a47751bb0d559083d1a50aab82c06fb0dad110 Signed-off-by: Razvan Cojocaru <razvanc@mailbox.org> Acked-by: Gert Doering <gert@greenie.muc.de> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2184 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2184 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering <gert@greenie.muc.de>
Comments
I still tend towards "just rip out the whole dlopen()" thing, but in
the meantime we can as well repair it ;-) - so here go, straightforward
enough.
Your patch has been applied to the master and release/2.7 branch (bugfix).
commit 59e30622405b59197d32d839cf5185521a0b1088 (master)
commit 3c367c6c36498fa18cacc87394ea2144844d592f (release/2.7)
Author: Razvan Cojocaru
Date: Sun Nov 15 18:00:10 2026 +0100
auth-pam: Include dlfcn.h for dlerror()
Signed-off-by: Razvan Cojocaru <razvanc@mailbox.org>
Acked-by: Gert Doering <gert@greenie.muc.de>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2184
Message-Id: <20261115170015.10294-1-gert@greenie.muc.de>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg41375.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
--
kind regards,
Gert Doering
diff --git a/src/plugins/auth-pam/auth-pam.c b/src/plugins/auth-pam/auth-pam.c index 0cd201d..72c047d 100644 --- a/src/plugins/auth-pam/auth-pam.c +++ b/src/plugins/auth-pam/auth-pam.c @@ -32,6 +32,7 @@ #include <security/pam_appl.h> #ifdef USE_PAM_DLOPEN +#include <dlfcn.h> #include "pamdl.h" #endif