[Openvpn-devel,v1] auth-pam: Include dlfcn.h for dlerror()

Message ID 20261115170015.10294-1-gert@greenie.muc.de
State New
Headers
Series [Openvpn-devel,v1] auth-pam: Include dlfcn.h for dlerror() |

Commit Message

Gert Doering Nov. 15, 2026, 5 p.m. UTC
  From: Razvan Cojocaru <razvanc@mailbox.org>

With --enable-pam-dlopen, auth-pam.c calls dlerror() without a
declaration. Broken since ce8271f5.

Change-Id: Ib8a47751bb0d559083d1a50aab82c06fb0dad110
Signed-off-by: Razvan Cojocaru <razvanc@mailbox.org>
Acked-by: Gert Doering <gert@greenie.muc.de>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2184
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2184
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Gert Doering <gert@greenie.muc.de>
  

Comments

Gert Doering Nov. 15, 2026, 9:51 p.m. UTC | #1
I still tend towards "just rip out the whole dlopen()" thing, but in
the meantime we can as well repair it ;-) - so here go, straightforward
enough.

Your patch has been applied to the master and release/2.7 branch (bugfix).

commit 59e30622405b59197d32d839cf5185521a0b1088 (master)
commit 3c367c6c36498fa18cacc87394ea2144844d592f (release/2.7)
Author: Razvan Cojocaru
Date:   Sun Nov 15 18:00:10 2026 +0100

     auth-pam: Include dlfcn.h for dlerror()

     Signed-off-by: Razvan Cojocaru <razvanc@mailbox.org>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2184
     Message-Id: <20261115170015.10294-1-gert@greenie.muc.de>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg41375.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering
  

Patch

diff --git a/src/plugins/auth-pam/auth-pam.c b/src/plugins/auth-pam/auth-pam.c
index 0cd201d..72c047d 100644
--- a/src/plugins/auth-pam/auth-pam.c
+++ b/src/plugins/auth-pam/auth-pam.c
@@ -32,6 +32,7 @@ 
 #include <security/pam_appl.h>
 
 #ifdef USE_PAM_DLOPEN
+#include <dlfcn.h>
 #include "pamdl.h"
 #endif