From patchwork Mon Nov 16 13:28:23 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5713 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:6022:9292:b0:11a:f58a:e788 with SMTP id dc18csp1210616lab; Mon, 16 Nov 2026 05:28:57 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErHXJSfZiRRIswuRaZuwOrwrQRjvPtJoL0jMCHRdQ/bwfXrw4Tf1FVQ5KeDAo3xA/+F/gS3bCtT64M4=@openvpn.net X-Received: by 2002:a05:7300:de09:b0:36a:18d2:8c79 with SMTP id 5a478bee46e88-3796676b135mr9957410eec.19.1794835737357; Mon, 16 Nov 2026 05:28:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794835737; cv=none; d=google.com; s=arc-20260327; b=SddSwUd3eVCQZhECiuzMEhANBlJj5+5Gbh4dlxp0IwDN6ZORpY6VfKaBQerd2B/bwl eX9irH+cj503bguBVYstdKvnMcnh3x+Qt0GUH2ycCzQzvfLlxDKvwYcyNMZfY2ZycUT4 fj/Q5TbYsgdiafqYqWyjTLBiXPmVRGy8lRX8ypOc59TEcYX82lg5Rfr+rGQTQzZsPyo7 ad4KsD3Dai8DnMJ1TeCIMmqkPhOBy9lsRBHydz4lqP1a/kbTLq3zbacJjhgk7Y1Z9saD 5gap0G34377Ad0GA6rRSPgTdCeHnH8c11FPw3Pyzubch5mu8mia0E0rtrEgenITObPoB jbKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=YOO1frWnbrL+n8PvsIP/WOBYn1uf+d0EGb4rfMr93fs=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=Z4BPtKZZhsOE00ueoXkm9Ge2V4qfWLCV6QVSelYsQ9Zt6R/k6pP3CaDuY6pzilCwMV WwKi/fY3/BoSh3P7LTLEF4HBTDxI3Hm8uIZTbnhBYtBjUTd6xeIFsViXUW82pACbKqfr w+2kzk84aAi+CvoccZEo2sKgr2ZaNirofoG/ZXQ/eaXk7DAPfvpMXjcRMTRVv32ssJsS 7a6lkbskam2DSOWFCBFw99YYEliihZeIhhpgP+AMvyeBU1rNXDDpNEOANOD9t83bSoPi J9BP8KCp7fJ6wt274ISsprVSAHkAHW/d43b8fJV1uMq1FwSLqfsWMRSnpHDgPGc1E7Yd 7j1Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=AKmA1dMK; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=hrrrvXgi; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=UmmiC9zs; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 5a478bee46e88-3795a0973basi28731584eec.36.2026.11.16.05.28.56 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Nov 2026 05:28:57 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=AKmA1dMK; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=hrrrvXgi; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=UmmiC9zs; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=YOO1frWnbrL+n8PvsIP/WOBYn1uf+d0EGb4rfMr93fs=; b=AKmA1dMKo+VToO gs/RzUwIBRaCA0j6jq8b9OmFQn5lXdSzDBgu12oEVwMKtNMS922mkmEDF6oLnOlj8+hgMgLDPDx6e HGDpd/WNI+sO0uWGzbQCvra1wpw0ugvw71dFlrMn9v4NnBtCcIc/jQ0R45gD5721VH5sGHiYLgBo/ QUo=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.100.1) (envelope-from ) id 1xSwlS-000000002SD-1Bx6; Mon, 16 Nov 2026 13:28:54 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xSwlB-000000002Rp-0n1I for openvpn-devel@lists.sourceforge.net; Mon, 16 Nov 2026 13:28:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Unsubscribe-Post:List-Subscribe:List-Post:List-Owner:List-Archive; bh=dnsNlRhIQZYMjjBZfRCJQygPFSKy0M+AGS6nTgquvhc=; b=hrrrvXgiBhV4nwpaYYJRf2MP0g NqLNTO5HKn2uo0JzQHQ8T8YohYsyuBpIzbJwgXJXJdRqOAcOcPqvpv+aRdv9w/Bw5vIxEsEXvn3kU f0BQGfVfM2AjSXgpDrlz0gFlzBTzO7+kRgwaSRi3GmYfWzWhD3azKOuHPrLecBNJp2Z4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dnsNlRhIQZYMjjBZfRCJQygPFSKy0M+AGS6nTgquvhc=; b=UmmiC9zsRr2jTaAMZnck3WdfLM xD9OfR16LxRSHxBUJRZPSthXK6nAASsi6drEklyWkh4HPDMdLks/kI2BzRlS+TErojA2q4CZIRxmT YhOd5WOgEWTbuwUOHNsU5H1Z79mAx9tdTRTSUzzDHBM/Z7zFwcTBSWPayPqiwyQgOGDk=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.100.1) id 1xSwl9-000000007Ln-1mDS for openvpn-devel@lists.sourceforge.net; Mon, 16 Nov 2026 13:28:37 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 6AGDSSmw031958 for ; Mon, 16 Nov 2026 14:28:28 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 6AGDSSmk031957 for openvpn-devel@lists.sourceforge.net; Mon, 16 Nov 2026 14:28:28 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Mon, 16 Nov 2026 14:28:23 +0100 Message-ID: <20261116132828.31945-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld There are some build failures related to -Wsign-conversion now that look like clear bugs in MinGW. Since we do not plan to support 32bit Windows going forward, let's not worry too much about compiler [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1xSwl9-000000007Ln-1mDS Subject: [Openvpn-devel] [PATCH v1] GHA: Disable -Werror for MinGW 32bit X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1882021678278875699 X-GMAIL-MSGID: 1882021678278875699 From: Frank Lichtenheld There are some build failures related to -Wsign-conversion now that look like clear bugs in MinGW. Since we do not plan to support 32bit Windows going forward, let's not worry too much about compiler warnings anymore. We will still detect if we break the build completely, for now. While investigating the issue, remove a wrong comment. With -Wsign-conversion, all builds need the casts. Change-Id: I6079f454e5bb1ce7c4ecc5343ce2231c417ca879 Signed-off-by: Frank Lichtenheld Acked-by: Razvan Cojocaru Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2193 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2193 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Razvan Cojocaru diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 27f08df..d50b7ff 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -81,6 +81,10 @@ arch: [x86, x64] build: [Release, Debug] + include: + - arch: x86 + configure-args: "['-DUSE_WERROR=OFF']" + name: "gcc-mingw - ${{ matrix.arch }} - ${{ matrix.build }} - OSSL" runs-on: ubuntu-26.04 env: @@ -113,6 +117,7 @@ uses: lukka/run-cmake@5d55ea7949e25f69f0ecb516d8d572297e03a956 # v10.9 with: configurePreset: mingw-${{ matrix.arch }} + configurePresetAdditionalArgs: ${{ matrix.configure-args }} buildPreset: mingw-${{ matrix.arch }} buildPresetAdditionalArgs: "['--config ${{ matrix.build }}']" diff --git a/src/openvpn/auth_token.c b/src/openvpn/auth_token.c index 703a0b2..261c7c2 100644 --- a/src/openvpn/auth_token.c +++ b/src/openvpn/auth_token.c @@ -364,7 +364,6 @@ /* Accept session tokens only if their timestamp is in the acceptable range * for renegotiations. - * Cast is required for systems with 32bit time_t, e.g. Windows x86. */ const time_t token_reneg_deadline = (time_t)timestamp + 2 * session->opt->auth_token_renewal; bool in_renegotiation_time = now >= (time_t)timestamp && now < token_reneg_deadline;