| Message ID | 20261116173725.24585-1-gert@greenie.muc.de |
|---|---|
| State | New |
| Headers |
Return-Path: <openvpn-devel-bounces@lists.sourceforge.net>
Delivered-To: patchwork@openvpn.net
Received: by 2002:a05:6022:9292:b0:11a:f58a:e788 with SMTP id
dc18csp1552784lab;
Mon, 16 Nov 2026 09:37:36 -0800 (PST)
X-Forwarded-Encrypted: i=2;
AL+hErGrJlhf3SBEo+q0I4FdhcEe5ZOwf3n4J3ntb59Qo6aNitV9+IuJEuKawFzhOonbXtx3A59kfzAxEHU=@openvpn.net
X-Received: by 2002:a05:693c:83cb:20b0:375:388:a6d5 with SMTP id
5a478bee46e88-379675fc8fbmr10151390eec.32.1794850656297;
Mon, 16 Nov 2026 09:37:36 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1794850656; cv=none;
d=google.com; s=arc-20260327;
b=eixKFbG+ABqftvwX06CqIyRRVeMFRbMY9qko+JW+nGYlFMXMGKrW/dgR0XuwuHxZ+q
g2YpF8bcyPgPBeMIH51vB3z1L4o3RcHZ5Y7lWrxL3KfEFqY3QeFnw+zW9byLtCGFYW9A
riQEpz844qzvXj4CecDzYlNORyHGa+a2mhuLW2y1e8x4XURnBBbtRTN91dE6hrgX91LN
g8NumqigQFaGuit9rolyaxtuT0nVxXW9ZAsC8TWeE3OMGDzMwYRTP3mxLNS+jbV4RVMq
X4kbFzPO/q9y0Xxz79hGKrqhfFZqG2z6Ykc7HITQzRZgpxnRCspBQo+Gmrwj4s1Ap3uP
70zQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20260327;
h=errors-to:content-transfer-encoding:list-subscribe:list-help
:list-post:list-archive:list-unsubscribe:list-id:precedence:subject
:mime-version:references:in-reply-to:message-id:date:to:from
:dkim-signature:dkim-signature:dkim-signature;
bh=LlGKfataidE2hkqa17xvv0Ax8npOQv9bseDm0Atv9gA=;
fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=;
b=PwOJW1wEAF/kJPVIar94ER29/LJxoUi3d4VJsT1kNlkKzHD0HV6Fffj7Io/+x18jy+
aKI5jLMXVG+uojX9AWHah5eXrMNLfnexZ0MkVNoTNQldyD0ab3EJME6JeTyP9tXI7Gir
zy/mJFZW/rzvY9f65DGZkTAh6fe4r/8UxS8kpuZDEIOOBr6TBL9Cbk53e1omk+ZHKG0F
0UcPXlIua/eMpCifaCmVESgdJCqYg7j+g/cay20hykTzfTTIKraBfvDPiZPFbmrb3idt
hZ3iIuq2dALEm3rUENiMduvHbQwF8LIJ/QrXDlBpOAF9hzLngf/IAKcSwltbsgfXz1De
Ghyw==;
dara=google.com
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@lists.sourceforge.net header.s=beta
header.b=iXZtNcP8;
dkim=neutral (body hash did not verify) header.i=@sourceforge.net
header.s=x header.b=f4o87qSq;
dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x
header.b=Yp88iFez;
spf=pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de
Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7])
by mx.google.com with ESMTPS id
5a478bee46e88-3795aa70b27si31529974eec.53.2026.11.16.09.37.35
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Mon, 16 Nov 2026 09:37:36 -0800 (PST)
Received-SPF: pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) client-ip=216.105.38.7;
Authentication-Results: mx.google.com;
dkim=pass header.i=@lists.sourceforge.net header.s=beta
header.b=iXZtNcP8;
dkim=neutral (body hash did not verify) header.i=@sourceforge.net
header.s=x header.b=f4o87qSq;
dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x
header.b=Yp88iFez;
spf=pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:
List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:
Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender:
Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From:
Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post:
List-Owner; bh=LlGKfataidE2hkqa17xvv0Ax8npOQv9bseDm0Atv9gA=; b=iXZtNcP8sxhr5j
9mg0NNTvbeheKFTdwtihqOO4/xn9bBoVGdh4Bxth1a6kUyxa66MOn2Z72j2jvXFPC/+xfFfW1rYxZ
H8ihRiwr1okzvnnXHXOVHQ/0JtXZwPhusgL8EkeZp/tq6kFxUzt3ncuLTx+8kVFDp1oy4CuZnpd8U
g5M=;
Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com)
by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.100.1)
(envelope-from <openvpn-devel-bounces@lists.sourceforge.net>)
id 1xT0e6-000000006BQ-1yKK;
Mon, 16 Nov 2026 17:37:34 +0000
Received: from [172.30.29.66] (helo=mx.sourceforge.net)
by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.100.1)
(envelope-from <gert@blue4.greenie.muc.de>)
id 1xT0e5-000000006BK-3pax for openvpn-devel@lists.sourceforge.net;
Mon, 16 Nov 2026 17:37:33 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References:
In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Unsubscribe-Post:List-Subscribe:List-Post:List-Owner:List-Archive;
bh=DXP6q2ud84BrjjsM3/NysTmhFOfas9rfAQwzkNBEuz4=; b=f4o87qSqAS51+WqzzNj1mTbkwn
E67uA7dllK3Wpq8NienVg4j6No9dhGpQfY7VT8v2VbAvMSJMXzHlodXqoF4ANOnfl9B3HQlnPz0ak
+aHR+ufG2M1nyc35lHRKAyiHJ6ndnA0TJYix5vzdXpw/09B9vlf8DpXY90HJRmwjISus=;
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x
;
h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:
Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID:
Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=DXP6q2ud84BrjjsM3/NysTmhFOfas9rfAQwzkNBEuz4=; b=Yp88iFezduRo20yIgBlPxke0HY
DYPMDm5Wj2vcLKZUogfE0I9ZM2wMofYnlbWY6vNCFICQenABzOTap4w8WgWIO9WT6DHUuY1YOhqP5
gXpo8Nepas+xTgHWjrbTP7h6qVdW5OKZO7GJsgck+T835dm0/0fwzU7Pg8lGaJpjHgX4=;
Received: from [193.149.48.129] (helo=blue.greenie.muc.de)
by sfi-mx-2.v28.lw.sourceforge.com with esmtps
(TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.100.1)
id 1xT0e4-0000000052q-2rBX for openvpn-devel@lists.sourceforge.net;
Mon, 16 Nov 2026 17:37:33 +0000
Received: from blue.greenie.muc.de (localhost [127.0.0.1])
by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 6AGHbQ3H024599
for <openvpn-devel@lists.sourceforge.net>; Mon, 16 Nov 2026 18:37:26 +0100
Received: (from gert@localhost)
by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 6AGHbQRF024598
for openvpn-devel@lists.sourceforge.net; Mon, 16 Nov 2026 18:37:26 +0100
From: Gert Doering <gert@greenie.muc.de>
To: openvpn-devel@lists.sourceforge.net
Date: Mon, 16 Nov 2026 18:37:19 +0100
Message-ID: <20261116173725.24585-1-gert@greenie.muc.de>
X-Mailer: git-send-email 2.55.0
In-Reply-To:
<gerrit.1794828082000.I604fdff9c0a7cbbddfd025a72e6f19a96bb51753@gerrit.openvpn.net>
References:
<gerrit.1794828082000.I604fdff9c0a7cbbddfd025a72e6f19a96bb51753@gerrit.openvpn.net>
MIME-Version: 1.0
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software,
running on the system "sfi-spamd-1.hosts.colo.sdot.me",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: From: Razvan Cojocaru <razvanc@mailbox.org> init_key_ctx()
already sets ctx->epoch from the key parameters. Change-Id:
I604fdff9c0a7cbbddfd025a72e6f19a96bb51753
Signed-off-by: Razvan Cojocaru <razvanc@mailbox.org> Acked-by: Frank
Lichtenheld
<frank@lichtenheld.com> Gerrit URL: https://gerrit.openvpn.net/c/o [...]
Content analysis details: (1.3 points, 5.0 required)
pts rule name description
---- ----------------------
--------------------------------------------------
1.3 RDNS_NONE Delivered to internal network by a host with no rDNS
X-Headers-End: 1xT0e4-0000000052q-2rBX
Subject: [Openvpn-devel] [PATCH v1] crypto: drop redundant epoch assignments
X-BeenThere: openvpn-devel@lists.sourceforge.net
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <openvpn-devel.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/options/openvpn-devel>,
<mailto:openvpn-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive:
<http://sourceforge.net/mailarchive/forum.php?forum_name=openvpn-devel>
List-Post: <mailto:openvpn-devel@lists.sourceforge.net>
List-Help: <mailto:openvpn-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/openvpn-devel>,
<mailto:openvpn-devel-request@lists.sourceforge.net?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: openvpn-devel-bounces@lists.sourceforge.net
X-getmail-retrieved-from-mailbox: Inbox
X-GMAIL-THRID: 1882037322098765466
X-GMAIL-MSGID: 1882037322098765466
|
| Series |
[Openvpn-devel,v1] crypto: drop redundant epoch assignments
|
|
Commit Message
Gert Doering
Nov. 16, 2026, 5:37 p.m. UTC
From: Razvan Cojocaru <razvanc@mailbox.org> init_key_ctx() already sets ctx->epoch from the key parameters. Change-Id: I604fdff9c0a7cbbddfd025a72e6f19a96bb51753 Signed-off-by: Razvan Cojocaru <razvanc@mailbox.org> Acked-by: Frank Lichtenheld <frank@lichtenheld.com> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2190 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2190 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Frank Lichtenheld <frank@lichtenheld.com>
diff --git a/src/openvpn/crypto.c b/src/openvpn/crypto.c index db1cb41..dda6702 100644 --- a/src/openvpn/crypto.c +++ b/src/openvpn/crypto.c @@ -1040,7 +1040,6 @@ snprintf(log_prefix, sizeof(log_prefix), "Outgoing %s", name); init_key_ctx(ctx, key_params, kt, OPENVPN_OP_ENCRYPT, log_prefix); key_ctx_update_implicit_iv(ctx, key_params); - ctx->epoch = key_params->epoch; } void @@ -1052,7 +1051,6 @@ snprintf(log_prefix, sizeof(log_prefix), "Incoming %s", name); init_key_ctx(ctx, key_params, kt, OPENVPN_OP_DECRYPT, log_prefix); key_ctx_update_implicit_iv(ctx, key_params); - ctx->epoch = key_params->epoch; } void